Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 11:11:31PM +0200, Peter Zijlstra wrote: > On Thu, Aug 20, 2015 at 07:46:09PM +0900, Byungchul Park wrote: > > On Thu, Aug 20, 2015 at 05:38:41PM +0900, Byungchul Park wrote: > > > On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: > > > > > > > > I did

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 07:46:09PM +0900, Byungchul Park wrote: > On Thu, Aug 20, 2015 at 05:38:41PM +0900, Byungchul Park wrote: > > On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: > > > > > > I did something like this on top.. please have a look at the XXX and > > > integrate. >

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 05:38:41PM +0900, Byungchul Park wrote: > On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: > > > > I did something like this on top.. please have a look at the XXX and > > integrate. > > i am not sure, what do you intend for me to do. > > do you mean that

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: > > I did something like this on top.. please have a look at the XXX and > integrate. i am not sure, what do you intend for me to do. do you mean that i am supposed to integrate this cleanup patch you gave me including the XXX

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: I did something like this on top.. please have a look at the XXX and integrate. i am not sure, what do you intend for me to do. do you mean that i am supposed to integrate this cleanup patch you gave me including the XXX

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 05:38:41PM +0900, Byungchul Park wrote: On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: I did something like this on top.. please have a look at the XXX and integrate. i am not sure, what do you intend for me to do. do you mean that i am

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 11:11:31PM +0200, Peter Zijlstra wrote: On Thu, Aug 20, 2015 at 07:46:09PM +0900, Byungchul Park wrote: On Thu, Aug 20, 2015 at 05:38:41PM +0900, Byungchul Park wrote: On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: I did something like this

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 07:46:09PM +0900, Byungchul Park wrote: On Thu, Aug 20, 2015 at 05:38:41PM +0900, Byungchul Park wrote: On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: I did something like this on top.. please have a look at the XXX and integrate. i am not

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: > > I did something like this on top.. please have a look at the XXX and > integrate. yes, i will do it. > > --- > > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -2664,8 +2664,8 @@ static inline u64

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

I did something like this on top.. please have a look at the XXX and integrate. --- --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2664,8 +2664,8 @@ static inline u64 cfs_rq_clock_task(stru /* Group cfs_rq's load_avg is used for task_h_load and update_cfs_share */ static inline int

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Wed, Aug 19, 2015 at 03:47:11PM +0900, byungchul.p...@lge.com wrote: > From: Byungchul Park > > hello, > > there are 3 problems when att(det)aching a se to(from) its cfs_rq. > > problem 1. se's average load is not accounted with new cfs_rq in queued case, > when a task changes its cgroup. >

[PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

From: Byungchul Park hello, there are 3 problems when att(det)aching a se to(from) its cfs_rq. problem 1. se's average load is not accounted with new cfs_rq in queued case, when a task changes its cgroup. problem 2. cfs_rq->avg.load_avg becomes larger and larger whenever changing cgroup to

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

I did something like this on top.. please have a look at the XXX and integrate. --- --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2664,8 +2664,8 @@ static inline u64 cfs_rq_clock_task(stru /* Group cfs_rq's load_avg is used for task_h_load and update_cfs_share */ static inline int

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote: I did something like this on top.. please have a look at the XXX and integrate. yes, i will do it. --- --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2664,8 +2664,8 @@ static inline u64 cfs_rq_clock_task(stru

[PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

From: Byungchul Park byungchul.p...@lge.com hello, there are 3 problems when att(det)aching a se to(from) its cfs_rq. problem 1. se's average load is not accounted with new cfs_rq in queued case, when a task changes its cgroup. problem 2. cfs_rq-avg.load_avg becomes larger and larger whenever

Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

On Wed, Aug 19, 2015 at 03:47:11PM +0900, byungchul.p...@lge.com wrote: From: Byungchul Park byungchul.p...@lge.com hello, there are 3 problems when att(det)aching a se to(from) its cfs_rq. problem 1. se's average load is not accounted with new cfs_rq in queued case, when a task changes