Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-04-02 Thread shuah
On 4/2/19 6:25 PM, Tobin C. Harding wrote: On Tue, Apr 02, 2019 at 02:37:57PM -0700, Kees Cook wrote: On Wed, Mar 6, 2019 at 1:43 PM Tobin C. Harding wrote: This set makes an attempt at adding a framework to kselftest for writing kernel test modules. It also adds a script for use in creating

Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-04-02 Thread Tobin C. Harding
On Tue, Apr 02, 2019 at 02:37:57PM -0700, Kees Cook wrote: > On Wed, Mar 6, 2019 at 1:43 PM Tobin C. Harding wrote: > > This set makes an attempt at adding a framework to kselftest for writing > > kernel test modules. It also adds a script for use in creating script > > test runners for

Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-04-02 Thread Kees Cook
On Wed, Mar 6, 2019 at 1:43 PM Tobin C. Harding wrote: > This set makes an attempt at adding a framework to kselftest for writing > kernel test modules. It also adds a script for use in creating script > test runners for kselftest. My macro-foo is not great, all criticism > and suggestions very

Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-03-08 Thread Kees Cook
On Thu, Mar 7, 2019 at 9:24 PM Tobin C. Harding wrote: > Two weeks and I'm throwing eggs at your house. If you can gets eggs from there to here I have a whole new international shipping business proposition for you. :) -- Kees Cook

Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-03-07 Thread Tobin C. Harding
On Thu, Mar 07, 2019 at 02:43:57PM -0800, Kees Cook wrote: > On Thu, Mar 7, 2019 at 1:19 PM Tobin C. Harding wrote: > > > > On Thu, Mar 07, 2019 at 08:49:34AM +1100, Tobin C. Harding wrote: > > > On Thu, Mar 07, 2019 at 08:42:19AM +1100, Tobin C. Harding wrote: > > > > Hi, > > > > > > Man, I

Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-03-07 Thread Kees Cook
On Thu, Mar 7, 2019 at 1:19 PM Tobin C. Harding wrote: > > On Thu, Mar 07, 2019 at 08:49:34AM +1100, Tobin C. Harding wrote: > > On Thu, Mar 07, 2019 at 08:42:19AM +1100, Tobin C. Harding wrote: > > > Hi, > > > > Man, I didn't see the merge window was open, I thought rc8 only came out > > on

Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-03-07 Thread Tobin C. Harding
On Thu, Mar 07, 2019 at 08:49:34AM +1100, Tobin C. Harding wrote: > On Thu, Mar 07, 2019 at 08:42:19AM +1100, Tobin C. Harding wrote: > > Hi, > > Man, I didn't see the merge window was open, I thought rc8 only came out > on Sunday. > > Sorry, please ignore this. Will re-send again later in the

Re: [PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-03-06 Thread Tobin C. Harding
On Thu, Mar 07, 2019 at 08:42:19AM +1100, Tobin C. Harding wrote: > Hi, Man, I didn't see the merge window was open, I thought rc8 only came out on Sunday. Sorry, please ignore this. Will re-send again later in the cycle. thanks, Tobin.

[PATCH v3 0/7] lib/string: Add strscpy_pad() function

2019-03-06 Thread Tobin C. Harding
Hi, strscpy_pad() patch set now with added test shenanigans. This version adds 5 initial patches to the set and splits the single patch from v2 into two separate patches (6 and 7). While doing the testing for strscpy_pad() it was noticed that there is duplication in how test modules are being