Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Jason Gunthorpe
On Tue, Sep 22, 2020 at 07:30:32PM +0300, Gal Pressman wrote: > On 22/09/2020 19:14, Jason Gunthorpe wrote: > > On Tue, Sep 22, 2020 at 03:46:29PM +0300, Gal Pressman wrote: > > > >> I agree, that makes sense. > >> But assuming Oded actually goes and implements all the needed verbs to get > >> a

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Gal Pressman
On 22/09/2020 19:14, Jason Gunthorpe wrote: > On Tue, Sep 22, 2020 at 03:46:29PM +0300, Gal Pressman wrote: > >> I agree, that makes sense. >> But assuming Oded actually goes and implements all the needed verbs to get a >> basic functional libibverbs provider (assuming their HW can do it

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Jason Gunthorpe
On Tue, Sep 22, 2020 at 03:46:29PM +0300, Gal Pressman wrote: > I agree, that makes sense. > But assuming Oded actually goes and implements all the needed verbs to get a > basic functional libibverbs provider (assuming their HW can do it somehow), is > it really useful if no one is going to use

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Gal Pressman
On 22/09/2020 14:41, Jason Gunthorpe wrote: > On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote: > >> What is considered a RoCE port in this case if it's not compliant with RoCE? >> Sounds like it's an implementation of RDMA over ethernet, not RoCE. >> Does GAUDI support UD/RC/.. QPs?

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Jason Gunthorpe
On Mon, Sep 21, 2020 at 02:20:53PM -0700, Jakub Kicinski wrote: > I'd wager the only reason you expose the netdevs at all is for link > settings, stats, packet capture and debug. You'd never run TCP traffic > over those links. And you're fighting against using Linux APIs for the > only real

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-22 Thread Jason Gunthorpe
On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote: > What is considered a RoCE port in this case if it's not compliant with RoCE? > Sounds like it's an implementation of RDMA over ethernet, not RoCE. > Does GAUDI support UD/RC/.. QPs? Is it using a proprietary wire protocol? > (BTW,

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Jakub Kicinski
On Mon, 21 Sep 2020 08:52:39 -0300 Jason Gunthorpe wrote: > I don't like this idea of backdooring a bunch of proprietary closed > source RDMA userspace through drivers/misc, and if you don't have a > clear idea how to get something equal for drivers/misc you should not > accept the H_IOCTL_NIC. >

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Jason Gunthorpe
On Sun, Sep 20, 2020 at 10:47:02AM +0200, Greg Kroah-Hartman wrote: > > If not, what open source userspace are you going to ask them to > > present to merge the kernel side into misc? > > I don't think that they have a userspace api to their rdma feature from > what I understand, but I could be

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Leon Romanovsky
On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote: > On 18/09/2020 18:28, Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote: > > > >> I'm sorry, but you won't be able to convince me here that I need to > >> "enslave" my entire code to RDMA, just

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Gal Pressman
On 18/09/2020 18:28, Jason Gunthorpe wrote: > On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote: > >> I'm sorry, but you won't be able to convince me here that I need to >> "enslave" my entire code to RDMA, just because my ASIC "also" has some >> RDMA ports. > > You can't recreate

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Leon Romanovsky
On Sun, Sep 20, 2020 at 10:05:39PM +0300, Oded Gabbay wrote: > On Sun, Sep 20, 2020 at 11:47 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Sep 19, 2020 at 04:22:35PM -0300, Jason Gunthorpe wrote: > > > On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote: > > > > > It's probably

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-20 Thread Oded Gabbay
On Sun, Sep 20, 2020 at 11:47 AM Greg Kroah-Hartman wrote: > > On Sat, Sep 19, 2020 at 04:22:35PM -0300, Jason Gunthorpe wrote: > > On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote: > > > > It's probably heresy, but why do I need to integrate into the RDMA > > > > subsystem ? >

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-20 Thread Daniel Vetter
On Wed, Sep 16, 2020 at 02:00:54PM +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 16, 2020 at 11:47:58AM +0300, Oded Gabbay wrote: > > On Wed, Sep 16, 2020 at 11:21 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Sep 16, 2020 at 11:02:39AM +0300, Oded Gabbay wrote: > > > > On Wed, Sep 16,

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-20 Thread Greg Kroah-Hartman
On Sat, Sep 19, 2020 at 04:22:35PM -0300, Jason Gunthorpe wrote: > On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote: > > > It's probably heresy, but why do I need to integrate into the RDMA > > > subsystem ? > > > I understand your reasoning about networking (Ethernet) as the

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Jason Gunthorpe
On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote: > > It's probably heresy, but why do I need to integrate into the RDMA > > subsystem ? > > I understand your reasoning about networking (Ethernet) as the driver > > connects to the kernel networking stack (netdev), but with RDMA

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Andrew Lunn
On Sat, Sep 19, 2020 at 07:43:28PM +0300, Oded Gabbay wrote: > It's probably heresy, but why do I need to integrate into the RDMA subsystem ? Hi Oded I don't know the RDMA subsystem at all. So i will give a more generic answer. Are you reinventing things which a subsystem core already has? The

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Greg Kroah-Hartman
On Sat, Sep 19, 2020 at 07:43:28PM +0300, Oded Gabbay wrote: > On Sat, Sep 19, 2020 at 11:30 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Sep 19, 2020 at 11:20:03AM +0300, Leon Romanovsky wrote: > > > On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > > > > On Fri, Sep 18,

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Oded Gabbay
On Sat, Sep 19, 2020 at 11:30 AM Greg Kroah-Hartman wrote: > > On Sat, Sep 19, 2020 at 11:20:03AM +0300, Leon Romanovsky wrote: > > On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > > > So we do have an

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Leon Romanovsky
On Sat, Sep 19, 2020 at 10:30:12AM +0200, Greg Kroah-Hartman wrote: > On Sat, Sep 19, 2020 at 11:20:03AM +0300, Leon Romanovsky wrote: > > On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > > > So we do

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Greg Kroah-Hartman
On Sat, Sep 19, 2020 at 11:20:03AM +0300, Leon Romanovsky wrote: > On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > > So we do have an open-source library called hl-thunk, which uses our > > > > driver

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Leon Romanovsky
On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > So we do have an open-source library called hl-thunk, which uses our > > > driver and indeed that was part of the requirement. > > > It is similar to libdrm.

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Greg Kroah-Hartman
On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > So we do have an open-source library called hl-thunk, which uses our > > driver and indeed that was part of the requirement. > > It is similar to libdrm. > > Here is the link: > > https://github.com/HabanaAI/hl-thunk > > Are you

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote: > I'm sorry, but you won't be able to convince me here that I need to > "enslave" my entire code to RDMA, just because my ASIC "also" has some > RDMA ports. You can't recreate common shared subsystems in a driver just because you don't

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 6:07 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 05:45:21PM +0300, Oded Gabbay wrote: > > > Any access by the device's engines to the host memory is done via our > > device's MMU. Our MMU supports multiple ASIDs - Address Space IDs. The > > kernel driver is

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 05:45:21PM +0300, Oded Gabbay wrote: > Any access by the device's engines to the host memory is done via our > device's MMU. Our MMU supports multiple ASIDs - Address Space IDs. The > kernel driver is assigned ASID 0, while the user is assigned ASID 1. > We can support up

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 5:19 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 05:12:04PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 4:59 PM Jason Gunthorpe wrote: > > > > > > On Fri, Sep 18, 2020 at 04:49:25PM +0300, Oded Gabbay wrote: > > > > On Fri, Sep 18, 2020 at 4:26 PM

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 05:12:04PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 4:59 PM Jason Gunthorpe wrote: > > > > On Fri, Sep 18, 2020 at 04:49:25PM +0300, Oded Gabbay wrote: > > > On Fri, Sep 18, 2020 at 4:26 PM Jason Gunthorpe wrote: > > > > > > > > On Fri, Sep 18, 2020 at

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 4:59 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 04:49:25PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 4:26 PM Jason Gunthorpe wrote: > > > > > > On Fri, Sep 18, 2020 at 04:02:24PM +0300, Oded Gabbay wrote: > > > > > > > The problem with MR is that

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 04:49:25PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 4:26 PM Jason Gunthorpe wrote: > > > > On Fri, Sep 18, 2020 at 04:02:24PM +0300, Oded Gabbay wrote: > > > > > The problem with MR is that the API doesn't let us return a new VA. It > > > forces us to use the

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 4:26 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 04:02:24PM +0300, Oded Gabbay wrote: > > > The problem with MR is that the API doesn't let us return a new VA. It > > forces us to use the original VA that the Host OS allocated. > > If using the common MR API

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 04:02:24PM +0300, Oded Gabbay wrote: > The problem with MR is that the API doesn't let us return a new VA. It > forces us to use the original VA that the Host OS allocated. If using the common MR API you'd have to assign a unique linear range in the single device address

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 03:31:51PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 3:19 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 03:07:19PM +0300, Oded Gabbay wrote: > > > On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > > > > > > > On Fri, Sep 18, 2020 at

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:50 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 03:34:54PM +0300, Oded Gabbay wrote: > > > > Another example is that the submission of WQ is done through our QMAN > > > > mechanism and is NOT mapped to userspace (due to the restrictions you > > > > mentioned

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 03:34:54PM +0300, Oded Gabbay wrote: > > > Another example is that the submission of WQ is done through our QMAN > > > mechanism and is NOT mapped to userspace (due to the restrictions you > > > mentioned above and other restrictions). > > > > Sure, other RDMA drivers also

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:16 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 02:59:28PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 2:56 PM Jason Gunthorpe wrote: > > > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > > On 17/09/2020 20:18, Jason

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:19 PM Leon Romanovsky wrote: > > On Fri, Sep 18, 2020 at 03:07:19PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > > > > > On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > > > > On Fri, Sep 18, 2020 at 2:52 PM Leon

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 03:07:19PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > > > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > > > > > On Fri, Sep 18, 2020 at

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 02:59:28PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 2:56 PM Jason Gunthorpe wrote: > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 2:36 PM Gal Pressman wrote: > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > >> infrastructure for communication between multiple accelerators. Same > >> as Nvidia uses NVlink, we use RDMA that we have

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > > On 17/09/2020 20:18, Jason

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 3:00 PM Jason Gunthorpe wrote: > > > On Tue, Sep 15, 2020 at 08:10:08PM +0300, Oded Gabbay wrote: > > Hello, > > > > This is the second version of the patch-set to upstream the GAUDI NIC code > > into the habanalabs driver. > > > > The only modification from v2 is in the

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Tue, Sep 15, 2020 at 08:10:08PM +0300, Oded Gabbay wrote: > Hello, > > This is the second version of the patch-set to upstream the GAUDI NIC code > into the habanalabs driver. > > The only modification from v2 is in the ethtool patch (patch 12). Details > are in that patch's commit message.

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 2:56 PM Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > > >> infrastructure for communication between multiple

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Oded Gabbay
On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > > >> infrastructure for communication between multiple

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Jason Gunthorpe
On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > >> infrastructure for communication between multiple accelerators. Same > >> as Nvidia uses NVlink, we use RDMA that we

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > >> infrastructure for communication between multiple accelerators. Same > >> as Nvidia uses NVlink, we use RDMA that we

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Gal Pressman
On 17/09/2020 20:18, Jason Gunthorpe wrote: > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: >> infrastructure for communication between multiple accelerators. Same >> as Nvidia uses NVlink, we use RDMA that we have inside our ASIC. >> The RDMA implementation we did does NOT support

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-17 Thread Jason Gunthorpe
On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > infrastructure for communication between multiple accelerators. Same > as Nvidia uses NVlink, we use RDMA that we have inside our ASIC. > The RDMA implementation we did does NOT support some basic RDMA > IBverbs (such as MR and PD) and

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Williams, Dan J
On Wed, 2020-09-16 at 10:22 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 16, 2020 at 11:02:39AM +0300, Oded Gabbay wrote: > > On Wed, Sep 16, 2020 at 10:41 AM Greg Kroah-Hartman > > wrote: > > > On Wed, Sep 16, 2020 at 09:36:23AM +0300, Oded Gabbay wrote: > > > > On Wed, Sep 16, 2020 at 9:25 AM

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Greg Kroah-Hartman
On Wed, Sep 16, 2020 at 11:47:58AM +0300, Oded Gabbay wrote: > On Wed, Sep 16, 2020 at 11:21 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 16, 2020 at 11:02:39AM +0300, Oded Gabbay wrote: > > > On Wed, Sep 16, 2020 at 10:41 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Wed, Sep 16,

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Oded Gabbay
On Wed, Sep 16, 2020 at 11:21 AM Greg Kroah-Hartman wrote: > > On Wed, Sep 16, 2020 at 11:02:39AM +0300, Oded Gabbay wrote: > > On Wed, Sep 16, 2020 at 10:41 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Sep 16, 2020 at 09:36:23AM +0300, Oded Gabbay wrote: > > > > On Wed, Sep 16, 2020 at

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Greg Kroah-Hartman
On Wed, Sep 16, 2020 at 11:02:39AM +0300, Oded Gabbay wrote: > On Wed, Sep 16, 2020 at 10:41 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 16, 2020 at 09:36:23AM +0300, Oded Gabbay wrote: > > > On Wed, Sep 16, 2020 at 9:25 AM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Tue, Sep 15,

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Oded Gabbay
On Wed, Sep 16, 2020 at 10:41 AM Greg Kroah-Hartman wrote: > > On Wed, Sep 16, 2020 at 09:36:23AM +0300, Oded Gabbay wrote: > > On Wed, Sep 16, 2020 at 9:25 AM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Sep 15, 2020 at 11:49:12PM +0300, Oded Gabbay wrote: > > > > On Tue, Sep 15, 2020 at

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Greg Kroah-Hartman
On Wed, Sep 16, 2020 at 09:36:23AM +0300, Oded Gabbay wrote: > On Wed, Sep 16, 2020 at 9:25 AM Greg Kroah-Hartman > wrote: > > > > On Tue, Sep 15, 2020 at 11:49:12PM +0300, Oded Gabbay wrote: > > > On Tue, Sep 15, 2020 at 11:42 PM David Miller wrote: > > > > > > > > From: Oded Gabbay > > > >

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Oded Gabbay
On Wed, Sep 16, 2020 at 9:25 AM Greg Kroah-Hartman wrote: > > On Tue, Sep 15, 2020 at 11:49:12PM +0300, Oded Gabbay wrote: > > On Tue, Sep 15, 2020 at 11:42 PM David Miller wrote: > > > > > > From: Oded Gabbay > > > Date: Tue, 15 Sep 2020 20:10:08 +0300 > > > > > > > This is the second version

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-16 Thread Greg Kroah-Hartman
On Tue, Sep 15, 2020 at 11:49:12PM +0300, Oded Gabbay wrote: > On Tue, Sep 15, 2020 at 11:42 PM David Miller wrote: > > > > From: Oded Gabbay > > Date: Tue, 15 Sep 2020 20:10:08 +0300 > > > > > This is the second version of the patch-set to upstream the GAUDI NIC code > > > into the habanalabs

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Oded Gabbay
On Wed, Sep 16, 2020 at 1:34 AM David Miller wrote: > > From: Oded Gabbay > Date: Wed, 16 Sep 2020 00:20:12 +0300 > > > I completely understand but you didn't answer my question. How come > > there are drivers which create netdev objects, and specifically sgi-xp > > in misc (but I also saw it in

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread David Miller
From: Oded Gabbay Date: Wed, 16 Sep 2020 00:20:12 +0300 > I completely understand but you didn't answer my question. How come > there are drivers which create netdev objects, and specifically sgi-xp > in misc (but I also saw it in usb drivers) that live outside > drivers/net ? Why doesn't your

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread David Miller
From: Andrew Lunn Date: Tue, 15 Sep 2020 23:37:35 +0200 >> I understand your point of view but If my H/W doesn't support the >> basic requirements of the RDMA infrastructure and interfaces, then >> really there is nothing I can do about it. I can't use them. > > It is up to the RDMA people to

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread David Miller
From: Oded Gabbay Date: Wed, 16 Sep 2020 00:43:00 +0300 > I honestly don't know and I admit we didn't look at the dates of when > these drivers were introduced. Please do research when you make claims in the future, thank you.

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Oded Gabbay
On Wed, Sep 16, 2020 at 12:37 AM Andrew Lunn wrote: > > > I completely understand but you didn't answer my question. How come > > there are drivers which create netdev objects, and specifically sgi-xp > > in misc (but I also saw it in usb drivers) that live outside > > drivers/net ? Why doesn't

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Andrew Lunn
> I completely understand but you didn't answer my question. How come > there are drivers which create netdev objects, and specifically sgi-xp > in misc (but I also saw it in usb drivers) that live outside > drivers/net ? Why doesn't your request apply to them as well ? > When we wrote the code,

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Oded Gabbay
On Wed, Sep 16, 2020 at 12:04 AM Jakub Kicinski wrote: > > On Tue, 15 Sep 2020 23:46:58 +0300 Oded Gabbay wrote: > > On Tue, Sep 15, 2020 at 11:35 PM Jakub Kicinski wrote: > > > On Tue, 15 Sep 2020 20:10:08 +0300 Oded Gabbay wrote: > > > > Hello, > > > > > > > > This is the second version of the

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 20:10:08 +0300 Oded Gabbay wrote: > Hello, > > This is the second version of the patch-set to upstream the GAUDI NIC code > into the habanalabs driver. > > The only modification from v2 is in the ethtool patch (patch 12). Details > are in that patch's commit message. You

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 23:46:58 +0300 Oded Gabbay wrote: > On Tue, Sep 15, 2020 at 11:35 PM Jakub Kicinski wrote: > > On Tue, 15 Sep 2020 20:10:08 +0300 Oded Gabbay wrote: > > > Hello, > > > > > > This is the second version of the patch-set to upstream the GAUDI NIC code > > > into the habanalabs

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Oded Gabbay
On Tue, Sep 15, 2020 at 11:42 PM David Miller wrote: > > From: Oded Gabbay > Date: Tue, 15 Sep 2020 20:10:08 +0300 > > > This is the second version of the patch-set to upstream the GAUDI NIC code > > into the habanalabs driver. > > > > The only modification from v2 is in the ethtool patch (patch

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Oded Gabbay
On Tue, Sep 15, 2020 at 11:35 PM Jakub Kicinski wrote: > > On Tue, 15 Sep 2020 20:10:08 +0300 Oded Gabbay wrote: > > Hello, > > > > This is the second version of the patch-set to upstream the GAUDI NIC code > > into the habanalabs driver. > > > > The only modification from v2 is in the ethtool

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread David Miller
From: Oded Gabbay Date: Tue, 15 Sep 2020 20:10:08 +0300 > This is the second version of the patch-set to upstream the GAUDI NIC code > into the habanalabs driver. > > The only modification from v2 is in the ethtool patch (patch 12). Details > are in that patch's commit message. > > Link to v2

[PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-15 Thread Oded Gabbay
Hello, This is the second version of the patch-set to upstream the GAUDI NIC code into the habanalabs driver. The only modification from v2 is in the ethtool patch (patch 12). Details are in that patch's commit message. Link to v2 cover letter: https://lkml.org/lkml/2020/9/12/201 Thanks, Oded