Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-14 Thread Leon Romanovsky
.boss...@linux.intel.com; > > > fred...@linux.intel.com; pa...@mellanox.com; Saleem, Shiraz > > > ; Williams, Dan J ; > > > Patil, Kiran ; linux-kernel@vger.kernel.org; > > > leo...@nvidia.com > > > Subject: Re: [PATCH v3 01/10] Add auxiliary bus su

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-13 Thread Greg KH
gt; > ; Williams, Dan J ; > > Patil, Kiran ; linux-kernel@vger.kernel.org; > > leo...@nvidia.com > > Subject: Re: [PATCH v3 01/10] Add auxiliary bus support > > > > On Thu, Oct 22, 2020 at 05:33:29PM -0700, Dave Ertman wrote: > > > Add support for the Auxiliary

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-13 Thread Ertman, David M
a...@davemloft.net; k...@kernel.org; > ranjani.sridha...@linux.intel.com; pierre-louis.boss...@linux.intel.com; > fred...@linux.intel.com; pa...@mellanox.com; Saleem, Shiraz > ; Williams, Dan J ; > Patil, Kiran ; linux-kernel@vger.kernel.org; > leo...@nvidia.com > Subject: Re: [PA

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-13 Thread Greg KH
On Thu, Oct 22, 2020 at 05:33:29PM -0700, Dave Ertman wrote: > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. > It enables drivers to create an auxiliary_device and bind an > auxiliary_driver to it. > > The bus supports probe/remove shutdown and suspend/resume

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-09 Thread Oded Gabbay
On Fri, Nov 06, 2020 at 07:35:37PM +, Mark Brown wrote: > On Thu, Nov 05, 2020 at 08:37:14PM +, Parav Pandit wrote: > > > > > This example describes the mlx5 PCI subfunction use case. > > > > I didn't follow your question about 'explicit example'. > > > > What part is missing to identify

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-06 Thread Mark Brown
On Thu, Nov 05, 2020 at 08:37:14PM +, Parav Pandit wrote: > > > This example describes the mlx5 PCI subfunction use case. > > > I didn't follow your question about 'explicit example'. > > > What part is missing to identify it as explicit example? > > Specifically listing "mlx5" so if someone

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Ertman, David M
inski ; Greg KH ; > Ranjani Sridharan ; Pierre-Louis Bossart > ; Fred Oh ; > Parav Pandit ; Saleem, Shiraz > ; Patil, Kiran ; Linux > Kernel Mailing List ; Leon Romanovsky > > Subject: Re: [PATCH v3 01/10] Add auxiliary bus support > > On Thu, Nov 5, 2020 at

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 11:28 AM Ertman, David M wrote: [..] > > > Each auxiliary_device represents a part of its parent > > > +functionality. The generic behavior can be extended and specialized as > > needed > > > +by encapsulating an auxiliary_device within other domain-specific > > structures

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Ertman, David M
vid Miller ; Jakub Kicinski ; > Greg KH ; Ranjani Sridharan > ; Pierre-Louis Bossart louis.boss...@linux.intel.com>; Fred Oh ; Parav > Pandit ; Saleem, Shiraz ; > Patil, Kiran ; Linux Kernel Mailing List ker...@vger.kernel.org> > Subject: Re: [PATCH v3 01/10] Add auxiliary bus

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Parav Pandit
> From: Dan Williams > Sent: Friday, November 6, 2020 1:56 AM > > On Thu, Nov 5, 2020 at 11:40 AM Parav Pandit wrote: > > > > > > > > > From: Ertman, David M > > > Sent: Friday, November 6, 2020 12:58 AM > > >

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 11:30 AM Leon Romanovsky wrote: > > On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > > On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > > > > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > > > > Some doc fixups, and minor code

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 11:40 AM Parav Pandit wrote: > > > > > From: Ertman, David M > > Sent: Friday, November 6, 2020 12:58 AM > > Subject: RE: [PATCH v3 01/10] Add auxiliary bus support > > > > > -Original Message- > > > From: Dan Wi

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 12:21 PM Greg KH wrote: > > On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > > > > > > > > Per above SPDX is v2 only, so... > > > > > > Isn't it default for the Linux kernel? > > > > SPDX eliminated the need to guess a default, and MODULE_LICENSE("GPL") > >

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Greg KH
On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > > > > > > Per above SPDX is v2 only, so... > > > > Isn't it default for the Linux kernel? > > SPDX eliminated the need to guess a default, and MODULE_LICENSE("GPL") > implies the "or later" language. The only default assumption is

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Parav Pandit
> From: Ertman, David M > Sent: Friday, November 6, 2020 12:58 AM > Subject: RE: [PATCH v3 01/10] Add auxiliary bus support > > > -Original Message- > > From: Dan Williams > > Sent: Thursday, November 5, 2020 1:19 AM > > [..] > > > +

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2020 at 01:32:40PM -0600, Pierre-Louis Bossart wrote: > > > > > +module_init(auxiliary_bus_init); > > > > +module_exit(auxiliary_bus_exit); > > > > + > > > > +MODULE_LICENSE("GPL"); > > > > > > Per above SPDX is v2 only, so... > > > > > > MODULE_LICENSE("GPL v2"); > > > > > > >

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Leon Romanovsky
ux-rdma ; Jason > > Gunthorpe ; Doug Ledford ; > > Netdev ; David Miller ; > > Jakub Kicinski ; Greg KH ; > > Ranjani Sridharan ; Pierre-Louis Bossart > > ; Fred Oh ; > > Parav Pandit ; Saleem, Shiraz > > ; Patil, Kiran ; Linux > > Kernel Mailing Lis

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Pierre-Louis Bossart
+module_init(auxiliary_bus_init); +module_exit(auxiliary_bus_exit); + +MODULE_LICENSE("GPL"); Per above SPDX is v2 only, so... MODULE_LICENSE("GPL v2"); added v2. "GPL v2" is the same as "GPL" here, it does not have any additional meaning.

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote: > On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > > > On Thu, Oct 22, 2020

RE: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Ertman, David M
inski ; Greg KH ; > Ranjani Sridharan ; Pierre-Louis Bossart > ; Fred Oh ; > Parav Pandit ; Saleem, Shiraz > ; Patil, Kiran ; Linux > Kernel Mailing List ; Leon Romanovsky > > Subject: Re: [PATCH v3 01/10] Add auxiliary bus support > > Some doc fixups, and minor code fee

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky wrote: > > On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman > > wrote: > > > > > <...> > > > > > > > +config

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote: > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman wrote: > > <...> > > > > +config AUXILIARY_BUS > > + bool > > tristate? Unless you need non-exported

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-05 Thread Dan Williams
Some doc fixups, and minor code feedback. Otherwise looks good to me. On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman wrote: > > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. > It enables drivers to create an auxiliary_device and bind an > auxiliary_driver to it. > > The

[PATCH v3 01/10] Add auxiliary bus support

2020-10-22 Thread Dave Ertman
Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. It enables drivers to create an auxiliary_device and bind an auxiliary_driver to it. The bus supports probe/remove shutdown and suspend/resume callbacks. Each auxiliary_device has a unique string based id; driver binds to