Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-08-05 Thread Mathieu Poirier
On 6 July 2015 at 04:08, Alexander Shishkin wrote: > A System Trace Module (STM) is a device exporting data in System Trace > Protocol (STP) format as defined by MIPI STP standards. Examples of such > devices are Intel Trace Hub and Coresight STM. > > This abstraction provides a unified interface

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-30 Thread Alexander Shishkin
Chunyan Zhang writes: > The code has already been submitted like I said in the earlier emails, > you may refer [1]. > > Thanks, > Chunyan > > [1] https://lkml.org/lkml/2015/2/4/729 This code does the following (pasting from that patch): in stm_probe(): drvdata = devm_kzalloc(dev, sizeof(*drvda

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-30 Thread Chunyan Zhang
On Thu, Jul 30, 2015 at 2:59 PM, Chunyan Zhang wrote: > On Thu, Jul 30, 2015 at 2:37 PM, Alexander Shishkin > wrote: >> Chunyan Zhang writes: >> >>> Sure, I mean, the root reason of this problem is here ( i.e. >>> "stm_core_up" was zero then): >>> if (!stm_core_up) >>> return -EPRO

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Chunyan Zhang
On Thu, Jul 30, 2015 at 2:37 PM, Alexander Shishkin wrote: > Chunyan Zhang writes: > >> Sure, I mean, the root reason of this problem is here ( i.e. >> "stm_core_up" was zero then): >> if (!stm_core_up) >> return -EPROBE_DEFER; >> >> Why it was zero? >> Because the function (i.e. st

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Alexander Shishkin
Chunyan Zhang writes: > Sure, I mean, the root reason of this problem is here ( i.e. > "stm_core_up" was zero then): > if (!stm_core_up) > return -EPROBE_DEFER; > > Why it was zero? > Because the function (i.e. stm_core_init() ) in which "stm_core_up" > would be added one hasn't bee

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Chunyan Zhang
On Thu, Jul 30, 2015 at 1:45 PM, Alexander Shishkin wrote: > Chunyan Zhang writes: > >> If let stm_probe() implement probe deferral, it has to have a global >> variable for the later calling of "stm_register_device", because the > > No, it doesn't. Please read about probe deferral. Could you ple

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Alexander Shishkin
Chunyan Zhang writes: > If let stm_probe() implement probe deferral, it has to have a global > variable for the later calling of "stm_register_device", because the No, it doesn't. Please read about probe deferral. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Chunyan Zhang
On Wed, Jul 29, 2015 at 9:46 PM, Alexander Shishkin wrote: > Mark Brown writes: > >> On Wed, Jul 29, 2015 at 04:25:10PM +0300, Alexander Shishkin wrote: >> >>> There has to be a way to defer stm_probe(), although a quick look at >>> amba code suggests it's not implemented. >> >> What makes you sa

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Chunyan Zhang
On Wed, Jul 29, 2015 at 9:25 PM, Alexander Shishkin wrote: > Chunyan Zhang writes: > >>> +/** >>> + * stm_source_register_device() - register an stm_source device >>> + * @parent:parent device >>> + * @data: device description structure >>> + * >>> + * This will create a device of stm_so

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Alexander Shishkin
Mark Brown writes: > On Wed, Jul 29, 2015 at 04:25:10PM +0300, Alexander Shishkin wrote: > >> There has to be a way to defer stm_probe(), although a quick look at >> amba code suggests it's not implemented. > > What makes you say this? Probe deferral is implemented in the driver > core rather th

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Mark Brown
On Wed, Jul 29, 2015 at 04:25:10PM +0300, Alexander Shishkin wrote: > There has to be a way to defer stm_probe(), although a quick look at > amba code suggests it's not implemented. What makes you say this? Probe deferral is implemented in the driver core rather than individual buses, the buses

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-29 Thread Alexander Shishkin
Chunyan Zhang writes: >> +/** >> + * stm_source_register_device() - register an stm_source device >> + * @parent:parent device >> + * @data: device description structure >> + * >> + * This will create a device of stm_source class that can write >> + * data to an stm device once linked. >

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-28 Thread Chunyan Zhang
On Mon, Jul 6, 2015 at 6:08 PM, Alexander Shishkin wrote: > A System Trace Module (STM) is a device exporting data in System Trace > Protocol (STP) format as defined by MIPI STP standards. Examples of such > devices are Intel Trace Hub and Coresight STM. > > This abstraction provides a unified int

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-08 Thread Alexander Shishkin
Chunyan Zhang writes: >> +int __init stp_configfs_init(void) >> +{ >> + int err; >> + >> + config_group_init(&stp_policy_subsys.su_group); >> + mutex_init(&stp_policy_subsys.su_mutex); >> + err = configfs_register_subsystem(&stp_policy_subsys); >> + >> + return err;

Re: [PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-08 Thread Chunyan Zhang
On Mon, Jul 6, 2015 at 6:08 PM, Alexander Shishkin wrote: > A System Trace Module (STM) is a device exporting data in System Trace > Protocol (STP) format as defined by MIPI STP standards. Examples of such > devices are Intel Trace Hub and Coresight STM. > > This abstraction provides a unified int

[PATCH v3 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-07-06 Thread Alexander Shishkin
A System Trace Module (STM) is a device exporting data in System Trace Protocol (STP) format as defined by MIPI STP standards. Examples of such devices are Intel Trace Hub and Coresight STM. This abstraction provides a unified interface for software trace sources to send their data over an STM dev