Re: [PATCH v3 01/33] mtd: rawnand: brcmnand: convert driver to nand_scan()

2018-07-20 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Fri, 20 Jul 2018 01:17:19 +0200: > On Fri, 20 Jul 2018 00:59:54 +0200 > Miquel Raynal wrote: > > > + > > +static struct nand_controller_ops brcmnand_controller_ops = { > > static const ... Mmmh right, I'll constify every controller_ops definition. > > T

Re: [PATCH v3 01/33] mtd: rawnand: brcmnand: convert driver to nand_scan()

2018-07-19 Thread Boris Brezillon
On Fri, 20 Jul 2018 00:59:54 +0200 Miquel Raynal wrote: > + > +static struct nand_controller_ops brcmnand_controller_ops = { static const ... The same comment applies to all patches of this series. > + .attach_chip = brcmnand_attach_chip, > +};

[PATCH v3 01/33] mtd: rawnand: brcmnand: convert driver to nand_scan()

2018-07-19 Thread Miquel Raynal
Two helpers have been added to the core to make ECC-related configuration between the detection phase and the final NAND scan. Use these hooks and convert the driver to just use nand_scan() instead of both nand_scan_ident() and nand_scan_tail(). Signed-off-by: Miquel Raynal --- drivers/mtd/nand/