Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-18 Thread Dan Carpenter
On Sun, May 17, 2015 at 10:38:48PM +0200, Mateusz Kulikowski wrote: > On 15.05.2015 01:14, Dan Carpenter wrote: > > On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: > >> On 13.05.2015 10:22, Dan Carpenter wrote: > >>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-18 Thread Dan Carpenter
On Sun, May 17, 2015 at 10:38:48PM +0200, Mateusz Kulikowski wrote: On 15.05.2015 01:14, Dan Carpenter wrote: On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: On 13.05.2015 10:22, Dan Carpenter wrote: On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-17 Thread Mateusz Kulikowski
On 15.05.2015 01:14, Dan Carpenter wrote: > On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: >> On 13.05.2015 10:22, Dan Carpenter wrote: >>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: On 11.05.2015 10:26, Dan Carpenter wrote: >> (...) > >

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-17 Thread Mateusz Kulikowski
On 15.05.2015 01:14, Dan Carpenter wrote: On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: On 13.05.2015 10:22, Dan Carpenter wrote: On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: On 11.05.2015 10:26, Dan Carpenter wrote: (...) Which part isn't

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-14 Thread Dan Carpenter
On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: > On 13.05.2015 10:22, Dan Carpenter wrote: > > On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: > >> On 11.05.2015 10:26, Dan Carpenter wrote: > (...) > >>> > >>> Which part isn't aligned? I think they both

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-14 Thread Mateusz Kulikowski
On 13.05.2015 10:22, Dan Carpenter wrote: > On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: >> On 11.05.2015 10:26, Dan Carpenter wrote: (...) >>> >>> Which part isn't aligned? I think they both are. >>> >> struct rtllib_rxb *prxb = prxbIndicateArray[j]; >> >> struct

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-14 Thread Mateusz Kulikowski
On 13.05.2015 10:22, Dan Carpenter wrote: On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: On 11.05.2015 10:26, Dan Carpenter wrote: (...) Which part isn't aligned? I think they both are. struct rtllib_rxb *prxb = prxbIndicateArray[j]; struct rtllib_rxb { u8

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-14 Thread Dan Carpenter
On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: On 13.05.2015 10:22, Dan Carpenter wrote: On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: On 11.05.2015 10:26, Dan Carpenter wrote: (...) Which part isn't aligned? I think they both are. struct

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-13 Thread Dan Carpenter
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: > On 11.05.2015 10:26, Dan Carpenter wrote: > (...) > >> */ > >>skb_pull(sub_skb, SNAP_SIZE); > >> - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-13 Thread Dan Carpenter
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: On 11.05.2015 10:26, Dan Carpenter wrote: (...) */ skb_pull(sub_skb, SNAP_SIZE); - memcpy(skb_push(sub_skb, ETH_ALEN), prxb-src, ETH_ALEN);

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-12 Thread Mateusz Kulikowski
On 10.05.2015 15:20, Greg KH wrote: > On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: >> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY >> checkpatch.pl warning. >> It will prevent accidential "Fix" to ether_addr_copy(). > > What do you mean by this? Why will

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-12 Thread Mateusz Kulikowski
On 11.05.2015 10:26, Dan Carpenter wrote: (...) >> */ >> skb_pull(sub_skb, SNAP_SIZE); >> -memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src, >> ETH_ALEN); >> -memcpy(skb_push(sub_skb,

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-12 Thread Mateusz Kulikowski
On 10.05.2015 15:20, Greg KH wrote: On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY checkpatch.pl warning. It will prevent accidential Fix to ether_addr_copy(). What do you mean by this? Why will the comment

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-12 Thread Mateusz Kulikowski
On 11.05.2015 10:26, Dan Carpenter wrote: (...) */ skb_pull(sub_skb, SNAP_SIZE); -memcpy(skb_push(sub_skb, ETH_ALEN), prxb-src, ETH_ALEN); -memcpy(skb_push(sub_skb, ETH_ALEN),

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-11 Thread Dan Carpenter
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: > Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY > checkpatch.pl warning. > It will prevent accidential "Fix" to ether_addr_copy(). > > Signed-off-by: Mateusz Kulikowski > --- >

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-11 Thread Dan Carpenter
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY checkpatch.pl warning. It will prevent accidential Fix to ether_addr_copy(). Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com ---

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-10 Thread Greg KH
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: > Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY > checkpatch.pl warning. > It will prevent accidential "Fix" to ether_addr_copy(). What do you mean by this? Why will the comment remove the issue? -- To

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-10 Thread Greg KH
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote: Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY checkpatch.pl warning. It will prevent accidential Fix to ether_addr_copy(). What do you mean by this? Why will the comment remove the issue? -- To unsubscribe

[PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-09 Thread Mateusz Kulikowski
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY checkpatch.pl warning. It will prevent accidential "Fix" to ether_addr_copy(). Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_rx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-)

[PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-09 Thread Mateusz Kulikowski
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY checkpatch.pl warning. It will prevent accidential Fix to ether_addr_copy(). Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com --- drivers/staging/rtl8192e/rtllib_rx.c | 20 1 file changed, 12