On Sun, May 17, 2015 at 10:38:48PM +0200, Mateusz Kulikowski wrote:
> On 15.05.2015 01:14, Dan Carpenter wrote:
> > On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
> >> On 13.05.2015 10:22, Dan Carpenter wrote:
> >>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski
On Sun, May 17, 2015 at 10:38:48PM +0200, Mateusz Kulikowski wrote:
On 15.05.2015 01:14, Dan Carpenter wrote:
On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
On 13.05.2015 10:22, Dan Carpenter wrote:
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
On 15.05.2015 01:14, Dan Carpenter wrote:
> On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
>> On 13.05.2015 10:22, Dan Carpenter wrote:
>>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
On 11.05.2015 10:26, Dan Carpenter wrote:
>> (...)
>
>
On 15.05.2015 01:14, Dan Carpenter wrote:
On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
On 13.05.2015 10:22, Dan Carpenter wrote:
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
Which part isn't
On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
> On 13.05.2015 10:22, Dan Carpenter wrote:
> > On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
> >> On 11.05.2015 10:26, Dan Carpenter wrote:
> (...)
> >>>
> >>> Which part isn't aligned? I think they both
On 13.05.2015 10:22, Dan Carpenter wrote:
> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
>> On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
>>>
>>> Which part isn't aligned? I think they both are.
>>>
>> struct rtllib_rxb *prxb = prxbIndicateArray[j];
>>
>> struct
On 13.05.2015 10:22, Dan Carpenter wrote:
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
Which part isn't aligned? I think they both are.
struct rtllib_rxb *prxb = prxbIndicateArray[j];
struct rtllib_rxb {
u8
On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote:
On 13.05.2015 10:22, Dan Carpenter wrote:
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
Which part isn't aligned? I think they both are.
struct
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
> On 11.05.2015 10:26, Dan Carpenter wrote:
> (...)
> >> */
> >>skb_pull(sub_skb, SNAP_SIZE);
> >> - memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote:
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
*/
skb_pull(sub_skb, SNAP_SIZE);
- memcpy(skb_push(sub_skb, ETH_ALEN), prxb-src,
ETH_ALEN);
On 10.05.2015 15:20, Greg KH wrote:
> On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
>> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
>> checkpatch.pl warning.
>> It will prevent accidential "Fix" to ether_addr_copy().
>
> What do you mean by this? Why will
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
>> */
>> skb_pull(sub_skb, SNAP_SIZE);
>> -memcpy(skb_push(sub_skb, ETH_ALEN), prxb->src,
>> ETH_ALEN);
>> -memcpy(skb_push(sub_skb,
On 10.05.2015 15:20, Greg KH wrote:
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential Fix to ether_addr_copy().
What do you mean by this? Why will the comment
On 11.05.2015 10:26, Dan Carpenter wrote:
(...)
*/
skb_pull(sub_skb, SNAP_SIZE);
-memcpy(skb_push(sub_skb, ETH_ALEN), prxb-src,
ETH_ALEN);
-memcpy(skb_push(sub_skb, ETH_ALEN),
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
> checkpatch.pl warning.
> It will prevent accidential "Fix" to ether_addr_copy().
>
> Signed-off-by: Mateusz Kulikowski
> ---
>
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential Fix to ether_addr_copy().
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
> Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
> checkpatch.pl warning.
> It will prevent accidential "Fix" to ether_addr_copy().
What do you mean by this? Why will the comment remove the issue?
--
To
On Sat, May 09, 2015 at 11:18:51PM +0200, Mateusz Kulikowski wrote:
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential Fix to ether_addr_copy().
What do you mean by this? Why will the comment remove the issue?
--
To unsubscribe
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential "Fix" to ether_addr_copy().
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
Comment unaligned memcpy() that trigger PREFER_ETHER_ADDR_COPY
checkpatch.pl warning.
It will prevent accidential Fix to ether_addr_copy().
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_rx.c | 20
1 file changed, 12
20 matches
Mail list logo