Re: [PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-28 Thread Alex Ghiti
On 4/18/19 10:19 AM, Kees Cook wrote: On Thu, Apr 18, 2019 at 12:55 AM Alex Ghiti wrote: Regarding the help text, I agree that it does not seem to be frequent to place comment above config like that, I'll let Christoph and you decide what's best. And I'll add the possibility for the arch to

Re: [PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-22 Thread Christoph Hellwig
On Thu, Apr 18, 2019 at 09:19:18AM -0500, Kees Cook wrote: > On Thu, Apr 18, 2019 at 12:55 AM Alex Ghiti wrote: > > Regarding the help text, I agree that it does not seem to be frequent to > > place > > comment above config like that, I'll let Christoph and you decide what's > > best. And I'll >

Re: [PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-22 Thread Christoph Hellwig
On Wed, Apr 17, 2019 at 01:22:40AM -0400, Alexandre Ghiti wrote: > arm64 handles top-down mmap layout in a way that can be easily reused > by other architectures, so make it available in mm. > It then introduces a new config ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT > that can be set by other

Re: [PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-19 Thread Alex Ghiti
On 4/18/19 10:19 AM, Kees Cook wrote: On Thu, Apr 18, 2019 at 12:55 AM Alex Ghiti wrote: Regarding the help text, I agree that it does not seem to be frequent to place comment above config like that, I'll let Christoph and you decide what's best. And I'll add the possibility for the arch to

Re: [PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-18 Thread Kees Cook
On Thu, Apr 18, 2019 at 12:55 AM Alex Ghiti wrote: > Regarding the help text, I agree that it does not seem to be frequent to > place > comment above config like that, I'll let Christoph and you decide what's > best. And I'll > add the possibility for the arch to define its own STACK_RND_MASK.

Re: [PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-17 Thread Alex Ghiti
On 4/18/19 1:17 AM, Kees Cook wrote: ( On Wed, Apr 17, 2019 at 12:27 AM Alexandre Ghiti wrote: arm64 handles top-down mmap layout in a way that can be easily reused by other architectures, so make it available in mm. It then introduces a new config ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT that

Re: [PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-17 Thread Kees Cook
( On Wed, Apr 17, 2019 at 12:27 AM Alexandre Ghiti wrote: > > arm64 handles top-down mmap layout in a way that can be easily reused > by other architectures, so make it available in mm. > It then introduces a new config ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT > that can be set by other

[PATCH v3 04/11] arm64, mm: Move generic mmap layout functions to mm

2019-04-16 Thread Alexandre Ghiti
arm64 handles top-down mmap layout in a way that can be easily reused by other architectures, so make it available in mm. It then introduces a new config ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT that can be set by other architectures to benefit from those functions. Note that this new config depends