Re: [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection

2019-05-09 Thread Andy Shevchenko
On Thu, May 9, 2019 at 8:29 PM Yurii Pavlovskyi wrote: > On 08.05.19 15:36, Andy Shevchenko wrote:> On Fri, Apr 19, 2019 at 1:08 PM > Yurii Pavlovskyi > > wrote: > >> int rv; > >> + char *wmi_uid; > > > > Keep them in reversed spruce order. > > What do you mean by that? Do you mean

Re: [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection

2019-05-09 Thread Yurii Pavlovskyi
On 08.05.19 15:36, Andy Shevchenko wrote:> On Fri, Apr 19, 2019 at 1:08 PM Yurii Pavlovskyi > wrote: >> int rv; >> + char *wmi_uid; > > Keep them in reversed spruce order. What do you mean by that? Do you mean like this? + char *wmi_uid; int rv; int err; >> +#define

Re: [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection

2019-05-09 Thread Daniel Drake
> > -#define ASUS_WMI_METHODID_DSTS 0x53544344 /* Device STatuS */ > > -#define ASUS_WMI_METHODID_DSTS20x53545344 /* Device STatuS > > #2*/ > > > +#define ASUS_WMI_METHODID_DSTS 0x53544344 /* Device STatuS (DCTS) > > */ > > It's not clear from the description what

Re: [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection

2019-05-08 Thread Andy Shevchenko
On Fri, Apr 19, 2019 at 1:08 PM Yurii Pavlovskyi wrote: > > The DSTS method detection mistakenly selects DCTS instead of DSTS if > nothing is returned when the method ID is not defined in WMNB. As a result, > the control of keyboard backlight is not functional for TUF Gaming series > laptops.

[PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection

2019-04-19 Thread Yurii Pavlovskyi
The DSTS method detection mistakenly selects DCTS instead of DSTS if nothing is returned when the method ID is not defined in WMNB. As a result, the control of keyboard backlight is not functional for TUF Gaming series laptops. Implement another detection method instead. There is evidence that