Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-08 Thread Stephen Boyd
Quoting Andy Shevchenko (2021-04-08 07:05:54) > On Thu, Apr 08, 2021 at 03:44:57PM +0200, Jessica Yu wrote: > > +++ Stephen Boyd [30/03/21 20:05 -0700]: > > ... > > > > +static void init_build_id(struct module *mod, const struct load_info > > > *info) > > > +{ > > > + const Elf_Shdr *sechdr;

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-08 Thread Andy Shevchenko
On Thu, Apr 08, 2021 at 03:44:57PM +0200, Jessica Yu wrote: > +++ Stephen Boyd [30/03/21 20:05 -0700]: ... > > +static void init_build_id(struct module *mod, const struct load_info *info) > > +{ > > + const Elf_Shdr *sechdr; > > + unsigned int i; > > + > > + for (i = 0; i <

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-08 Thread Jessica Yu
+++ Stephen Boyd [30/03/21 20:05 -0700]: [snipped] diff --git a/kernel/module.c b/kernel/module.c index 30479355ab85..6f5bc1b046a5 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -2770,6 +2771,20 @@

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-08 Thread Stephen Boyd
Quoting Petr Mladek (2021-04-07 08:03:47) > On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > This makes it simpler for developers to locate a

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 07, 2021 at 05:03:47PM +0200, Petr Mladek wrote: > On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > Please add something like: > > /* Keep BUILD_ID_SIZE_MAX in sync with the below used %20phN */ > BUILD_BUG_ON(BUILD_ID_SIZE_MAX != 20) > > to make sure the the hard Why

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 07, 2021 at 04:54:33PM +0200, Petr Mladek wrote: > On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > This makes it simpler for

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-07 Thread Petr Mladek
On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > Let's make kernel stacktraces easier to identify by including the build > ID[1] of a module if the stacktrace is printing a symbol from a module. > This makes it simpler for developers to locate a kernel module's full > debuginfo for a particular

Re: [PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-04-07 Thread Petr Mladek
On Tue 2021-03-30 20:05:12, Stephen Boyd wrote: > Let's make kernel stacktraces easier to identify by including the build > ID[1] of a module if the stacktrace is printing a symbol from a module. > This makes it simpler for developers to locate a kernel module's full > debuginfo for a particular

[PATCH v3 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-30 Thread Stephen Boyd
Let's make kernel stacktraces easier to identify by including the build ID[1] of a module if the stacktrace is printing a symbol from a module. This makes it simpler for developers to locate a kernel module's full debuginfo for a particular stacktrace. Combined with scripts/decode_stracktrace.sh,