Actually, to be honest, I would prefer if you moved things without
changing it too much. I have a script to review "move code to a new
function" patches but if everything moves and changes as well then it's
confusing and I have to do it by hand.
regards,
dan carpenter
--
To unsubscribe from
Actually, to be honest, I would prefer if you moved things without
changing it too much. I have a script to review move code to a new
function patches but if everything moves and changes as well then it's
confusing and I have to do it by hand.
regards,
dan carpenter
--
To unsubscribe from this
On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 09:49, Sudip Mukherjee wrote:
> > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>
> You're running checkpatch --strict right?
>
> > 1) multiple blank lines
> > 2) Blank lines aren't
On 10.05.2015 09:49, Sudip Mukherjee wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
>> Code was not altered significantly, therefore in some places it generates
>> LONG_LINE checkpatch.pl
On 11.05.2015 15:48, Dan Carpenter wrote:
> On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>> +if (info_element->len >= 4 &&
>> +info_element->data[0] == 0x00 && info_element->data[1] == 0x50 &&
>> +info_element->data[2] == 0xf2 && info_element->data[3] ==
On 11.05.2015 15:48, Dan Carpenter wrote:
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
+if (info_element-len = 4
+info_element-data[0] == 0x00 info_element-data[1] == 0x50
+info_element-data[2] == 0xf2 info_element-data[3] == 0x01) {
This if
On 10.05.2015 09:49, Sudip Mukherjee wrote:
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote:
On 10.05.2015 09:49, Sudip Mukherjee wrote:
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
You're running checkpatch --strict right?
1) multiple blank lines
2) Blank lines aren't necessary before a
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
> + if (info_element->len >= 4 &&
> + info_element->data[0] == 0x00 && info_element->data[1] == 0x50 &&
> + info_element->data[2] == 0xf2 && info_element->data[3] == 0x01) {
This if statement was actually
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
+ if (info_element-len = 4
+ info_element-data[0] == 0x00 info_element-data[1] == 0x50
+ info_element-data[2] == 0xf2 info_element-data[3] == 0x01) {
This if statement was actually easier to read in
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
> Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
> Code was not altered significantly, therefore in some places it generates
> LONG_LINE checkpatch.pl warnings.
apart from long line it is also giving
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
apart from long line it is also giving warnings
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/rtl8192e/rtllib_rx.c | 364
Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
Code was not altered significantly, therefore in some places it generates
LONG_LINE checkpatch.pl warnings.
Signed-off-by: Mateusz Kulikowski mateusz.kulikow...@gmail.com
---
drivers/staging/rtl8192e/rtllib_rx.c | 364
14 matches
Mail list logo
