Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu

2020-09-21 Thread Will Deacon
On Mon, Sep 21, 2020 at 03:53:20PM +0100, David Brazdil wrote: > > Cosmetic, but I think it would be cleaner just to define two variants of the > > macro here: > > > > #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__) > > .macro this_cpu_offset, dst > > mrs \dst,

Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu

2020-09-21 Thread David Brazdil
Hi Will, > Cosmetic, but I think it would be cleaner just to define two variants of the > macro here: > > #if defined(__KVM_NVHE_HYPERVISOR__) || defined(__KVM_VHE_HYPERVISOR__) > .macro this_cpu_offset, dst > mrs \dst, tpidr_el2 > .endm > #else > .macro this_cpu_off

Re: [PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu

2020-09-18 Thread Will Deacon
On Wed, Sep 16, 2020 at 06:34:33PM +0100, David Brazdil wrote: > The hyp_adr/ldr_this_cpu helpers were introduced for use in hyp code > because they always needed to use TPIDR_EL2 for base, while > adr/ldr_this_cpu from kernel proper would select between TPIDR_EL2 and > _EL1 based on VHE/nVHE. > >

[PATCH v3 05/11] kvm: arm64: Remove hyp_adr/ldr_this_cpu

2020-09-16 Thread David Brazdil
The hyp_adr/ldr_this_cpu helpers were introduced for use in hyp code because they always needed to use TPIDR_EL2 for base, while adr/ldr_this_cpu from kernel proper would select between TPIDR_EL2 and _EL1 based on VHE/nVHE. Simplify this now that the hyp mode case can be handled using the __KVM_VH