Re: [PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-31 Thread Mark Rutland
On Mon, Oct 30, 2017 at 01:27:22PM -0700, Mark Salyzyn wrote: > Thanks for the review, am taking all the points into consideration. > > On 10/30/2017 07:15 AM, Mark Rutland wrote: > > > + > > > + typeof(((struct vdso_data *)vd)->xtime_clock_sec) sec; > > Why do we need to do this typeof() magic?

Re: [PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-31 Thread Mark Rutland
On Mon, Oct 30, 2017 at 01:27:22PM -0700, Mark Salyzyn wrote: > Thanks for the review, am taking all the points into consideration. > > On 10/30/2017 07:15 AM, Mark Rutland wrote: > > > + > > > + typeof(((struct vdso_data *)vd)->xtime_clock_sec) sec; > > Why do we need to do this typeof() magic?

Re: [PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-30 Thread Mark Salyzyn
Thanks for the review, am taking all the points into consideration. On 10/30/2017 07:15 AM, Mark Rutland wrote: + + typeof(((struct vdso_data *)vd)->xtime_clock_sec) sec; Why do we need to do this typeof() magic? Can't we settle on a consistent type across arches, or have a typedef in a

Re: [PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-30 Thread Mark Salyzyn
Thanks for the review, am taking all the points into consideration. On 10/30/2017 07:15 AM, Mark Rutland wrote: + + typeof(((struct vdso_data *)vd)->xtime_clock_sec) sec; Why do we need to do this typeof() magic? Can't we settle on a consistent type across arches, or have a typedef in a

Re: [PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-30 Thread Mark Rutland
On Fri, Oct 27, 2017 at 03:25:40PM -0700, Mark Salyzyn wrote: > In variable timer reading loops, pick up just the values until all > are synchronized, then outside of loop pick up cntvct and perform > calculations to determine final offset, shifted and multiplied > output value. So this is all

Re: [PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-30 Thread Mark Rutland
On Fri, Oct 27, 2017 at 03:25:40PM -0700, Mark Salyzyn wrote: > In variable timer reading loops, pick up just the values until all > are synchronized, then outside of loop pick up cntvct and perform > calculations to determine final offset, shifted and multiplied > output value. So this is all

[PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-27 Thread Mark Salyzyn
In variable timer reading loops, pick up just the values until all are synchronized, then outside of loop pick up cntvct and perform calculations to determine final offset, shifted and multiplied output value. This replaces get_ns with get_clock_shifted_nsec as cntvct reader. Signed-off-by: Mark

[PATCH v3 05/12] arm: vdso: do calculations outside reader loops

2017-10-27 Thread Mark Salyzyn
In variable timer reading loops, pick up just the values until all are synchronized, then outside of loop pick up cntvct and perform calculations to determine final offset, shifted and multiplied output value. This replaces get_ns with get_clock_shifted_nsec as cntvct reader. Signed-off-by: Mark