Re: [PATCH v3 05/15] smack: Refactor to remove bprm_secureexec hook

2017-07-26 Thread Casey Schaufler
On 7/25/2017 8:58 PM, Kees Cook wrote: > On Tue, Jul 18, 2017 at 3:25 PM, Kees Cook wrote: >> The Smack bprm_secureexec hook can be merged with the bprm_set_creds >> hook since it's dealing with the same information, and all of the details >> are finalized during the first call to the bprm_set_cre

Re: [PATCH v3 05/15] smack: Refactor to remove bprm_secureexec hook

2017-07-25 Thread Kees Cook
On Tue, Jul 18, 2017 at 3:25 PM, Kees Cook wrote: > The Smack bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent c

[PATCH v3 05/15] smack: Refactor to remove bprm_secureexec hook

2017-07-18 Thread Kees Cook
The Smack bprm_secureexec hook can be merged with the bprm_set_creds hook since it's dealing with the same information, and all of the details are finalized during the first call to the bprm_set_creds hook via prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored via bprm->calle