Re: [PATCH v3 05/20] tpm: factor out tpm_get_timeouts

2018-09-19 Thread Jarkko Sakkinen
On Tue, Sep 18, 2018 at 12:34:44PM +0300, Tomas Winkler wrote: > Factor out tpm_get_timeouts into tpm2_get_timeouts > and tpm1_get_timeouts. Function names missing parentheses. Should be there for clarity when used in a sentence. Otherwise, the commit looks fine. Tested-by: Jarkko Sakkinen

Re: [PATCH v3 05/20] tpm: factor out tpm_get_timeouts

2018-09-19 Thread Jarkko Sakkinen
On Tue, Sep 18, 2018 at 12:34:44PM +0300, Tomas Winkler wrote: > Factor out tpm_get_timeouts into tpm2_get_timeouts > and tpm1_get_timeouts. Function names missing parentheses. Should be there for clarity when used in a sentence. Otherwise, the commit looks fine. Tested-by: Jarkko Sakkinen

[PATCH v3 05/20] tpm: factor out tpm_get_timeouts

2018-09-18 Thread Tomas Winkler
Factor out tpm_get_timeouts into tpm2_get_timeouts and tpm1_get_timeouts. Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers/char/tpm/tpm-interface.c | 127 ++- drivers/char/tpm/tpm.h | 5 +- drivers/char/tpm/tpm1-cmd.c | 106

[PATCH v3 05/20] tpm: factor out tpm_get_timeouts

2018-09-18 Thread Tomas Winkler
Factor out tpm_get_timeouts into tpm2_get_timeouts and tpm1_get_timeouts. Signed-off-by: Tomas Winkler --- V2-V3: Rebase drivers/char/tpm/tpm-interface.c | 127 ++- drivers/char/tpm/tpm.h | 5 +- drivers/char/tpm/tpm1-cmd.c | 106