Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Jeffrey Hugo
On 2/8/2017 10:03 AM, Mark Rutland wrote: On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: + status = handle_cmdline_files(sys_table, image, cmdline_ptr, + "initrd=", dram_base + SZ_512M, +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Jeffrey Hugo
On 2/8/2017 10:03 AM, Mark Rutland wrote: On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: + status = handle_cmdline_files(sys_table, image, cmdline_ptr, + "initrd=", dram_base + SZ_512M, +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Ard Biesheuvel
> On 8 Feb 2017, at 17:03, Mark Rutland wrote: > >> On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: >> On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: >>> + status = handle_cmdline_files(sys_table, image, cmdline_ptr, >>> +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Ard Biesheuvel
> On 8 Feb 2017, at 17:03, Mark Rutland wrote: > >> On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: >> On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: >>> + status = handle_cmdline_files(sys_table, image, cmdline_ptr, >>> + "initrd=",

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Mark Rutland
On Wed, Feb 08, 2017 at 10:30:37AM -0700, Jeffrey Hugo wrote: > On 2/8/2017 10:03 AM, Mark Rutland wrote: > >On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: > >>On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: > >>>+ status = handle_cmdline_files(sys_table, image, cmdline_ptr, >

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Mark Rutland
On Wed, Feb 08, 2017 at 10:30:37AM -0700, Jeffrey Hugo wrote: > On 2/8/2017 10:03 AM, Mark Rutland wrote: > >On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: > >>On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: > >>>+ status = handle_cmdline_files(sys_table, image, cmdline_ptr, >

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Jeffrey Hugo
On 2/8/2017 10:03 AM, Mark Rutland wrote: On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: + status = handle_cmdline_files(sys_table, image, cmdline_ptr, + "initrd=", dram_base + SZ_512M, +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Jeffrey Hugo
On 2/8/2017 10:03 AM, Mark Rutland wrote: On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: + status = handle_cmdline_files(sys_table, image, cmdline_ptr, + "initrd=", dram_base + SZ_512M, +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Mark Rutland
On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: > On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: > > + status = handle_cmdline_files(sys_table, image, cmdline_ptr, > > + "initrd=", dram_base + SZ_512M, > > +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Mark Rutland
On Wed, Feb 08, 2017 at 10:35:02AM -0600, Timur Tabi wrote: > On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: > > + status = handle_cmdline_files(sys_table, image, cmdline_ptr, > > + "initrd=", dram_base + SZ_512M, > > +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Timur Tabi
On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: >> + status = handle_cmdline_files(sys_table, image, cmdline_ptr, >> + "initrd=", dram_base + SZ_512M, >> + (unsigned long *)_addr, >> +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Timur Tabi
On 02/08/2017 10:29 AM, Ard Biesheuvel wrote: >> + status = handle_cmdline_files(sys_table, image, cmdline_ptr, >> + "initrd=", dram_base + SZ_512M, >> + (unsigned long *)_addr, >> +

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Ard Biesheuvel
> On 8 Feb 2017, at 16:28, Timur Tabi wrote: > >> On Fri, Apr 4, 2014 at 1:45 PM, Leif Lindholm >> wrote: >> >> +/* >> + * EFI entry point for the arm/arm64 EFI stubs. This is the entrypoint >> + * that is described in the PE/COFF header.

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Ard Biesheuvel
> On 8 Feb 2017, at 16:28, Timur Tabi wrote: > >> On Fri, Apr 4, 2014 at 1:45 PM, Leif Lindholm >> wrote: >> >> +/* >> + * EFI entry point for the arm/arm64 EFI stubs. This is the entrypoint >> + * that is described in the PE/COFF header. Most of the code is the same >> + * for both

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Timur Tabi
On Fri, Apr 4, 2014 at 1:45 PM, Leif Lindholm wrote: > > +/* > + * EFI entry point for the arm/arm64 EFI stubs. This is the entrypoint > + * that is described in the PE/COFF header. Most of the code is the same > + * for both archictectures, with the arch-specific code

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2017-02-08 Thread Timur Tabi
On Fri, Apr 4, 2014 at 1:45 PM, Leif Lindholm wrote: > > +/* > + * EFI entry point for the arm/arm64 EFI stubs. This is the entrypoint > + * that is described in the PE/COFF header. Most of the code is the same > + * for both archictectures, with the arch-specific code provided in the > + *

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2014-04-10 Thread Mark Salter
On Wed, 2014-04-09 at 15:20 +0100, Mark Rutland wrote: > > > > +config EFI > > + bool "UEFI firmware support" > > + depends on OF > > I note we're not depending on !CPU_BIG_ENDIAN here, and it looks like > the implementation is not endian-clean (I've pointed out a few issues > below).

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2014-04-10 Thread Mark Salter
On Wed, 2014-04-09 at 15:20 +0100, Mark Rutland wrote: +config EFI + bool UEFI firmware support + depends on OF I note we're not depending on !CPU_BIG_ENDIAN here, and it looks like the implementation is not endian-clean (I've pointed out a few issues below). We need to

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2014-04-09 Thread Mark Rutland
Hi Leif, On Fri, Apr 04, 2014 at 07:45:09PM +0100, Leif Lindholm wrote: > From: Mark Salter > > This patch adds PE/COFF header fields to the start of the Image > so that it appears as an EFI application to EFI firmware. An EFI > stub is included to allow direct booting of the kernel Image. >

Re: [PATCH v3 06/10] arm64: efi: add EFI stub

2014-04-09 Thread Mark Rutland
Hi Leif, On Fri, Apr 04, 2014 at 07:45:09PM +0100, Leif Lindholm wrote: From: Mark Salter msal...@redhat.com This patch adds PE/COFF header fields to the start of the Image so that it appears as an EFI application to EFI firmware. An EFI stub is included to allow direct booting of the kernel

[PATCH v3 06/10] arm64: efi: add EFI stub

2014-04-04 Thread Leif Lindholm
From: Mark Salter This patch adds PE/COFF header fields to the start of the Image so that it appears as an EFI application to EFI firmware. An EFI stub is included to allow direct booting of the kernel Image. Support in the COFF header for signed images was provided by Ard Biesheuvel.

[PATCH v3 06/10] arm64: efi: add EFI stub

2014-04-04 Thread Leif Lindholm
From: Mark Salter msal...@redhat.com This patch adds PE/COFF header fields to the start of the Image so that it appears as an EFI application to EFI firmware. An EFI stub is included to allow direct booting of the kernel Image. Support in the COFF header for signed images was provided by Ard