Re: [PATCH v3 07/16] tpm: access command header through struct in tpm_try_transmit()

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 05:26:30PM -0500, Stefan Berger wrote: > On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: > > Instead of accessing fields of the command header through offsets to > > the raw buffer, it is a better idea to use the header struct pointer > > that is already used elsewhere in the

Re: [PATCH v3 07/16] tpm: access command header through struct in tpm_try_transmit()

2018-11-05 Thread Jarkko Sakkinen
On Mon, Nov 05, 2018 at 05:26:30PM -0500, Stefan Berger wrote: > On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: > > Instead of accessing fields of the command header through offsets to > > the raw buffer, it is a better idea to use the header struct pointer > > that is already used elsewhere in the

Re: [PATCH v3 07/16] tpm: access command header through struct in tpm_try_transmit()

2018-11-05 Thread Stefan Berger
On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: Instead of accessing fields of the command header through offsets to the raw buffer, it is a better idea to use the header struct pointer that is already used elsewhere in the function. Signed-off-by: Jarkko Sakkinen ---

Re: [PATCH v3 07/16] tpm: access command header through struct in tpm_try_transmit()

2018-11-05 Thread Stefan Berger
On 11/4/18 8:45 PM, Jarkko Sakkinen wrote: Instead of accessing fields of the command header through offsets to the raw buffer, it is a better idea to use the header struct pointer that is already used elsewhere in the function. Signed-off-by: Jarkko Sakkinen ---

[PATCH v3 07/16] tpm: access command header through struct in tpm_try_transmit()

2018-11-04 Thread Jarkko Sakkinen
Instead of accessing fields of the command header through offsets to the raw buffer, it is a better idea to use the header struct pointer that is already used elsewhere in the function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 4 ++-- 1 file changed, 2

[PATCH v3 07/16] tpm: access command header through struct in tpm_try_transmit()

2018-11-04 Thread Jarkko Sakkinen
Instead of accessing fields of the command header through offsets to the raw buffer, it is a better idea to use the header struct pointer that is already used elsewhere in the function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 4 ++-- 1 file changed, 2