Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-09 Thread Pavel Machek
Hi! > >> Yes, please. We have common interface for LED drivers; this needs to > >> use it. > > > > That is indeed a better option and I did in fact considered this first and > > even did a test implementation. The discoveries were: > > 1. The WMI methods are write-only and only written all at

Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-09 Thread Pavel Machek
On Fri 2019-05-10 00:06:11, Andy Shevchenko wrote: > On Thu, May 9, 2019 at 11:45 PM Dan Murphy wrote: > > On 5/9/19 2:04 PM, Yurii Pavlovskyi wrote: > > We are working on a framework for this. > > > > Please see this series > > https://lore.kernel.org/patchwork/project/lkml/list/?series=390141 >

Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-09 Thread Dan Murphy
Andy On 5/9/19 4:06 PM, Andy Shevchenko wrote: > On Thu, May 9, 2019 at 11:45 PM Dan Murphy wrote: >> On 5/9/19 2:04 PM, Yurii Pavlovskyi wrote: >> We are working on a framework for this. >> >> Please see this series >> https://lore.kernel.org/patchwork/project/lkml/list/?series=390141 >> >> It

Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-09 Thread Andy Shevchenko
On Thu, May 9, 2019 at 11:45 PM Dan Murphy wrote: > On 5/9/19 2:04 PM, Yurii Pavlovskyi wrote: > We are working on a framework for this. > > Please see this series > https://lore.kernel.org/patchwork/project/lkml/list/?series=390141 > > It is still a work in progress Side question: Have you

Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-09 Thread Dan Murphy
Yurii On 5/9/19 2:04 PM, Yurii Pavlovskyi wrote: > First of all, thanks to Andy for all the review comments! > > I will implement all the ones that I didn't directly answer on as well and > update this series shortly. > > Regarding this patch, > > On 08.05.19 19:12, Pavel Machek wrote: >>>

Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-09 Thread Yurii Pavlovskyi
First of all, thanks to Andy for all the review comments! I will implement all the ones that I didn't directly answer on as well and update this series shortly. Regarding this patch, On 08.05.19 19:12, Pavel Machek wrote: >> Shouldn't be the LED subsystem driver for this? > > Yes, please. We

Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-08 Thread Pavel Machek
Hi! > > The WMI exposes two methods for controlling RGB keyboard backlight, which > > allows controlling: > > * RGB components in range 00 - ff, > > * Switch between 4 effects, > > * Switch between 3 effect speed modes, > > * Separately enable the backlight on boot, in the awake state (after

Re: [PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-05-08 Thread Andy Shevchenko
On Fri, Apr 19, 2019 at 1:14 PM Yurii Pavlovskyi wrote: > > The WMI exposes two methods for controlling RGB keyboard backlight, which > allows controlling: > * RGB components in range 00 - ff, > * Switch between 4 effects, > * Switch between 3 effect speed modes, > * Separately enable the

[PATCH v3 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-04-19 Thread Yurii Pavlovskyi
The WMI exposes two methods for controlling RGB keyboard backlight, which allows controlling: * RGB components in range 00 - ff, * Switch between 4 effects, * Switch between 3 effect speed modes, * Separately enable the backlight on boot, in the awake state (after driver load), in sleep mode,