Re: [PATCH v3 1/1] Input: atmel_mxt_ts - implement I2C retries

2020-09-14 Thread Andy Shevchenko
On Tue, Sep 8, 2020 at 11:11 PM Jiada Wang wrote: > > From: Nick Dyer > > Some maXTouch chips (eg mXT1386) will not respond on the first I2C request > when they are in a sleep state. It must be retried after a delay for the > chip to wake up. > Same comments as per v2. -- With Best Regards,

Re: [PATCH v3 1/1] Input: atmel_mxt_ts - implement I2C retries

2020-09-11 Thread Dmitry Osipenko
11.09.2020 17:50, Dmitry Osipenko пишет: ... >> @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client, >> struct i2c_msg xfer[2]; >> u8 buf[2]; >> int ret; >> +bool retry = false; Andy suggested to write this hunk like this: struct i2c_msg xfer[2];

Re: [PATCH v3 1/1] Input: atmel_mxt_ts - implement I2C retries

2020-09-11 Thread Dmitry Osipenko
08.09.2020 18:16, Jiada Wang пишет: > From: Nick Dyer > > Some maXTouch chips (eg mXT1386) will not respond on the first I2C request > when they are in a sleep state. It must be retried after a delay for the > chip to wake up. > > Signed-off-by: Nick Dyer > Acked-by: Yufeng Shen > (cherry

Re: [PATCH v3 1/1] Input: atmel_mxt_ts - implement I2C retries

2020-09-11 Thread Dmitry Osipenko
11.09.2020 18:05, Dmitry Osipenko пишет: > 11.09.2020 17:50, Dmitry Osipenko пишет: > ... >>> @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client, >>> struct i2c_msg xfer[2]; >>> u8 buf[2]; >>> int ret; >>> + bool retry = false; > > Andy suggested to write this

[PATCH v3 1/1] Input: atmel_mxt_ts - implement I2C retries

2020-09-08 Thread Jiada Wang
From: Nick Dyer Some maXTouch chips (eg mXT1386) will not respond on the first I2C request when they are in a sleep state. It must be retried after a delay for the chip to wake up. Signed-off-by: Nick Dyer Acked-by: Yufeng Shen (cherry picked from ndyer/linux/for-upstream commit