Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
On Fri, 2017-05-26 at 20:20 -0700, Richard Narron wrote: > Under the /block/partitions directory the c programs have about 13 uses > of memcmp() and 6 uses of strcmp(). Nearly all of the memcmp uses with strings kernel wide use the equivalent of memcmp(foo, "bar", strlen("bar"));

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
On Fri, 2017-05-26 at 20:20 -0700, Richard Narron wrote: > Under the /block/partitions directory the c programs have about 13 uses > of memcmp() and 6 uses of strcmp(). Nearly all of the memcmp uses with strings kernel wide use the equivalent of memcmp(foo, "bar", strlen("bar"));

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Richard Narron
On Fri, 26 May 2017, Joe Perches wrote: (please keep replies on the list) On Fri, 2017-05-26 at 18:33 -0700, Richard Narron wrote: On Fri, 26 May 2017, Joe Perches wrote: On Fri, 2017-05-26 at 16:30 -0700, Richard Narron wrote: On Fri, 26 May 2017, Joe Perches wrote: On Fri, 2017-05-26 at

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Richard Narron
On Fri, 26 May 2017, Joe Perches wrote: (please keep replies on the list) On Fri, 2017-05-26 at 18:33 -0700, Richard Narron wrote: On Fri, 26 May 2017, Joe Perches wrote: On Fri, 2017-05-26 at 16:30 -0700, Richard Narron wrote: On Fri, 26 May 2017, Joe Perches wrote: On Fri, 2017-05-26 at

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
(please keep replies on the list) On Fri, 2017-05-26 at 18:33 -0700, Richard Narron wrote: > On Fri, 26 May 2017, Joe Perches wrote: > > On Fri, 2017-05-26 at 16:30 -0700, Richard Narron wrote: > > > On Fri, 26 May 2017, Joe Perches wrote: > > > > On Fri, 2017-05-26 at 03:48 -0700, Richard Narron

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
(please keep replies on the list) On Fri, 2017-05-26 at 18:33 -0700, Richard Narron wrote: > On Fri, 26 May 2017, Joe Perches wrote: > > On Fri, 2017-05-26 at 16:30 -0700, Richard Narron wrote: > > > On Fri, 26 May 2017, Joe Perches wrote: > > > > On Fri, 2017-05-26 at 03:48 -0700, Richard Narron

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Richard Narron
On Fri, 26 May 2017, Joe Perches wrote: On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote: The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD and NetBSD partitions and does a reasonable job picking out OpenBSD and NetBSD UFS subpartitions. But for FreeBSD the subpartitions

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Richard Narron
On Fri, 26 May 2017, Joe Perches wrote: On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote: The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD and NetBSD partitions and does a reasonable job picking out OpenBSD and NetBSD UFS subpartitions. But for FreeBSD the subpartitions

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
On Fri, 2017-05-26 at 16:30 -0700, Richard Narron wrote: > On Fri, 26 May 2017, Joe Perches wrote: > > > On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote: > > > The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD > > > and NetBSD partitions and does a reasonable job picking

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
On Fri, 2017-05-26 at 16:30 -0700, Richard Narron wrote: > On Fri, 26 May 2017, Joe Perches wrote: > > > On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote: > > > The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD > > > and NetBSD partitions and does a reasonable job picking

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote: > The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD > and NetBSD partitions and does a reasonable job picking out OpenBSD > and NetBSD UFS subpartitions. > > But for FreeBSD the subpartitions are always "bad". > >

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Joe Perches
On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote: > The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD > and NetBSD partitions and does a reasonable job picking out OpenBSD > and NetBSD UFS subpartitions. > > But for FreeBSD the subpartitions are always "bad". > >

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Jens Axboe
On 05/26/2017 04:48 AM, Richard Narron wrote: > The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD > and NetBSD partitions and does a reasonable job picking out OpenBSD > and NetBSD UFS subpartitions. > > But for FreeBSD the subpartitions are always "bad". > > Kernel: >

Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Jens Axboe
On 05/26/2017 04:48 AM, Richard Narron wrote: > The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD > and NetBSD partitions and does a reasonable job picking out OpenBSD > and NetBSD UFS subpartitions. > > But for FreeBSD the subpartitions are always "bad". > > Kernel: >

[PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Richard Narron
The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD and NetBSD partitions and does a reasonable job picking out OpenBSD and NetBSD UFS subpartitions. But for FreeBSD the subpartitions are always "bad". Kernel: Cc: Andries Brouwer Cc: linux-bl...@vger.kernel.org

[PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are not recognized

2017-05-26 Thread Richard Narron
The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD and NetBSD partitions and does a reasonable job picking out OpenBSD and NetBSD UFS subpartitions. But for FreeBSD the subpartitions are always "bad". Kernel: Cc: Andries Brouwer Cc: linux-bl...@vger.kernel.org Reviewed-by: