RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-23 Thread Gabriele Paoloni
> Linuxarm; linux-...@vger.kernel.org; lu...@wunner.de; linux- > ker...@vger.kernel.org; mika.westerb...@linux.intel.com; liudongdong > (C) > Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > On Sun, May 21, 2017 at 0

RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-23 Thread Gabriele Paoloni
> Linuxarm; linux-...@vger.kernel.org; lu...@wunner.de; linux- > ker...@vger.kernel.org; mika.westerb...@linux.intel.com; liudongdong > (C) > Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > On Sun, May 21, 2017 at 0

Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-22 Thread Christoph Hellwig
On Sun, May 21, 2017 at 03:00:46PM +, Gabriele Paoloni wrote: > > I thought that in your previous review you meant to say that we should > avoid 2 instances of the same comment (in this patchset I only have this > instance as I have removed the same comment from patch 2/2...) No, there is

Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-22 Thread Christoph Hellwig
On Sun, May 21, 2017 at 03:00:46PM +, Gabriele Paoloni wrote: > > I thought that in your previous review you meant to say that we should > avoid 2 instances of the same comment (in this patchset I only have this > instance as I have removed the same comment from patch 2/2...) No, there is

RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-21 Thread Gabriele Paoloni
.@vger.kernel.org; lu...@wunner.de; linux-kernel@vger.kernel.org; > mika.westerb...@linux.intel.com; h...@infradead.org; liudongdong (C) > Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > > +* > >

RE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-21 Thread Gabriele Paoloni
.@vger.kernel.org; lu...@wunner.de; linux-kernel@vger.kernel.org; > mika.westerb...@linux.intel.com; h...@infradead.org; liudongdong (C) > Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > > +* > >

Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-21 Thread Christoph Hellwig
> + * > + * pci_irq_vector() below is able to handle entry differently > + * depending on MSI vs MSI-x case > + * >*/ One more instance of this comment left :) > pcie_capability_read_word(dev, PCI_EXP_FLAGS, ); >

Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-21 Thread Christoph Hellwig
> + * > + * pci_irq_vector() below is able to handle entry differently > + * depending on MSI vs MSI-x case > + * >*/ One more instance of this comment left :) > pcie_capability_read_word(dev, PCI_EXP_FLAGS, ); >

[PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-18 Thread Gabriele Paoloni
Currently PCIe port services are assigned with different interrutps only if MSI-x are supported by calling pcie_port_enable_msix(). If a root port supports MSI instead of MSI-x currently we fall back to use a single shared interrupt for all the services. This patch renames and extends

[PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services

2017-05-18 Thread Gabriele Paoloni
Currently PCIe port services are assigned with different interrutps only if MSI-x are supported by calling pcie_port_enable_msix(). If a root port supports MSI instead of MSI-x currently we fall back to use a single shared interrupt for all the services. This patch renames and extends