Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs

2019-09-11 Thread Felipe Balbi
Hi, Richard Cochran writes: > On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote: > >> case PTP_PEROUT_REQUEST: >> +case PTP_PEROUT_REQUEST2: > > ... > >> +if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) || >> +req.perout.rsv[0] ||

Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs

2019-09-10 Thread Richard Cochran
On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote: > case PTP_PEROUT_REQUEST: > + case PTP_PEROUT_REQUEST2: ... > + if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) || > + req.perout.rsv[0] || req.perout.rsv[1] || > +

[PATCH v3 1/2] PTP: introduce new versions of IOCTLs

2019-09-09 Thread Felipe Balbi
The current version of the IOCTL have a small problem which prevents us from extending the API by making use of reserved fields. In these new IOCTLs, we are now making sure that flags and rsv fields are zero which will allow us to extend the API in the future. Reviewed-by: Richard Cochran