Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Pavel On 11/17/2017 05:58 PM, Pavel Machek wrote: > Hi! > Well.. if it can control other LEDs than just backlight, I believe it can stay in the LED subsystem. >>> >>> I also agree with your opinion. >> >> I will make the necessary changes for v4. > > I'm not sure if you need to make

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Pavel On 11/17/2017 05:58 PM, Pavel Machek wrote: > Hi! > Well.. if it can control other LEDs than just backlight, I believe it can stay in the LED subsystem. >>> >>> I also agree with your opinion. >> >> I will make the necessary changes for v4. > > I'm not sure if you need to make

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi Dan, On 11/15/2017 08:42 PM, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes -

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi Dan, On 11/15/2017 08:42 PM, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes - https://patchwork.kernel.org/patch/10056677/ > >

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > >> Well.. if it can control other LEDs than just backlight, I believe it > >> can stay in the LED subsystem. > > > > I also agree with your opinion. > > I will make the necessary changes for v4. I'm not sure if you need to make any changes. Just add default trigger to the dts and you

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > >> Well.. if it can control other LEDs than just backlight, I believe it > >> can stay in the LED subsystem. > > > > I also agree with your opinion. > > I will make the necessary changes for v4. I'm not sure if you need to make any changes. Just add default trigger to the dts and you

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Pavel and Jacek On 11/17/2017 10:30 AM, Jingoo Han wrote: > On Friday, November 17, 2017 6:21 AM, Pavel Machek wrote: >> >> Hi! >> > If that does not yet exist... you want to create glue layer to be >> able > to use LED as a display backlight. (It may already exist, no idea). > >

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Pavel and Jacek On 11/17/2017 10:30 AM, Jingoo Han wrote: > On Friday, November 17, 2017 6:21 AM, Pavel Machek wrote: >> >> Hi! >> > If that does not yet exist... you want to create glue layer to be >> able > to use LED as a display backlight. (It may already exist, no idea). > >

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Friday, November 17, 2017 6:21 AM, Pavel Machek wrote: > > Hi! > > > >> If that does not yet exist... you want to create glue layer to be > able > > >> to use LED as a display backlight. (It may already exist, no idea). > > >> > > >> ... > > >> > > >> Actually or maybe a LED trigger. Just set

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Friday, November 17, 2017 6:21 AM, Pavel Machek wrote: > > Hi! > > > >> If that does not yet exist... you want to create glue layer to be > able > > >> to use LED as a display backlight. (It may already exist, no idea). > > >> > > >> ... > > >> > > >> Actually or maybe a LED trigger. Just set

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > >> If that does not yet exist... you want to create glue layer to be able > >> to use LED as a display backlight. (It may already exist, no idea). > >> > >> ... > >> > >> Actually or maybe a LED trigger. Just set LED's trigger to "this is > >> display backlight". > > > > There is one

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > >> If that does not yet exist... you want to create glue layer to be able > >> to use LED as a display backlight. (It may already exist, no idea). > >> > >> ... > >> > >> Actually or maybe a LED trigger. Just set LED's trigger to "this is > >> display backlight". > > > > There is one

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Thursday, November 16, 2017 4:42 PM, Dan Murphy wrote: > > Jacek > > On 11/16/2017 02:14 PM, Jacek Anaszewski wrote: > > Hi Dan and Pavel, > > > > On 11/15/2017 11:23 PM, Pavel Machek wrote: > >> Hi! > >> > Shouldn't the driver be targeted for backlight subsystem then? > >

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Thursday, November 16, 2017 4:42 PM, Dan Murphy wrote: > > Jacek > > On 11/16/2017 02:14 PM, Jacek Anaszewski wrote: > > Hi Dan and Pavel, > > > > On 11/15/2017 11:23 PM, Pavel Machek wrote: > >> Hi! > >> > Shouldn't the driver be targeted for backlight subsystem then? > >

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Jacek On 11/16/2017 02:14 PM, Jacek Anaszewski wrote: > Hi Dan and Pavel, > > On 11/15/2017 11:23 PM, Pavel Machek wrote: >> Hi! >> Shouldn't the driver be targeted for backlight subsystem then? Adding backlight maintainers. >>> >>> Great point! I was not aware of the

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Jacek On 11/16/2017 02:14 PM, Jacek Anaszewski wrote: > Hi Dan and Pavel, > > On 11/15/2017 11:23 PM, Pavel Machek wrote: >> Hi! >> Shouldn't the driver be targeted for backlight subsystem then? Adding backlight maintainers. >>> >>> Great point! I was not aware of the

Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On 11/16/2017 02:36 PM, Rob Herring wrote: > On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek wrote: >> Hi! >> > +Required properties: > + - compatible: > + "ti,lm3692x" Don't use wildcards in compatible strings. >>> >>> Do you mean to remove the x? How

Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On 11/16/2017 02:36 PM, Rob Herring wrote: > On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek wrote: >> Hi! >> > +Required properties: > + - compatible: > + "ti,lm3692x" Don't use wildcards in compatible strings. >>> >>> Do you mean to remove the x? How do we denote

Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek wrote: > Hi! > >> >> +Required properties: >> >> + - compatible: >> >> + "ti,lm3692x" >> > >> > Don't use wildcards in compatible strings. >> >> Do you mean to remove the x? How do we denote a family of parts >> then? > > I

Re: dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Thu, Nov 16, 2017 at 2:11 PM, Pavel Machek wrote: > Hi! > >> >> +Required properties: >> >> + - compatible: >> >> + "ti,lm3692x" >> > >> > Don't use wildcards in compatible strings. >> >> Do you mean to remove the x? How do we denote a family of parts >> then? > > I guess you should

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi Dan and Pavel, On 11/15/2017 11:23 PM, Pavel Machek wrote: > Hi! > >>> Shouldn't the driver be targeted for backlight subsystem then? >>> >>> Adding backlight maintainers. >>> >> >> Great point! I was not aware of the backlight subsystem. >> >> Looks like I need to create a back light

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi Dan and Pavel, On 11/15/2017 11:23 PM, Pavel Machek wrote: > Hi! > >>> Shouldn't the driver be targeted for backlight subsystem then? >>> >>> Adding backlight maintainers. >>> >> >> Great point! I was not aware of the backlight subsystem. >> >> Looks like I need to create a back light

dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > >> +Required properties: > >> + - compatible: > >> + "ti,lm3692x" > > > > Don't use wildcards in compatible strings. > > Do you mean to remove the x? How do we denote a family of parts > then? I guess you should specify the exact chip. Which will present interesting problem

dts: fun with chip names Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > >> +Required properties: > >> + - compatible: > >> + "ti,lm3692x" > > > > Don't use wildcards in compatible strings. > > Do you mean to remove the x? How do we denote a family of parts > then? I guess you should specify the exact chip. Which will present interesting problem

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Thu, Nov 16, 2017 at 9:45 AM, Dan Murphy wrote: > Rob > > Thanks for the review > > On 11/16/2017 09:41 AM, Rob Herring wrote: >> On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >>> This adds the devicetree bindings for the LM3692x >>> I2C LED string driver. >>> >>>

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Thu, Nov 16, 2017 at 9:45 AM, Dan Murphy wrote: > Rob > > Thanks for the review > > On 11/16/2017 09:41 AM, Rob Herring wrote: >> On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >>> This adds the devicetree bindings for the LM3692x >>> I2C LED string driver. >>> >>> Acked-by: Pavel

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Rob Thanks for the review On 11/16/2017 09:41 AM, Rob Herring wrote: > On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >> This adds the devicetree bindings for the LM3692x >> I2C LED string driver. >> >> Acked-by: Pavel Machek >> Signed-off-by: Dan Murphy

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Rob Thanks for the review On 11/16/2017 09:41 AM, Rob Herring wrote: > On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: >> This adds the devicetree bindings for the LM3692x >> I2C LED string driver. >> >> Acked-by: Pavel Machek >> Signed-off-by: Dan Murphy >> --- >> >> v3 - No

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes -

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

On Wed, Nov 15, 2017 at 01:42:02PM -0600, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes - https://patchwork.kernel.org/patch/10056677/ > >

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > > Shouldn't the driver be targeted for backlight subsystem then? > > > > Adding backlight maintainers. > > > > Great point! I was not aware of the backlight subsystem. > > Looks like I need to create a back light version as well. > > Like the lp8788 did since this can be used as a LED

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi! > > Shouldn't the driver be targeted for backlight subsystem then? > > > > Adding backlight maintainers. > > > > Great point! I was not aware of the backlight subsystem. > > Looks like I need to create a back light version as well. > > Like the lp8788 did since this can be used as a LED

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Jacek On 11/15/2017 02:15 PM, Jacek Anaszewski wrote: > Hi Dan, > > Thanks for the patch. > > On 11/15/2017 08:42 PM, Dan Murphy wrote: >> This adds the devicetree bindings for the LM3692x >> I2C LED string driver. >> >> Acked-by: Pavel Machek >> Signed-off-by: Dan Murphy

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Jacek On 11/15/2017 02:15 PM, Jacek Anaszewski wrote: > Hi Dan, > > Thanks for the patch. > > On 11/15/2017 08:42 PM, Dan Murphy wrote: >> This adds the devicetree bindings for the LM3692x >> I2C LED string driver. >> >> Acked-by: Pavel Machek >> Signed-off-by: Dan Murphy >> --- >> >> v3 - No

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi Dan, Thanks for the patch. On 11/15/2017 08:42 PM, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes -

Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

Hi Dan, Thanks for the patch. On 11/15/2017 08:42 PM, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes -

[PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

This adds the devicetree bindings for the LM3692x I2C LED string driver. Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- v3 - No changes v2 - No changes - https://patchwork.kernel.org/patch/10056677/ .../devicetree/bindings/leds/leds-lm3692x.txt | 28

[PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

This adds the devicetree bindings for the LM3692x I2C LED string driver. Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- v3 - No changes v2 - No changes - https://patchwork.kernel.org/patch/10056677/ .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++ 1 file