Re: [PATCH v3 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-09-06 Thread Masahiro Yamada
On Sun, Sep 1, 2019 at 1:26 AM Masahiro Yamada wrote: > > Instead of the warning-[123] magic, let's accumulate compiler options > to KBUILD_CFLAGS directly as the top Makefile does. I think this makes > easier to understand what is going on in this file. > > This commit slightly changes the behavi

Re: [PATCH v3 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-09-05 Thread Arnd Bergmann
On Thu, Sep 5, 2019 at 12:40 AM Nathan Chancellor wrote: > On Wed, Sep 04, 2019 at 11:46:45PM +0200, Arnd Bergmann wrote: > > On Sat, Aug 31, 2019 at 6:26 PM Masahiro Yamada > > wrote: > > > > FWIW, I just found out I missed a bug that clang failed to warn about > > because of the -Wno-format. A

Re: [PATCH v3 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-09-04 Thread Nathan Chancellor
On Wed, Sep 04, 2019 at 11:46:45PM +0200, Arnd Bergmann wrote: > On Sat, Aug 31, 2019 at 6:26 PM Masahiro Yamada > wrote: > > > +# Some diagnostics enabled by default are noisy. > > +# Suppress them by using -Wno... except for W=1. > > + > > ifdef CONFIG_CC_IS_CLANG > > KBUILD_CFLAGS += -Wno-in

Re: [PATCH v3 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-09-04 Thread Arnd Bergmann
On Sat, Aug 31, 2019 at 6:26 PM Masahiro Yamada wrote: > +# Some diagnostics enabled by default are noisy. > +# Suppress them by using -Wno... except for W=1. > + > ifdef CONFIG_CC_IS_CLANG > KBUILD_CFLAGS += -Wno-initializer-overrides > KBUILD_CFLAGS += -Wno-format > KBUILD_CFLAGS += -Wno-si

[PATCH v3 1/2] kbuild: refactor scripts/Makefile.extrawarn

2019-08-31 Thread Masahiro Yamada
Instead of the warning-[123] magic, let's accumulate compiler options to KBUILD_CFLAGS directly as the top Makefile does. I think this makes easier to understand what is going on in this file. This commit slightly changes the behavior, I think all of which are OK. [1] Currently, cc-option calls a