Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-09-03 Thread Shuah Khan
On 9/3/19 6:50 AM, Dafna Hirschfeld wrote: Hi, Thank you for working on the patchset. Since there is only one module now, the section in the vimc Documentation regarding module params should be changed: In the file Documentation/media/v4l-drivers/vimc.rst The following text should be removed:

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-09-03 Thread Dafna Hirschfeld
Hi, Thank you for working on the patchset. Since there is only one module now, the section in the vimc Documentation regarding module params should be changed: In the file Documentation/media/v4l-drivers/vimc.rst The following text should be removed: ``` You should pass those arguments to each

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-08-27 Thread Shuah Khan
On 8/27/19 10:55 AM, Laurent Pinchart wrote: Hi Shuah, Thank you for the patch. On Tue, Aug 20, 2019 at 03:18:41PM -0600, Shuah Khan wrote: vimc uses Component API to split the driver into functional components. The real hardware resembles a monolith structure than component and component

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-08-27 Thread Shuah Khan
On 8/27/19 10:16 AM, Dafna Hirschfeld wrote: On Tue, 2019-08-20 at 15:18 -0600, Shuah Khan wrote: vimc uses Component API to split the driver into functional components. The real hardware resembles a monolith structure than component and component structure added a level of complexity making it

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-08-27 Thread Laurent Pinchart
Hi Shuah, Thank you for the patch. On Tue, Aug 20, 2019 at 03:18:41PM -0600, Shuah Khan wrote: > vimc uses Component API to split the driver into functional components. > The real hardware resembles a monolith structure than component and > component structure added a level of complexity making

Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-08-27 Thread Dafna Hirschfeld
On Tue, 2019-08-20 at 15:18 -0600, Shuah Khan wrote: > vimc uses Component API to split the driver into functional components. > The real hardware resembles a monolith structure than component and > component structure added a level of complexity making it hard to > maintain without adding any

[PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver

2019-08-20 Thread Shuah Khan
vimc uses Component API to split the driver into functional components. The real hardware resembles a monolith structure than component and component structure added a level of complexity making it hard to maintain without adding any real benefit. The sensor is one vimc component that would makes