Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-11 Thread James Bottomley
On Thu, 2019-10-10 at 00:36 +0300, Jarkko Sakkinen wrote: > On Mon, Oct 07, 2019 at 12:12:08PM -0700, James Bottomley wrote: > > From: James Bottomley > > Subject: [PATCH] tpm: use GFP kernel for tpm_buf allocations > > > > The current code uses GFP_HIGHMEM, which is wrong because > >

Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-09 Thread Jarkko Sakkinen
On Mon, Oct 07, 2019 at 12:12:08PM -0700, James Bottomley wrote: > From: James Bottomley > Subject: [PATCH] tpm: use GFP kernel for tpm_buf allocations > > The current code uses GFP_HIGHMEM, which is wrong because GFP_HIGHMEM > (on 32 bit systems) is memory ordinarily inaccessible to the kernel

Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-08 Thread Jarkko Sakkinen
On Mon, Oct 07, 2019 at 12:12:08PM -0700, James Bottomley wrote: > From: James Bottomley > Subject: [PATCH] tpm: use GFP kernel for tpm_buf allocations > > The current code uses GFP_HIGHMEM, which is wrong because GFP_HIGHMEM > (on 32 bit systems) is memory ordinarily inaccessible to the kernel

Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-07 Thread Jerry Snitselaar
On Mon Oct 07 19, James Bottomley wrote: From: James Bottomley Subject: [PATCH] tpm: use GFP kernel for tpm_buf allocations The current code uses GFP_HIGHMEM, which is wrong because GFP_HIGHMEM (on 32 bit systems) is memory ordinarily inaccessible to the kernel and should only be used for

Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-07 Thread James Bottomley
From: James Bottomley Subject: [PATCH] tpm: use GFP kernel for tpm_buf allocations The current code uses GFP_HIGHMEM, which is wrong because GFP_HIGHMEM (on 32 bit systems) is memory ordinarily inaccessible to the kernel and should only be used for allocations affecting userspace. In order to

Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-06 Thread Jarkko Sakkinen
On Thu, Oct 03, 2019 at 05:25:16PM -0700, James Bottomley wrote: > On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > > Switch from GFP_HIGHUSER to GFP_KERNEL. On 32-bit platforms kmap() > > space > > could be unnecessarily wasted because of using GFP_HIGHUSER by taking > > a > > page of

Re: [PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-03 Thread James Bottomley
On Thu, 2019-10-03 at 21:51 +0300, Jarkko Sakkinen wrote: > Switch from GFP_HIGHUSER to GFP_KERNEL. On 32-bit platforms kmap() > space > could be unnecessarily wasted because of using GFP_HIGHUSER by taking > a > page of from the highmem. > > Suggested-by: James Bottomley > Signed-off-by: Jarkko

[PATCH v3 1/2] tpm: Use GFP_KERNEL for allocating struct tpm_buf

2019-10-03 Thread Jarkko Sakkinen
Switch from GFP_HIGHUSER to GFP_KERNEL. On 32-bit platforms kmap() space could be unnecessarily wasted because of using GFP_HIGHUSER by taking a page of from the highmem. Suggested-by: James Bottomley Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm.h | 2 +- 1 file changed, 1