Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2015-02-23 Thread nitin
Rafael J. Wysocki sisk.pl> writes: > > On Sunday, June 09, 2013 11:14:49 PM Borislav Petkov wrote: > > On Sun, Jun 09, 2013 at 10:58:51PM +0200, Rafael J. Wysocki wrote: > > > Can you possibly prepare a graph showing both the execution time > > > and energy consumption for several different

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2015-02-23 Thread nitin
Rafael J. Wysocki rjw at sisk.pl writes: On Sunday, June 09, 2013 11:14:49 PM Borislav Petkov wrote: On Sun, Jun 09, 2013 at 10:58:51PM +0200, Rafael J. Wysocki wrote: Can you possibly prepare a graph showing both the execution time and energy consumption for several different loop

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Stratos Karafotis
Hi, On 06/14/2013 03:55 PM, Rafael J. Wysocki wrote: > On Friday, June 14, 2013 02:44:01 PM Borislav Petkov wrote: >> On Fri, Jun 14, 2013 at 02:46:38PM +0200, Rafael J. Wysocki wrote: >>> OK, so here's a deal. After 3.10-rc1 goes out, I'll put this into >>> linux-next >> >> Yeah, you mean

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Rafael J. Wysocki
On Friday, June 14, 2013 02:44:01 PM Borislav Petkov wrote: > On Fri, Jun 14, 2013 at 02:46:38PM +0200, Rafael J. Wysocki wrote: > > OK, so here's a deal. After 3.10-rc1 goes out, I'll put this into > > linux-next > > Yeah, you mean 3.11-rc1 here... Sure, sorry for the confusion. > > for 3.12,

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 02:46:38PM +0200, Rafael J. Wysocki wrote: > OK, so here's a deal. After 3.10-rc1 goes out, I'll put this into > linux-next Yeah, you mean 3.11-rc1 here... > for 3.12, so that people have a few more weeks to complain. If they > don't, it'll go into 3.12. but yep, sounds

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Rafael J. Wysocki
On Friday, June 14, 2013 12:37:41 AM Borislav Petkov wrote: > On Fri, Jun 14, 2013 at 12:15:36AM +0200, Rafael J. Wysocki wrote: > > On Thursday, June 13, 2013 11:40:08 PM Borislav Petkov wrote: > > [ … ] > > > > Not bad. However, exec_test and fork_test are kinda unexpected with such > > > a

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Rafael J. Wysocki
On Friday, June 14, 2013 12:37:41 AM Borislav Petkov wrote: On Fri, Jun 14, 2013 at 12:15:36AM +0200, Rafael J. Wysocki wrote: On Thursday, June 13, 2013 11:40:08 PM Borislav Petkov wrote: [ … ] Not bad. However, exec_test and fork_test are kinda unexpected with such a high

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 02:46:38PM +0200, Rafael J. Wysocki wrote: OK, so here's a deal. After 3.10-rc1 goes out, I'll put this into linux-next Yeah, you mean 3.11-rc1 here... for 3.12, so that people have a few more weeks to complain. If they don't, it'll go into 3.12. but yep, sounds like

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Rafael J. Wysocki
On Friday, June 14, 2013 02:44:01 PM Borislav Petkov wrote: On Fri, Jun 14, 2013 at 02:46:38PM +0200, Rafael J. Wysocki wrote: OK, so here's a deal. After 3.10-rc1 goes out, I'll put this into linux-next Yeah, you mean 3.11-rc1 here... Sure, sorry for the confusion. for 3.12, so that

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-14 Thread Stratos Karafotis
Hi, On 06/14/2013 03:55 PM, Rafael J. Wysocki wrote: On Friday, June 14, 2013 02:44:01 PM Borislav Petkov wrote: On Fri, Jun 14, 2013 at 02:46:38PM +0200, Rafael J. Wysocki wrote: OK, so here's a deal. After 3.10-rc1 goes out, I'll put this into linux-next Yeah, you mean 3.11-rc1 here...

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 01:04:25AM +0300, Stratos Karafotis wrote: > I believe that ondemand has better performance with this patch in > medium loads. Maybe these operations produce small to medium loads > (lower than up_threshold) and push the CPU to medium frequencies. > Without the patch CPU

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 12:15:36AM +0200, Rafael J. Wysocki wrote: > On Thursday, June 13, 2013 11:40:08 PM Borislav Petkov wrote: [ … ] > > Not bad. However, exec_test and fork_test are kinda unexpected with such > > a high improvement percentage. Happen to have an explanation? > > > > FWIW,

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Rafael J. Wysocki
On Thursday, June 13, 2013 11:40:08 PM Borislav Petkov wrote: > On Fri, Jun 14, 2013 at 12:22:18AM +0300, Stratos Karafotis wrote: > > Please let me share some more test results using aim9 benchmark suite: > >

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Stratos Karafotis
On 06/14/2013 12:40 AM, Borislav Petkov wrote: > On Fri, Jun 14, 2013 at 12:22:18AM +0300, Stratos Karafotis wrote: >> Please let me share some more test results using aim9 benchmark suite: >> https://docs.google.com/spreadsheet/ccc?key=0AnMfNYUV1k0ddDdGdlJyUHpqT2xGY1lBOEt2UEVnNlE=sharing >> >>

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 12:22:18AM +0300, Stratos Karafotis wrote: > Please let me share some more test results using aim9 benchmark suite: > https://docs.google.com/spreadsheet/ccc?key=0AnMfNYUV1k0ddDdGdlJyUHpqT2xGY1lBOEt2UEVnNlE=sharing > > Each test was running for 10sec. > Total execution

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Stratos Karafotis
Hi Rafael, On 06/11/2013 02:24 AM, Rafael J. Wysocki wrote: > On Tuesday, June 11, 2013 12:57:26 AM Stratos Karafotis wrote: >> On 06/09/2013 11:58 PM, Rafael J. Wysocki wrote: >>> Well, this means that your changes may hurt performance if the load comes >>> and >>> goes in spikes, which is not

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Stratos Karafotis
Hi Rafael, On 06/11/2013 02:24 AM, Rafael J. Wysocki wrote: On Tuesday, June 11, 2013 12:57:26 AM Stratos Karafotis wrote: On 06/09/2013 11:58 PM, Rafael J. Wysocki wrote: Well, this means that your changes may hurt performance if the load comes and goes in spikes, which is not so good.

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 12:22:18AM +0300, Stratos Karafotis wrote: Please let me share some more test results using aim9 benchmark suite: https://docs.google.com/spreadsheet/ccc?key=0AnMfNYUV1k0ddDdGdlJyUHpqT2xGY1lBOEt2UEVnNlEusp=sharing Each test was running for 10sec. Total execution time

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Stratos Karafotis
On 06/14/2013 12:40 AM, Borislav Petkov wrote: On Fri, Jun 14, 2013 at 12:22:18AM +0300, Stratos Karafotis wrote: Please let me share some more test results using aim9 benchmark suite: https://docs.google.com/spreadsheet/ccc?key=0AnMfNYUV1k0ddDdGdlJyUHpqT2xGY1lBOEt2UEVnNlEusp=sharing Each

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Rafael J. Wysocki
On Thursday, June 13, 2013 11:40:08 PM Borislav Petkov wrote: On Fri, Jun 14, 2013 at 12:22:18AM +0300, Stratos Karafotis wrote: Please let me share some more test results using aim9 benchmark suite:

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 12:15:36AM +0200, Rafael J. Wysocki wrote: On Thursday, June 13, 2013 11:40:08 PM Borislav Petkov wrote: [ … ] Not bad. However, exec_test and fork_test are kinda unexpected with such a high improvement percentage. Happen to have an explanation? FWIW, if we

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-13 Thread Borislav Petkov
On Fri, Jun 14, 2013 at 01:04:25AM +0300, Stratos Karafotis wrote: I believe that ondemand has better performance with this patch in medium loads. Maybe these operations produce small to medium loads (lower than up_threshold) and push the CPU to medium frequencies. Without the patch CPU stays

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-10 Thread Rafael J. Wysocki
On Tuesday, June 11, 2013 12:57:26 AM Stratos Karafotis wrote: > On 06/09/2013 11:58 PM, Rafael J. Wysocki wrote: > > Well, this means that your changes may hurt performance if the load comes > > and > > goes in spikes, which is not so good. The fact that they cause less energy > > to > > be

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-10 Thread Stratos Karafotis
On 06/09/2013 11:58 PM, Rafael J. Wysocki wrote: > Well, this means that your changes may hurt performance if the load comes and > goes in spikes, which is not so good. The fact that they cause less energy to > be used at the same time kind of balance that, though. [After all, we're > talking

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-10 Thread Stratos Karafotis
On 06/09/2013 11:58 PM, Rafael J. Wysocki wrote: Well, this means that your changes may hurt performance if the load comes and goes in spikes, which is not so good. The fact that they cause less energy to be used at the same time kind of balance that, though. [After all, we're talking about

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-10 Thread Rafael J. Wysocki
On Tuesday, June 11, 2013 12:57:26 AM Stratos Karafotis wrote: On 06/09/2013 11:58 PM, Rafael J. Wysocki wrote: Well, this means that your changes may hurt performance if the load comes and goes in spikes, which is not so good. The fact that they cause less energy to be used at the

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Rafael J. Wysocki
On Sunday, June 09, 2013 11:14:49 PM Borislav Petkov wrote: > On Sun, Jun 09, 2013 at 10:58:51PM +0200, Rafael J. Wysocki wrote: > > Can you possibly prepare a graph showing both the execution time > > and energy consumption for several different loop durations in your > > program (let's keep the

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Borislav Petkov
On Sun, Jun 09, 2013 at 10:58:51PM +0200, Rafael J. Wysocki wrote: > Can you possibly prepare a graph showing both the execution time > and energy consumption for several different loop durations in your > program (let's keep the 5000 us sleep for now), including multiples of > sampling_rate as

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Rafael J. Wysocki
On Sunday, June 09, 2013 09:08:23 PM Stratos Karafotis wrote: > On 06/09/2013 07:26 PM, Borislav Petkov wrote: > > On Sun, Jun 09, 2013 at 12:18:09AM +0200, Rafael J. Wysocki wrote: > >> The average power drawn by the package is slightly higher with the > >> patchset applied (27.66 W vs 27.25 W),

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Stratos Karafotis
On 06/09/2013 07:26 PM, Borislav Petkov wrote: > On Sun, Jun 09, 2013 at 12:18:09AM +0200, Rafael J. Wysocki wrote: >> The average power drawn by the package is slightly higher with the >> patchset applied (27.66 W vs 27.25 W), but since the time needed to >> complete the workload with the

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Borislav Petkov
On Sun, Jun 09, 2013 at 12:18:09AM +0200, Rafael J. Wysocki wrote: > The average power drawn by the package is slightly higher with the > patchset applied (27.66 W vs 27.25 W), but since the time needed to > complete the workload with the patchset applied was shorter by about > 2.3 sec, the total

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Borislav Petkov
On Sun, Jun 09, 2013 at 12:18:09AM +0200, Rafael J. Wysocki wrote: The average power drawn by the package is slightly higher with the patchset applied (27.66 W vs 27.25 W), but since the time needed to complete the workload with the patchset applied was shorter by about 2.3 sec, the total

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Stratos Karafotis
On 06/09/2013 07:26 PM, Borislav Petkov wrote: On Sun, Jun 09, 2013 at 12:18:09AM +0200, Rafael J. Wysocki wrote: The average power drawn by the package is slightly higher with the patchset applied (27.66 W vs 27.25 W), but since the time needed to complete the workload with the patchset

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Rafael J. Wysocki
On Sunday, June 09, 2013 09:08:23 PM Stratos Karafotis wrote: On 06/09/2013 07:26 PM, Borislav Petkov wrote: On Sun, Jun 09, 2013 at 12:18:09AM +0200, Rafael J. Wysocki wrote: The average power drawn by the package is slightly higher with the patchset applied (27.66 W vs 27.25 W), but since

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Borislav Petkov
On Sun, Jun 09, 2013 at 10:58:51PM +0200, Rafael J. Wysocki wrote: Can you possibly prepare a graph showing both the execution time and energy consumption for several different loop durations in your program (let's keep the 5000 us sleep for now), including multiples of sampling_rate as well

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-09 Thread Rafael J. Wysocki
On Sunday, June 09, 2013 11:14:49 PM Borislav Petkov wrote: On Sun, Jun 09, 2013 at 10:58:51PM +0200, Rafael J. Wysocki wrote: Can you possibly prepare a graph showing both the execution time and energy consumption for several different loop durations in your program (let's keep the 5000 us

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Rafael J. Wysocki
On Saturday, June 08, 2013 11:31:37 PM Stratos Karafotis wrote: > On 06/08/2013 05:05 PM, Rafael J. Wysocki wrote: > > On Saturday, June 08, 2013 03:34:29 PM Stratos Karafotis wrote: > >> I also did the test with the way you mentioned. But I thought to run > >> turbostat for 100 sec as I did with

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Stratos Karafotis
On 06/08/2013 05:05 PM, Rafael J. Wysocki wrote: > On Saturday, June 08, 2013 03:34:29 PM Stratos Karafotis wrote: >> I also did the test with the way you mentioned. But I thought to run >> turbostat for 100 sec as I did with powertop. > > Ah, OK. > >> Actually benchmark lasts about 96 secs. >>

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Rafael J. Wysocki
On Saturday, June 08, 2013 03:34:29 PM Stratos Karafotis wrote: > I also did the test with the way you mentioned. But I thought to run > turbostat for 100 sec as I did with powertop. Ah, OK. > Actually benchmark lasts about 96 secs. > > I think that we use almost the same energy for 100 sec to

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Stratos Karafotis
I also did the test with the way you mentioned. But I thought to run turbostat for 100 sec as I did with powertop. Actually benchmark lasts about 96 secs. I think that we use almost the same energy for 100 sec to run the same load a little bit faster. I think this means also a reduce to power

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Rafael J. Wysocki
On Saturday, June 08, 2013 12:56:00 PM Stratos Karafotis wrote: > On 06/07/2013 11:57 PM, Rafael J. Wysocki wrote: > > On Friday, June 07, 2013 10:14:34 PM Stratos Karafotis wrote: > >> On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: > >>> On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Stratos Karafotis
On 06/07/2013 11:57 PM, Rafael J. Wysocki wrote: > On Friday, June 07, 2013 10:14:34 PM Stratos Karafotis wrote: >> On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: >>> On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: Hi Borislav, On 06/05/2013 07:17 PM, Borislav

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Stratos Karafotis
On 06/07/2013 11:57 PM, Rafael J. Wysocki wrote: On Friday, June 07, 2013 10:14:34 PM Stratos Karafotis wrote: On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote: On

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Rafael J. Wysocki
On Saturday, June 08, 2013 12:56:00 PM Stratos Karafotis wrote: On 06/07/2013 11:57 PM, Rafael J. Wysocki wrote: On Friday, June 07, 2013 10:14:34 PM Stratos Karafotis wrote: On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote:

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Stratos Karafotis
I also did the test with the way you mentioned. But I thought to run turbostat for 100 sec as I did with powertop. Actually benchmark lasts about 96 secs. I think that we use almost the same energy for 100 sec to run the same load a little bit faster. I think this means also a reduce to power

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Rafael J. Wysocki
On Saturday, June 08, 2013 03:34:29 PM Stratos Karafotis wrote: I also did the test with the way you mentioned. But I thought to run turbostat for 100 sec as I did with powertop. Ah, OK. Actually benchmark lasts about 96 secs. I think that we use almost the same energy for 100 sec to run

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Stratos Karafotis
On 06/08/2013 05:05 PM, Rafael J. Wysocki wrote: On Saturday, June 08, 2013 03:34:29 PM Stratos Karafotis wrote: I also did the test with the way you mentioned. But I thought to run turbostat for 100 sec as I did with powertop. Ah, OK. Actually benchmark lasts about 96 secs. I think

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-08 Thread Rafael J. Wysocki
On Saturday, June 08, 2013 11:31:37 PM Stratos Karafotis wrote: On 06/08/2013 05:05 PM, Rafael J. Wysocki wrote: On Saturday, June 08, 2013 03:34:29 PM Stratos Karafotis wrote: I also did the test with the way you mentioned. But I thought to run turbostat for 100 sec as I did with

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-07 Thread Rafael J. Wysocki
On Friday, June 07, 2013 10:14:34 PM Stratos Karafotis wrote: > On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: > > On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: > >> Hi Borislav, > >> > >> On 06/05/2013 07:17 PM, Borislav Petkov wrote: > >>> On Wed, Jun 05, 2013 at 07:01:25PM

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-07 Thread Stratos Karafotis
On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: > On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: >> Hi Borislav, >> >> On 06/05/2013 07:17 PM, Borislav Petkov wrote: >>> On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: Ondemand calculates load in terms of

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-07 Thread Stratos Karafotis
On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote: On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: Ondemand calculates load in terms of frequency and

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-07 Thread Rafael J. Wysocki
On Friday, June 07, 2013 10:14:34 PM Stratos Karafotis wrote: On 06/05/2013 11:35 PM, Rafael J. Wysocki wrote: On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote: On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
On 06/06/2013 08:11 PM, Borislav Petkov wrote: On Thu, Jun 06, 2013 at 07:46:17PM +0300, Stratos Karafotis wrote: Apologies for top-posting. I was able to send email only from my phone. Thanks for you hint about turbostat. As you most probably understood, I'm individual amateur kernel

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
On Thu, Jun 06, 2013 at 07:46:17PM +0300, Stratos Karafotis wrote: > Apologies for top-posting. I was able to send email only from my phone. > > Thanks for you hint about turbostat. > > As you most probably understood, I'm individual amateur kernel developer. > I could provide some numbers from

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
On 06/06/2013 03:10 PM, Borislav Petkov wrote: > On Thu, Jun 06, 2013 at 03:40:13PM +0530, Viresh Kumar wrote: >> his patch will give significant improvement both power & performance wise. > > Yes, and I'd like to see the paperwork on that. Numbers, and on a couple > of platforms/vendors if

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread David C Niemi
On 06/06/13 05:55, Borislav Petkov wrote: > Please do not top-post. > > On Wed, Jun 05, 2013 at 12:58:33PM -0400, David C Niemi wrote: >> When you are doing a locally-originated truly CPU-bound task, "race to >> idle" does make some sense. But I can think of a couple of caveats. >> >> 1) If you

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
Please do not top-post. On Thu, Jun 06, 2013 at 03:54:20PM +0300, Stratos Karafotis wrote: > I will try to provide the requested info (although, I'm not sure how > to measure total energy :) ) tools/power/x86/turbostat looks like a good tool. It can show, a.o., power consumption in Watts on

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
Thanks Viresh. I think I couldn't explain this in better way. Also thanks for acknowledgment! Stratos Viresh Kumar wrote: >On 6 June 2013 15:31, Borislav Petkov wrote: > >> Hold on, you say above "easily saturate minimum frequency and lead the >> CPU to max". I read this as we jump straight

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
Hi Rafael, I will try to provide the requested info (although, I'm not sure how to measure total energy :) ) Thanks, Stratos "Rafael J. Wysocki" wrote: >On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: >> Hi Borislav, >> >> On 06/05/2013 07:17 PM, Borislav Petkov wrote: >> >

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
On Thu, Jun 06, 2013 at 03:40:13PM +0530, Viresh Kumar wrote: > his patch will give significant improvement both power & performance wise. Yes, and I'd like to see the paperwork on that. Numbers, and on a couple of platforms/vendors if possible, please. Thanks. -- Regards/Gruss, Boris.

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Viresh Kumar
On 6 June 2013 15:31, Borislav Petkov wrote: > Hold on, you say above "easily saturate minimum frequency and lead the > CPU to max". I read this as we jump straight to max P-state where we > even boost. Probably he meant: "At lowest levels of frequencies, a small load on system may look like a

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
On Wed, Jun 05, 2013 at 10:35:05PM +0200, Rafael J. Wysocki wrote: > On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: > > Hi Borislav, > > > > On 06/05/2013 07:17 PM, Borislav Petkov wrote: > > > On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: > > >> Ondemand

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Viresh Kumar
On 6 June 2013 15:25, Borislav Petkov wrote: > The correct "fix" for this whole deal is coupling cpufreq with > the scheduler, as it has been said so many times before. You need > "something" which can tell you whether raising the freq. is worth it or > not (i.e. the process is waiting on IO or

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
Please do not top-post. On Wed, Jun 05, 2013 at 12:58:33PM -0400, David C Niemi wrote: > When you are doing a locally-originated truly CPU-bound task, "race to > idle" does make some sense. But I can think of a couple of caveats. > > 1) If you care about power consumption, you want to avoid >

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
Please do not top-post. On Wed, Jun 05, 2013 at 12:58:33PM -0400, David C Niemi wrote: When you are doing a locally-originated truly CPU-bound task, race to idle does make some sense. But I can think of a couple of caveats. 1) If you care about power consumption, you want to avoid

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Viresh Kumar
On 6 June 2013 15:25, Borislav Petkov b...@suse.de wrote: The correct fix for this whole deal is coupling cpufreq with the scheduler, as it has been said so many times before. You need something which can tell you whether raising the freq. is worth it or not (i.e. the process is waiting on IO

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
On Wed, Jun 05, 2013 at 10:35:05PM +0200, Rafael J. Wysocki wrote: On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote: On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: Ondemand calculates load

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Viresh Kumar
On 6 June 2013 15:31, Borislav Petkov b...@suse.de wrote: Hold on, you say above easily saturate minimum frequency and lead the CPU to max. I read this as we jump straight to max P-state where we even boost. Probably he meant: At lowest levels of frequencies, a small load on system may look

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
On Thu, Jun 06, 2013 at 03:40:13PM +0530, Viresh Kumar wrote: his patch will give significant improvement both power performance wise. Yes, and I'd like to see the paperwork on that. Numbers, and on a couple of platforms/vendors if possible, please. Thanks. -- Regards/Gruss, Boris. Sent

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
Hi Rafael, I will try to provide the requested info (although, I'm not sure how to measure total energy :) ) Thanks, Stratos Rafael J. Wysocki r...@sisk.pl wrote: On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote:

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
Thanks Viresh. I think I couldn't explain this in better way. Also thanks for acknowledgment! Stratos Viresh Kumar viresh.ku...@linaro.org wrote: On 6 June 2013 15:31, Borislav Petkov b...@suse.de wrote: Hold on, you say above easily saturate minimum frequency and lead the CPU to max. I read

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
Please do not top-post. On Thu, Jun 06, 2013 at 03:54:20PM +0300, Stratos Karafotis wrote: I will try to provide the requested info (although, I'm not sure how to measure total energy :) ) tools/power/x86/turbostat looks like a good tool. It can show, a.o., power consumption in Watts on modern

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread David C Niemi
On 06/06/13 05:55, Borislav Petkov wrote: Please do not top-post. On Wed, Jun 05, 2013 at 12:58:33PM -0400, David C Niemi wrote: When you are doing a locally-originated truly CPU-bound task, race to idle does make some sense. But I can think of a couple of caveats. 1) If you care about

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
On 06/06/2013 03:10 PM, Borislav Petkov wrote: On Thu, Jun 06, 2013 at 03:40:13PM +0530, Viresh Kumar wrote: his patch will give significant improvement both power performance wise. Yes, and I'd like to see the paperwork on that. Numbers, and on a couple of platforms/vendors if possible,

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Borislav Petkov
On Thu, Jun 06, 2013 at 07:46:17PM +0300, Stratos Karafotis wrote: Apologies for top-posting. I was able to send email only from my phone. Thanks for you hint about turbostat. As you most probably understood, I'm individual amateur kernel developer. I could provide some numbers from x86

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-06 Thread Stratos Karafotis
On 06/06/2013 08:11 PM, Borislav Petkov wrote: On Thu, Jun 06, 2013 at 07:46:17PM +0300, Stratos Karafotis wrote: Apologies for top-posting. I was able to send email only from my phone. Thanks for you hint about turbostat. As you most probably understood, I'm individual amateur kernel

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Rafael J. Wysocki
On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: > Hi Borislav, > > On 06/05/2013 07:17 PM, Borislav Petkov wrote: > > On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: > >> Ondemand calculates load in terms of frequency and increases it only > >> if the load_freq

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Stratos Karafotis
Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote: On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater than up_threshold multiplied by current or average frequency. This

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread David C Niemi
When you are doing a locally-originated truly CPU-bound task, "race to idle" does make some sense. But I can think of a couple of caveats. 1) If you care about power consumption, you want to avoid super-power-hungry turbo states, as you get less done per watt-hour than in some of the middle

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Borislav Petkov
On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: > Ondemand calculates load in terms of frequency and increases it only > if the load_freq is greater than up_threshold multiplied by current > or average frequency. This seems to produce oscillations of frequency > between min and

[PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Stratos Karafotis
Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater than up_threshold multiplied by current or average frequency. This seems to produce oscillations of frequency between min and max because, for example, a relatively small load can easily saturate

[PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Stratos Karafotis
Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater than up_threshold multiplied by current or average frequency. This seems to produce oscillations of frequency between min and max because, for example, a relatively small load can easily saturate

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Borislav Petkov
On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater than up_threshold multiplied by current or average frequency. This seems to produce oscillations of frequency between min and max

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread David C Niemi
When you are doing a locally-originated truly CPU-bound task, race to idle does make some sense. But I can think of a couple of caveats. 1) If you care about power consumption, you want to avoid super-power-hungry turbo states, as you get less done per watt-hour than in some of the middle

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Stratos Karafotis
Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote: On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater than up_threshold multiplied by current or average frequency. This

Re: [PATCH v3 1/3] cpufreq: ondemand: Change the calculation of target frequency

2013-06-05 Thread Rafael J. Wysocki
On Wednesday, June 05, 2013 08:13:26 PM Stratos Karafotis wrote: Hi Borislav, On 06/05/2013 07:17 PM, Borislav Petkov wrote: On Wed, Jun 05, 2013 at 07:01:25PM +0300, Stratos Karafotis wrote: Ondemand calculates load in terms of frequency and increases it only if the load_freq is greater