On Fri, Sep 16, 2016 at 04:25:00PM +0200, Christoph Hellwig wrote:
> On Fri, Sep 16, 2016 at 10:33:02AM -0400, Keith Busch wrote:
> > On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> > > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > > > Since this code
On Fri, Sep 16, 2016 at 04:25:00PM +0200, Christoph Hellwig wrote:
> On Fri, Sep 16, 2016 at 10:33:02AM -0400, Keith Busch wrote:
> > On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> > > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > > > Since this code
On Fri, 2016-09-16 at 10:33 +0200, Christoph Hellwig wrote:
> On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> >
> > As far as I can tell, there is basically nothing correct about this
> > code. It misinterprets npss (off-by-one). It hardcodes a bunch of
> > power states,
On Fri, 2016-09-16 at 10:33 +0200, Christoph Hellwig wrote:
> On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> >
> > As far as I can tell, there is basically nothing correct about this
> > code. It misinterprets npss (off-by-one). It hardcodes a bunch of
> > power states,
On Fri, Sep 16, 2016 at 10:33:02AM -0400, Keith Busch wrote:
> On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > > Since this code appears to be useless, just delete it.
> >
> > Yes, please!
>
> For a
On Fri, Sep 16, 2016 at 10:33:02AM -0400, Keith Busch wrote:
> On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> > On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > > Since this code appears to be useless, just delete it.
> >
> > Yes, please!
>
> For a
On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > Since this code appears to be useless, just delete it.
>
> Yes, please!
For a future patch, any objection to deleting the whole file? :)
On Fri, Sep 16, 2016 at 10:33:33AM +0200, Christoph Hellwig wrote:
> On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > Since this code appears to be useless, just delete it.
>
> Yes, please!
For a future patch, any objection to deleting the whole file? :)
On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> As far as I can tell, there is basically nothing correct about this
> code. It misinterprets npss (off-by-one). It hardcodes a bunch of
> power states, which is nonsense, because they're all just indices
> into a table that
On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> As far as I can tell, there is basically nothing correct about this
> code. It misinterprets npss (off-by-one). It hardcodes a bunch of
> power states, which is nonsense, because they're all just indices
> into a table that
As far as I can tell, there is basically nothing correct about this
code. It misinterprets npss (off-by-one). It hardcodes a bunch of
power states, which is nonsense, because they're all just indices
into a table that software needs to parse. It completely ignores
the distinction between
As far as I can tell, there is basically nothing correct about this
code. It misinterprets npss (off-by-one). It hardcodes a bunch of
power states, which is nonsense, because they're all just indices
into a table that software needs to parse. It completely ignores
the distinction between
12 matches
Mail list logo
