Re: [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module【请注意，邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】

[Kever Yang]

On 2020/10/13 下午2:37, Jianqun Xu wrote:

Make pinctrl-rockchip driver to be tristate module, support to build as
a module, this is useful for GKI.

Reviewed-by: Heiko Stuebner <he...@sntech.de>
Signed-off-by: Jianqun Xu <jay...@rock-chips.com>
---
  drivers/pinctrl/Kconfig            |  2 +-
  drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
  2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 815095326e2d..bc9774c1ae8d 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -207,7 +207,7 @@ config PINCTRL_OXNAS
        select MFD_SYSCON

config PINCTRL_ROCKCHIP

-       bool
+       tristate "Rockchip gpio and pinctrl driver"
        depends on OF
        select PINMUX
        select GENERIC_PINCONF
diff --git a/drivers/pinctrl/pinctrl-rockchip.c 
b/drivers/pinctrl/pinctrl-rockchip.c
index 0401c1da79dd..927d132d6716 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -16,10 +16,12 @@
   */

#include <linux/init.h>

+#include <linux/module.h>
  #include <linux/platform_device.h>
  #include <linux/io.h>
  #include <linux/bitops.h>
  #include <linux/gpio/driver.h>
+#include <linux/of_device.h>
  #include <linux/of_address.h>
  #include <linux/of_irq.h>
  #include <linux/pinctrl/machine.h>
@@ -4258,3 +4260,14 @@ static int __init rockchip_pinctrl_drv_register(void)
        return platform_driver_register(&rockchip_pinctrl_driver);
  }
  postcore_initcall(rockchip_pinctrl_drv_register);
+
+static void __exit rockchip_pinctrl_drv_unregister(void)
+{
+       platform_driver_unregister(&rockchip_pinctrl_driver);
+}
+module_exit(rockchip_pinctrl_drv_unregister);
+
+MODULE_DESCRIPTION("ROCKCHIP Pin Controller Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:pinctrl-rockchip");
+MODULE_DEVICE_TABLE(of, rockchip_pinctrl_dt_match);

Looks good to me,

Reviewed-by: Kever Yang<kever.y...@rock-chips.com>

Thanks,
- Kever