Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Jonathan Cameron
On Sat, 3 Nov 2018 12:59:16 -0300 Renato Lui Geh wrote: > Hi, > > >On Thu, 1 Nov 2018 15:02:32 + > >"Ardelean, Alexandru" wrote: > > > >> Good catch. > > That was actually Jonathan's catch. :) > > >> Acked-by: Alexandru Ardelean > > I read up on Acked-by on the kernel docs, as I

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Jonathan Cameron
On Sat, 3 Nov 2018 12:59:16 -0300 Renato Lui Geh wrote: > Hi, > > >On Thu, 1 Nov 2018 15:02:32 + > >"Ardelean, Alexandru" wrote: > > > >> Good catch. > > That was actually Jonathan's catch. :) > > >> Acked-by: Alexandru Ardelean > > I read up on Acked-by on the kernel docs, as I

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Renato Lui Geh
Hi, On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: Good catch. That was actually Jonathan's catch. :) Acked-by: Alexandru Ardelean I read up on Acked-by on the kernel docs, as I didn't know exactly what it meant, but I'm not so sure on how to proceed once the patch has

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Renato Lui Geh
Hi, On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: Good catch. That was actually Jonathan's catch. :) Acked-by: Alexandru Ardelean I read up on Acked-by on the kernel docs, as I didn't know exactly what it meant, but I'm not so sure on how to proceed once the patch has

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: > Good catch. > > Acked-by: Alexandru Ardelean On the basis this has been broken for a long time, and you are clearly doing other nearby not fix work, I'm going to take this through the togreg tree rather than via the quicker fix

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: > Good catch. > > Acked-by: Alexandru Ardelean On the basis this has been broken for a long time, and you are clearly doing other nearby not fix work, I'm going to take this through the togreg tree rather than via the quicker fix

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-01 Thread Ardelean, Alexandru
Good catch. Acked-by: Alexandru Ardelean On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > This was fixed by assigning the correct value instead. > > Signed-off-by: Renato Lui Geh > --- >

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-01 Thread Ardelean, Alexandru
Good catch. Acked-by: Alexandru Ardelean On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > This was fixed by assigning the correct value instead. > > Signed-off-by: Renato Lui Geh > --- >

[PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-01 Thread Renato Lui Geh
Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. This was fixed by assigning the correct value instead. Signed-off-by: Renato Lui Geh --- drivers/staging/iio/adc/ad7780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7780.c

[PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-01 Thread Renato Lui Geh
Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. This was fixed by assigning the correct value instead. Signed-off-by: Renato Lui Geh --- drivers/staging/iio/adc/ad7780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7780.c