Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2014-08-26 Thread Wei Ni
On 08/27/2014 12:37 AM, Stephen Warren wrote: > On 08/26/2014 06:17 AM, Eduardo Valentin wrote: >> On Tue, Aug 26, 2014 at 10:27:43AM +0800, Wei Ni wrote: >>> On 08/25/2014 08:23 PM, Mikko Perttunen wrote: FWIW, please fix the authorship information for next version. >>> >>> Sorry, I didn't

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2014-08-26 Thread Stephen Warren
On 08/26/2014 06:17 AM, Eduardo Valentin wrote: On Tue, Aug 26, 2014 at 10:27:43AM +0800, Wei Ni wrote: On 08/25/2014 08:23 PM, Mikko Perttunen wrote: FWIW, please fix the authorship information for next version. Sorry, I didn't get your point, did you mean I should remove the line "From:

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2014-08-26 Thread Eduardo Valentin
On Tue, Aug 26, 2014 at 10:27:43AM +0800, Wei Ni wrote: > On 08/25/2014 08:23 PM, Mikko Perttunen wrote: > > FWIW, please fix the authorship information for next version. > > Sorry, I didn't get your point, did you mean I should remove the line > "From: lightning314 " ? Yes I made a mistake on

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2014-08-25 Thread Wei Ni
On 08/25/2014 08:23 PM, Mikko Perttunen wrote: > FWIW, please fix the authorship information for next version. Sorry, I didn't get your point, did you mean I should remove the line "From: lightning314 " ? Yes I made a mistake on it, I will remove it in next version. Thanks. Wei. > > Cheers, >

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2014-08-25 Thread Mikko Perttunen
FWIW, please fix the authorship information for next version. Cheers, Mikko On 25/08/14 09:29, Wei Ni wrote: From: lightning314 Split set temp codes as common functions, so we can use it directly when implement linux thermal framework. And handle error return value for the

[PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2014-08-25 Thread Wei Ni
From: lightning314 Split set temp codes as common functions, so we can use it directly when implement linux thermal framework. And handle error return value for the lm90_select_remote_channel and write_tempx, then set_temp8 and set_temp11 could return it to user-space. Signed-off-by: Wei Ni

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-17 Thread Wei Ni
On 07/17/2013 05:11 PM, Jean Delvare wrote: > On Wed, 17 Jul 2013 14:26:54 +0800, Wei Ni wrote: >> On 07/17/2013 01:14 PM, Guenter Roeck wrote: >>> On Wed, Jul 17, 2013 at 06:26:20AM +0200, Thierry Reding wrote: On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote: > On Mon, 15

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-17 Thread Jean Delvare
On Wed, 17 Jul 2013 14:26:54 +0800, Wei Ni wrote: > On 07/17/2013 01:14 PM, Guenter Roeck wrote: > > On Wed, Jul 17, 2013 at 06:26:20AM +0200, Thierry Reding wrote: > >> On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote: > >>> On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: > I

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-17 Thread Wei Ni
On 07/17/2013 01:14 PM, Guenter Roeck wrote: > On Wed, Jul 17, 2013 at 06:26:20AM +0200, Thierry Reding wrote: >> On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote: >>> On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: On 07/12/2013 10:40 PM, Guenter Roeck wrote: > On Fri, Jul

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-16 Thread Guenter Roeck
On Wed, Jul 17, 2013 at 06:26:20AM +0200, Thierry Reding wrote: > On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote: > > On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: > > > On 07/12/2013 10:40 PM, Guenter Roeck wrote: > > > > On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-16 Thread Thierry Reding
On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote: > On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: > > On 07/12/2013 10:40 PM, Guenter Roeck wrote: > > > On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare wrote: > > >> If that means that for example the ACPI thermal zone is no

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-15 Thread Jean Delvare
Hi Wei, On Mon, 15 Jul 2013 17:14:07 +0800, Wei Ni wrote: > On 07/15/2013 03:24 PM, Jean Delvare wrote: > > On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: > >> I think we can decide it in the DT, we can add a dt property in the lm90 > >> device node, such as: > >> sys-interface = SYS_HWMON; >

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-15 Thread Wei Ni
On 07/15/2013 03:24 PM, Jean Delvare wrote: > On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: >> On 07/12/2013 10:40 PM, Guenter Roeck wrote: >>> On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare wrote: If that means that for example the ACPI thermal zone is no longer displayed by

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-15 Thread Jean Delvare
Hi Wei, On Mon, 15 Jul 2013 14:05:08 +0800, Wei Ni wrote: > On 07/12/2013 09:26 PM, Jean Delvare wrote: > > Can I see a recent version of the code which will need this change? It > > makes no sense to apply this first part which makes the code more > > complex with no benefit, without the second

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-15 Thread Jean Delvare
On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote: > On 07/12/2013 10:40 PM, Guenter Roeck wrote: > > On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare wrote: > >> If that means that for example the ACPI thermal zone is no longer > >> displayed by "sensors", then I strongly object - unless it

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-15 Thread Wei Ni
On 07/12/2013 10:40 PM, Guenter Roeck wrote: > On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare wrote: >> Hi Guenter, >> >> On Fri, 12 Jul 2013 06:50:00 -0700, Guenter Roeck wrote: >>> On Fri, Jul 12, 2013 at 03:26:15PM +0200, Jean Delvare wrote: One thing I am a little worried about

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-15 Thread Wei Ni
On 07/12/2013 09:26 PM, Jean Delvare wrote: > Hi Wei, Guenter, > > Guenter, thanks for reviewing the previous version of this patch. > > Wei, thanks for incorporating review feedback and posting updated > patches so quickly, this is very appreciated, even though I'm too busy > these days to be

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-12 Thread Guenter Roeck
On Fri, Jul 12, 2013 at 04:30:34PM +0200, Jean Delvare wrote: > Hi Guenter, > > On Fri, 12 Jul 2013 06:50:00 -0700, Guenter Roeck wrote: > > On Fri, Jul 12, 2013 at 03:26:15PM +0200, Jean Delvare wrote: > > > One thing I am a little worried about (but maybe I'm wrong) is that I > > > seem to

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-12 Thread Jean Delvare
Hi Guenter, On Fri, 12 Jul 2013 06:50:00 -0700, Guenter Roeck wrote: > On Fri, Jul 12, 2013 at 03:26:15PM +0200, Jean Delvare wrote: > > One thing I am a little worried about (but maybe I'm wrong) is that I > > seem to understand you want to register every LM90-like chip as both a > > hwmon

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-12 Thread Guenter Roeck
On Fri, Jul 12, 2013 at 03:26:15PM +0200, Jean Delvare wrote: > Hi Wei, Guenter, > > Guenter, thanks for reviewing the previous version of this patch. > > Wei, thanks for incorporating review feedback and posting updated > patches so quickly, this is very appreciated, even though I'm too busy >

Re: [PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-12 Thread Jean Delvare
Hi Wei, Guenter, Guenter, thanks for reviewing the previous version of this patch. Wei, thanks for incorporating review feedback and posting updated patches so quickly, this is very appreciated, even though I'm too busy these days to be that fast on my end, sorry about that. On Fri, 12 Jul 2013

[PATCH v3 1/4] hwmon: (lm90) split set temp as common codes

2013-07-12 Thread Wei Ni
Split set temp codes as common functions, so we can use it directly when implement linux thermal framework. Signed-off-by: Wei Ni --- drivers/hwmon/lm90.c | 112 +++--- 1 file changed, 69 insertions(+), 43 deletions(-) diff --git