Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 10:53:11AM +0100, Peter Ujfalusi wrote: > On 12/11/2012 10:48 AM, Thierry Reding wrote: > > On Tue, Dec 11, 2012 at 10:39:53AM +0100, Peter Ujfalusi wrote: > >> On 12/11/2012 10:31 AM, Thierry Reding wrote: > >>> On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Peter Ujfalusi
On 12/11/2012 10:48 AM, Thierry Reding wrote: > On Tue, Dec 11, 2012 at 10:39:53AM +0100, Peter Ujfalusi wrote: >> On 12/11/2012 10:31 AM, Thierry Reding wrote: >>> On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: >>> Okay, if there are no intree users that may be broken, then it

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 10:39:53AM +0100, Peter Ujfalusi wrote: > On 12/11/2012 10:31 AM, Thierry Reding wrote: > > On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: > > Okay, if there are no intree users that may be broken, then it should be > > fine to remove it. In that case you

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Peter Ujfalusi
On 12/11/2012 10:31 AM, Thierry Reding wrote: > On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: > Okay, if there are no intree users that may be broken, then it should be > fine to remove it. In that case you might want to remove the pwm_id > field as well instead of deprecating it

Re: Re: Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: > On Tuesday 11 December 2012 09:36:35 Thierry Reding wrote: > > > > The commit message says that legacy mode is used as fallback if > > > > devm_get_pwm() (that should really be devm_pwm_get() btw) fails but I > > > > don't see where

Re: Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 09:29:21AM +0100, Peter Ujfalusi wrote: > On Tuesday 11 December 2012 08:03:07 Thierry Reding wrote: > > On Mon, Dec 10, 2012 at 11:00:34AM +0100, Peter Ujfalusi wrote: > > > Update the driver to use the new API for requesting pwm so we can take > > > advantage of the

Re: Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 09:29:21AM +0100, Peter Ujfalusi wrote: On Tuesday 11 December 2012 08:03:07 Thierry Reding wrote: On Mon, Dec 10, 2012 at 11:00:34AM +0100, Peter Ujfalusi wrote: Update the driver to use the new API for requesting pwm so we can take advantage of the pwm_lookup

Re: Re: Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: On Tuesday 11 December 2012 09:36:35 Thierry Reding wrote: The commit message says that legacy mode is used as fallback if devm_get_pwm() (that should really be devm_pwm_get() btw) fails but I don't see where

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Peter Ujfalusi
On 12/11/2012 10:31 AM, Thierry Reding wrote: On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: Okay, if there are no intree users that may be broken, then it should be fine to remove it. In that case you might want to remove the pwm_id field as well instead of deprecating it in

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 10:39:53AM +0100, Peter Ujfalusi wrote: On 12/11/2012 10:31 AM, Thierry Reding wrote: On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: Okay, if there are no intree users that may be broken, then it should be fine to remove it. In that case you might

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Peter Ujfalusi
On 12/11/2012 10:48 AM, Thierry Reding wrote: On Tue, Dec 11, 2012 at 10:39:53AM +0100, Peter Ujfalusi wrote: On 12/11/2012 10:31 AM, Thierry Reding wrote: On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: Okay, if there are no intree users that may be broken, then it should be

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-11 Thread Thierry Reding
On Tue, Dec 11, 2012 at 10:53:11AM +0100, Peter Ujfalusi wrote: On 12/11/2012 10:48 AM, Thierry Reding wrote: On Tue, Dec 11, 2012 at 10:39:53AM +0100, Peter Ujfalusi wrote: On 12/11/2012 10:31 AM, Thierry Reding wrote: On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote: Okay,

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-10 Thread Thierry Reding
On Mon, Dec 10, 2012 at 11:00:34AM +0100, Peter Ujfalusi wrote: > Update the driver to use the new API for requesting pwm so we can take > advantage of the pwm_lookup table to find the correct pwm to be used for the > LED functionality. > If the devm_get_pwm fails we fall back to legacy mode to

[PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-10 Thread Peter Ujfalusi
Update the driver to use the new API for requesting pwm so we can take advantage of the pwm_lookup table to find the correct pwm to be used for the LED functionality. If the devm_get_pwm fails we fall back to legacy mode to try to get the pwm. Signed-off-by: Peter Ujfalusi ---

[PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-10 Thread Peter Ujfalusi
Update the driver to use the new API for requesting pwm so we can take advantage of the pwm_lookup table to find the correct pwm to be used for the LED functionality. If the devm_get_pwm fails we fall back to legacy mode to try to get the pwm. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-10 Thread Thierry Reding
On Mon, Dec 10, 2012 at 11:00:34AM +0100, Peter Ujfalusi wrote: Update the driver to use the new API for requesting pwm so we can take advantage of the pwm_lookup table to find the correct pwm to be used for the LED functionality. If the devm_get_pwm fails we fall back to legacy mode to try to