Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Tue, 2015-11-03 at 21:57 +0100, Rasmus Villemoes wrote: > On Tue, Nov 03 2015, James Bottomley wrote: > > > > > It was a suggestion when I explained what the missing sources of > > precision were, I don't think it's really a suggestion when it comes > > with an exemplary patch. > >

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Tue, Nov 03 2015, James Bottomley wrote: > > It was a suggestion when I explained what the missing sources of > precision were, I don't think it's really a suggestion when it comes > with an exemplary patch. ex·em·pla·ry adjective 1. serving as a desirable model; representing the

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Tue, 2015-11-03 at 14:13 +0100, Vitaly Kuznetsov wrote: > James Bottomley writes: > > > On Mon, 2015-11-02 at 16:58 +0100, Vitaly Kuznetsov wrote: > >> James Bottomley writes: > >> > >> > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: > >> >> James Bottomley writes: > >> >> >

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

James Bottomley writes: > On Mon, 2015-11-02 at 16:58 +0100, Vitaly Kuznetsov wrote: >> James Bottomley writes: >> >> > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: >> >> James Bottomley writes: >> >> >> >> > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >> >> >>

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

James Bottomley writes: > On Mon, 2015-11-02 at 16:58 +0100, Vitaly Kuznetsov wrote: >> James Bottomley writes: >> >> > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: >> >> James Bottomley writes: >> >> >> >> > On

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Tue, 2015-11-03 at 14:13 +0100, Vitaly Kuznetsov wrote: > James Bottomley writes: > > > On Mon, 2015-11-02 at 16:58 +0100, Vitaly Kuznetsov wrote: > >> James Bottomley writes: > >> > >> > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: >

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Tue, Nov 03 2015, James Bottomley wrote: > > It was a suggestion when I explained what the missing sources of > precision were, I don't think it's really a suggestion when it comes > with an exemplary patch. ex·em·pla·ry adjective 1. serving as a desirable

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Tue, 2015-11-03 at 21:57 +0100, Rasmus Villemoes wrote: > On Tue, Nov 03 2015, James Bottomley wrote: > > > > > It was a suggestion when I explained what the missing sources of > > precision were, I don't think it's really a suggestion when it comes > > with an exemplary

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Mon, 2015-11-02 at 16:58 +0100, Vitaly Kuznetsov wrote: > James Bottomley writes: > > > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: > >> James Bottomley writes: > >> > >> > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: > >> >> string_get_size() can't really

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

James Bottomley writes: > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: >> James Bottomley writes: >> >> > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >> >> string_get_size() can't really handle huge block sizes, especially >> >> blk_size > U32_MAX but

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

James Bottomley writes: > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: >> James Bottomley writes: >> >> > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >> >> string_get_size() can't really handle huge block sizes, especially

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Mon, 2015-11-02 at 16:58 +0100, Vitaly Kuznetsov wrote: > James Bottomley writes: > > > On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: > >> James Bottomley writes: > >> > >> > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: > James Bottomley writes: > > > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: > >> string_get_size() can't really handle huge block sizes, especially > >> blk_size > U32_MAX but string_get_size() interface states the

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

James Bottomley writes: > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >> string_get_size() can't really handle huge block sizes, especially >> blk_size > U32_MAX but string_get_size() interface states the opposite. >> Change blk_size from u64 to u32 to reflect the reality. > >

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

James Bottomley writes: > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >> string_get_size() can't really handle huge block sizes, especially >> blk_size > U32_MAX but string_get_size() interface states the opposite. >> Change blk_size from u64 to u32 to reflect

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Fri, 2015-10-30 at 11:46 +0100, Vitaly Kuznetsov wrote: > James Bottomley writes: > > > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: > >> string_get_size() can't really handle huge block sizes, especially > >> blk_size > U32_MAX but string_get_size()

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Fri, 2015-10-30 at 00:19 +0100, Rasmus Villemoes wrote: > On Thu, Oct 29 2015, James Bottomley wrote: > > > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: > >> string_get_size() can't really handle huge block sizes, especially > >> blk_size > U32_MAX but string_get_size()

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Fri, Oct 30 2015, Rasmus Villemoes wrote: > block sizes as well. For ~13000 semirandom size,blk_size pairs, Sorry, that should have been ~2. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Thu, Oct 29 2015, James Bottomley wrote: > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >> string_get_size() can't really handle huge block sizes, especially >> blk_size > U32_MAX but string_get_size() interface states the opposite. >> Change blk_size from u64 to u32 to reflect

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: > string_get_size() can't really handle huge block sizes, especially > blk_size > U32_MAX but string_get_size() interface states the opposite. > Change blk_size from u64 to u32 to reflect the reality. What is the actual evidence for this?

[PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

string_get_size() can't really handle huge block sizes, especially blk_size > U32_MAX but string_get_size() interface states the opposite. Change blk_size from u64 to u32 to reflect the reality. Signed-off-by: Vitaly Kuznetsov --- include/linux/string_helpers.h | 2 +- lib/string_helpers.c

[PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

string_get_size() can't really handle huge block sizes, especially blk_size > U32_MAX but string_get_size() interface states the opposite. Change blk_size from u64 to u32 to reflect the reality. Signed-off-by: Vitaly Kuznetsov --- include/linux/string_helpers.h | 2 +-

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: > string_get_size() can't really handle huge block sizes, especially > blk_size > U32_MAX but string_get_size() interface states the opposite. > Change blk_size from u64 to u32 to reflect the reality. What is the actual evidence for this?

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Thu, Oct 29 2015, James Bottomley wrote: > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: >> string_get_size() can't really handle huge block sizes, especially >> blk_size > U32_MAX but string_get_size() interface states the opposite. >> Change blk_size from

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Fri, Oct 30 2015, Rasmus Villemoes wrote: > block sizes as well. For ~13000 semirandom size,blk_size pairs, Sorry, that should have been ~2. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v3 1/4] lib/string_helpers: change blk_size to u32 for string_get_size() interface

On Fri, 2015-10-30 at 00:19 +0100, Rasmus Villemoes wrote: > On Thu, Oct 29 2015, James Bottomley wrote: > > > On Thu, 2015-10-29 at 17:30 +0100, Vitaly Kuznetsov wrote: > >> string_get_size() can't really handle huge block sizes, especially > >> blk_size > U32_MAX but