Re: [PATCH v3 1/4] rtc: isl1208: enable interrupt after context preparation

2018-03-06 Thread Alexandre Belloni
On 05/03/2018 at 10:43:53 +, Denis OSTERLAND wrote: > From: Michael Grzeschik > > The interrupt handler got enabled very early. If the interrupt cause is > triggering immediately before the context is fully prepared. This can > lead to undefined behaviour.

Re: [PATCH v3 1/4] rtc: isl1208: enable interrupt after context preparation

2018-03-06 Thread Alexandre Belloni
On 05/03/2018 at 10:43:53 +, Denis OSTERLAND wrote: > From: Michael Grzeschik > > The interrupt handler got enabled very early. If the interrupt cause is > triggering immediately before the context is fully prepared. This can > lead to undefined behaviour. Therefor we move the interrupt

[PATCH v3 1/4] rtc: isl1208: enable interrupt after context preparation

2018-03-05 Thread Denis OSTERLAND
From: Michael Grzeschik The interrupt handler got enabled very early. If the interrupt cause is triggering immediately before the context is fully prepared. This can lead to undefined behaviour. Therefor we move the interrupt enable code to the end of the probe

[PATCH v3 1/4] rtc: isl1208: enable interrupt after context preparation

2018-03-05 Thread Denis OSTERLAND
From: Michael Grzeschik The interrupt handler got enabled very early. If the interrupt cause is triggering immediately before the context is fully prepared. This can lead to undefined behaviour. Therefor we move the interrupt enable code to the end of the probe function. Signed-off-by: Michael