Re: [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core

2013-11-22 Thread Mark Brown
On Fri, Nov 22, 2013 at 09:46:08AM +0100, Krzysztof Kozlowski wrote: > From: Chanwoo Choi > > This patch adds max14577 core/irq driver to support MUIC(Micro USB IC) > device and charger device and support irq domain method to control > internal interrupt of max14577 device. Also, this patch suppo

Re: [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core

2013-11-22 Thread Lee Jones
> > > +static struct mfd_cell max14577_devs[] = { > > > + { .name = "max14577-muic", }, > > > + { .name = "max14577-regulator", }, > > > + { .name = "max14577-charger", }, > > > +}; > > > > If these all support device tree, shouldn't you be populating > > max14577_devs[x].of_compatible too? That w

Re: [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core

2013-11-22 Thread Krzysztof Kozlowski
On Fri, 2013-11-22 at 09:31 +, Lee Jones wrote: (...) > > +static struct mfd_cell max14577_devs[] = { > > + { .name = "max14577-muic", }, > > + { .name = "max14577-regulator", }, > > + { .name = "max14577-charger", }, > > +}; > > If these all support device tree, shouldn't you be popul

Re: [PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core

2013-11-22 Thread Lee Jones
On Fri, 22 Nov 2013, Krzysztof Kozlowski wrote: > From: Chanwoo Choi > > This patch adds max14577 core/irq driver to support MUIC(Micro USB IC) > device and charger device and support irq domain method to control > internal interrupt of max14577 device. Also, this patch supports DT > binding wit

[PATCH v3 1/5] mfd: max14577: Add max14577 MFD driver core

2013-11-22 Thread Krzysztof Kozlowski
From: Chanwoo Choi This patch adds max14577 core/irq driver to support MUIC(Micro USB IC) device and charger device and support irq domain method to control internal interrupt of max14577 device. Also, this patch supports DT binding with max14577_i2c_parse_dt(). The MAXIM 14577 chip contains Mic