Re: [PATCH v3 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators

2021-03-31 Thread Mark Brown
On Tue, Mar 30, 2021 at 12:23:35PM -0400, Jim Quinlan wrote: > On Tue, Mar 30, 2021 at 11:30 AM Mark Brown wrote: > > For a soldered down part I'd expect we'd want both (if the host even > > cares) - for anything except a supply that I/O or something else shared > > is referenced off there's no

Re: [PATCH v3 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators

2021-03-30 Thread Jim Quinlan
On Tue, Mar 30, 2021 at 11:30 AM Mark Brown wrote: >10.22.8.121 > On Tue, Mar 30, 2021 at 10:08:16AM -0500, Rob Herring wrote: > > On Fri, Mar 26, 2021 at 03:18:59PM -0400, Jim Quinlan wrote: > > > > +pcie-ep@0,0 { > > > +reg = <0x0 0x0 0x0 0x0

Re: [PATCH v3 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators

2021-03-30 Thread Mark Brown
On Tue, Mar 30, 2021 at 10:08:16AM -0500, Rob Herring wrote: > On Fri, Mar 26, 2021 at 03:18:59PM -0400, Jim Quinlan wrote: > > +pcie-ep@0,0 { > > +reg = <0x0 0x0 0x0 0x0 0x0>; > > +compatible = "pci14e4,1688"; > > +

Re: [PATCH v3 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators

2021-03-30 Thread Rob Herring
On Fri, Mar 26, 2021 at 03:18:59PM -0400, Jim Quinlan wrote: > Similar to the regulator bindings found in "rockchip-pcie-host.txt", this > allows optional regulators to be attached and controlled by the PCIe RC > driver. That being said, this driver searches in the DT subnode (the EP > node, eg

Re: [PATCH v3 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators

2021-03-27 Thread Rob Herring
On Fri, 26 Mar 2021 15:18:59 -0400, Jim Quinlan wrote: > Similar to the regulator bindings found in "rockchip-pcie-host.txt", this > allows optional regulators to be attached and controlled by the PCIe RC > driver. That being said, this driver searches in the DT subnode (the EP > node, eg

[PATCH v3 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators

2021-03-26 Thread Jim Quinlan
Similar to the regulator bindings found in "rockchip-pcie-host.txt", this allows optional regulators to be attached and controlled by the PCIe RC driver. That being said, this driver searches in the DT subnode (the EP node, eg pci@0,0) for the regulator property. The use of a regulator property