Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
On Thursday 15 May 2014 02:47 PM, Sebastian Hesselbarth wrote: > On 05/15/2014 10:46 AM, Kishon Vijay Abraham I wrote: >> On Thursday 15 May 2014 12:32 PM, Sebastian Hesselbarth wrote: >>> On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:12 AM, Sebastian

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Sebastian Hesselbarth
On 05/15/2014 10:46 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:32 PM, Sebastian Hesselbarth wrote: On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: On 05/14/2014 08:12 PM, Arnd Bergmann wrote: On Wednesday

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
Hi, On Thursday 15 May 2014 12:32 PM, Sebastian Hesselbarth wrote: > On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: >> On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: >>> On 05/14/2014 08:12 PM, Arnd Bergmann wrote: On Wednesday 14 May 2014 19:57:46 Sebastian

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Sebastian Hesselbarth
On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: > On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: >> On 05/14/2014 08:12 PM, Arnd Bergmann wrote: >>> On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: On 05/14/2014 06:57 PM, Antoine Ténart wrote: > On Wed,

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
Hi, On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: > On 05/14/2014 08:12 PM, Arnd Bergmann wrote: >> On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: >>> On 05/14/2014 06:57 PM, Antoine Ténart wrote: On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote:

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
Hi, On Wednesday 14 May 2014 03:51 PM, Antoine Ténart wrote: > Hi, > > On Wed, May 14, 2014 at 03:43:03PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 14 May 2014 03:18 PM, Antoine Ténart wrote: > > […] > >>> +#define to_berlin_sata_phy_priv(desc) \ >>> +

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
Hi, On Wednesday 14 May 2014 03:51 PM, Antoine Ténart wrote: Hi, On Wed, May 14, 2014 at 03:43:03PM +0530, Kishon Vijay Abraham I wrote: Hi, On Wednesday 14 May 2014 03:18 PM, Antoine Ténart wrote: […] +#define to_berlin_sata_phy_priv(desc) \ + container_of((desc), struct

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
Hi, On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: On 05/14/2014 08:12 PM, Arnd Bergmann wrote: On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: On 05/14/2014 06:57 PM, Antoine Ténart wrote: On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: On

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Sebastian Hesselbarth
On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: On 05/14/2014 08:12 PM, Arnd Bergmann wrote: On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: On 05/14/2014 06:57 PM, Antoine Ténart wrote: On Wed, May 14, 2014

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
Hi, On Thursday 15 May 2014 12:32 PM, Sebastian Hesselbarth wrote: On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: On 05/14/2014 08:12 PM, Arnd Bergmann wrote: On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote:

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Sebastian Hesselbarth
On 05/15/2014 10:46 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:32 PM, Sebastian Hesselbarth wrote: On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth wrote: On 05/14/2014 08:12 PM, Arnd Bergmann wrote: On Wednesday

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-15 Thread Kishon Vijay Abraham I
On Thursday 15 May 2014 02:47 PM, Sebastian Hesselbarth wrote: On 05/15/2014 10:46 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:32 PM, Sebastian Hesselbarth wrote: On 05/15/2014 08:45 AM, Kishon Vijay Abraham I wrote: On Thursday 15 May 2014 12:12 AM, Sebastian Hesselbarth

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 20:56:29 Sebastian Hesselbarth wrote: > On 05/14/2014 08:51 PM, Arnd Bergmann wrote: > > On Wednesday 14 May 2014 20:42:16 Sebastian Hesselbarth wrote: > For the driver, Antoine then would have to squeeze all PHY register > mangling in phy-berlin2.c and see how

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Sebastian Hesselbarth
On 05/14/2014 08:51 PM, Arnd Bergmann wrote: > On Wednesday 14 May 2014 20:42:16 Sebastian Hesselbarth wrote: For the driver, Antoine then would have to squeeze all PHY register mangling in phy-berlin2.c and see how to make ahci-platform aware of individual port nodes (I haven't

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 20:42:16 Sebastian Hesselbarth wrote: > >> For the driver, Antoine then would have to squeeze all PHY register > >> mangling in phy-berlin2.c and see how to make ahci-platform aware of > >> individual port nodes (I haven't looked up if it already exists, sorry) > >> and

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Sebastian Hesselbarth
On 05/14/2014 08:12 PM, Arnd Bergmann wrote: > On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: >> On 05/14/2014 06:57 PM, Antoine Ténart wrote: >>> On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: > On

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: > On 05/14/2014 06:57 PM, Antoine Ténart wrote: > > On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: > >> On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: > >>> On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Sebastian Hesselbarth
On 05/14/2014 06:57 PM, Antoine Ténart wrote: > On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: >> On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: >>> On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd Bergmann wrote: Why do you need a custom mask? Is that something you

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: > On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: > > On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd Bergmann wrote: > > > On Wednesday 14 May 2014 16:50:02 Antoine Ténart wrote: > > > > On Wed, May 14, 2014 at 03:02:34PM

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: > On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd Bergmann wrote: > > On Wednesday 14 May 2014 16:50:02 Antoine Ténart wrote: > > > On Wed, May 14, 2014 at 03:02:34PM +0200, Arnd Bergmann wrote: > > > > On Wednesday 14 May 2014 11:48:57

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd Bergmann wrote: > On Wednesday 14 May 2014 16:50:02 Antoine Ténart wrote: > > On Wed, May 14, 2014 at 03:02:34PM +0200, Arnd Bergmann wrote: > > > On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: > > > > +static int

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 16:50:02 Antoine Ténart wrote: > On Wed, May 14, 2014 at 03:02:34PM +0200, Arnd Bergmann wrote: > > On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: > > > +static int phy_berlin_sata_power_on(struct phy *phy) > > > +{ > > > + struct phy_berlin_desc *desc =

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
Arnd, On Wed, May 14, 2014 at 03:02:34PM +0200, Arnd Bergmann wrote: > On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: > > +static int phy_berlin_sata_power_on(struct phy *phy) > > +{ > > + struct phy_berlin_desc *desc = phy_get_drvdata(phy); > > + struct phy_berlin_priv *priv

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: > +static int phy_berlin_sata_power_on(struct phy *phy) > +{ > + struct phy_berlin_desc *desc = phy_get_drvdata(phy); > + struct phy_berlin_priv *priv = to_berlin_sata_phy_priv(desc); > + u32 regval; > + > +

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
Hi, On Wed, May 14, 2014 at 03:43:03PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 14 May 2014 03:18 PM, Antoine Ténart wrote: […] > > +#define to_berlin_sata_phy_priv(desc) \ > > + container_of((desc), struct phy_berlin_priv, phys[(desc)->index]) > > + > > +struct

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Kishon Vijay Abraham I
Hi, On Wednesday 14 May 2014 03:18 PM, Antoine Ténart wrote: > The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. > > Signed-off-by: Antoine Ténart > --- > drivers/phy/Kconfig | 5 ++ > drivers/phy/Makefile | 1 + > drivers/phy/phy-berlin-sata.c | 180

[PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. Signed-off-by: Antoine Ténart --- drivers/phy/Kconfig | 5 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-berlin-sata.c | 180 ++ 3 files changed, 186

[PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. Signed-off-by: Antoine Ténart antoine.ten...@free-electrons.com --- drivers/phy/Kconfig | 5 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-berlin-sata.c | 180 ++

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Kishon Vijay Abraham I
Hi, On Wednesday 14 May 2014 03:18 PM, Antoine Ténart wrote: The Berlin SoC has a two SATA ports. Add a PHY driver to handle them. Signed-off-by: Antoine Ténart antoine.ten...@free-electrons.com --- drivers/phy/Kconfig | 5 ++ drivers/phy/Makefile | 1 +

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
Hi, On Wed, May 14, 2014 at 03:43:03PM +0530, Kishon Vijay Abraham I wrote: Hi, On Wednesday 14 May 2014 03:18 PM, Antoine Ténart wrote: […] +#define to_berlin_sata_phy_priv(desc) \ + container_of((desc), struct phy_berlin_priv, phys[(desc)-index]) + +struct phy_berlin_desc {

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: +static int phy_berlin_sata_power_on(struct phy *phy) +{ + struct phy_berlin_desc *desc = phy_get_drvdata(phy); + struct phy_berlin_priv *priv = to_berlin_sata_phy_priv(desc); + u32 regval; + +

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
Arnd, On Wed, May 14, 2014 at 03:02:34PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: +static int phy_berlin_sata_power_on(struct phy *phy) +{ + struct phy_berlin_desc *desc = phy_get_drvdata(phy); + struct phy_berlin_priv *priv =

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 16:50:02 Antoine Ténart wrote: On Wed, May 14, 2014 at 03:02:34PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: +static int phy_berlin_sata_power_on(struct phy *phy) +{ + struct phy_berlin_desc *desc =

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Antoine Ténart
On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 16:50:02 Antoine Ténart wrote: On Wed, May 14, 2014 at 03:02:34PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 11:48:57 Antoine Ténart wrote: +static int phy_berlin_sata_power_on(struct phy

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Sebastian Hesselbarth
On 05/14/2014 06:57 PM, Antoine Ténart wrote: On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd Bergmann wrote: Why do you need a custom mask? Is that something you could pass

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: On 05/14/2014 06:57 PM, Antoine Ténart wrote: On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: On Wed, May 14, 2014 at 05:31:24PM +0200, Arnd Bergmann wrote:

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Sebastian Hesselbarth
On 05/14/2014 08:12 PM, Arnd Bergmann wrote: On Wednesday 14 May 2014 19:57:46 Sebastian Hesselbarth wrote: On 05/14/2014 06:57 PM, Antoine Ténart wrote: On Wed, May 14, 2014 at 06:11:24PM +0200, Arnd Bergmann wrote: On Wednesday 14 May 2014 17:49:29 Antoine Ténart wrote: On Wed, May 14, 2014

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 20:42:16 Sebastian Hesselbarth wrote: For the driver, Antoine then would have to squeeze all PHY register mangling in phy-berlin2.c and see how to make ahci-platform aware of individual port nodes (I haven't looked up if it already exists, sorry) and announce only

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Sebastian Hesselbarth
On 05/14/2014 08:51 PM, Arnd Bergmann wrote: On Wednesday 14 May 2014 20:42:16 Sebastian Hesselbarth wrote: For the driver, Antoine then would have to squeeze all PHY register mangling in phy-berlin2.c and see how to make ahci-platform aware of individual port nodes (I haven't looked up if it

Re: [PATCH v3 1/6] phy: add a driver for the Berlin SATA PHY

2014-05-14 Thread Arnd Bergmann
On Wednesday 14 May 2014 20:56:29 Sebastian Hesselbarth wrote: On 05/14/2014 08:51 PM, Arnd Bergmann wrote: On Wednesday 14 May 2014 20:42:16 Sebastian Hesselbarth wrote: For the driver, Antoine then would have to squeeze all PHY register mangling in phy-berlin2.c and see how to make