Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-14 Thread Hannes Reinecke
On 07/10/2017 09:06 AM, Yijing Wang wrote: > Now libsas hotplug work is static, every sas event type has its own > static work, LLDD driver queue the hotplug work into shost->work_q. > If LLDD driver burst post lots hotplug events to libsas, the hotplug > events may pending in the workqueue like >

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-14 Thread Hannes Reinecke
On 07/10/2017 09:06 AM, Yijing Wang wrote: > Now libsas hotplug work is static, every sas event type has its own > static work, LLDD driver queue the hotplug work into shost->work_q. > If LLDD driver burst post lots hotplug events to libsas, the hotplug > events may pending in the workqueue like >

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread wangyijing
There is no special meaning for the pool size, if flutter of > 25 events, notify sas events will return error, and the further step work is depending on LLDD drivers. I hope libsas could do more work in this case, but now it seems a little difficult, this patch may be a

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread wangyijing
There is no special meaning for the pool size, if flutter of > 25 events, notify sas events will return error, and the further step work is depending on LLDD drivers. I hope libsas could do more work in this case, but now it seems a little difficult, this patch may be a

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread John Garry
On 12/07/2017 09:47, wangyijing wrote: 在 2017/7/12 16:17, John Garry 写道: On 12/07/2017 03:06, wangyijing wrote: -unsigned long port_events_pending; -unsigned long phy_events_pending; +struct asd_sas_event port_events[PORT_POOL_SIZE]; +struct asd_sas_event

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread John Garry
On 12/07/2017 09:47, wangyijing wrote: 在 2017/7/12 16:17, John Garry 写道: On 12/07/2017 03:06, wangyijing wrote: -unsigned long port_events_pending; -unsigned long phy_events_pending; +struct asd_sas_event port_events[PORT_POOL_SIZE]; +struct asd_sas_event

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread wangyijing
在 2017/7/12 16:17, John Garry 写道: > On 12/07/2017 03:06, wangyijing wrote: -unsigned long port_events_pending; -unsigned long phy_events_pending; +struct asd_sas_event port_events[PORT_POOL_SIZE]; +struct asd_sas_event phy_events[PHY_POOL_SIZE];

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread wangyijing
在 2017/7/12 16:17, John Garry 写道: > On 12/07/2017 03:06, wangyijing wrote: -unsigned long port_events_pending; -unsigned long phy_events_pending; +struct asd_sas_event port_events[PORT_POOL_SIZE]; +struct asd_sas_event phy_events[PHY_POOL_SIZE];

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread John Garry
On 12/07/2017 03:06, wangyijing wrote: -unsigned long port_events_pending; -unsigned long phy_events_pending; +struct asd_sas_event port_events[PORT_POOL_SIZE]; +struct asd_sas_event phy_events[PHY_POOL_SIZE]; int error; Hi Yijing, So now we are creating a static

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-12 Thread John Garry
On 12/07/2017 03:06, wangyijing wrote: -unsigned long port_events_pending; -unsigned long phy_events_pending; +struct asd_sas_event port_events[PORT_POOL_SIZE]; +struct asd_sas_event phy_events[PHY_POOL_SIZE]; int error; Hi Yijing, So now we are creating a static

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-11 Thread wangyijing
>> -unsigned long port_events_pending; >> -unsigned long phy_events_pending; >> +struct asd_sas_event port_events[PORT_POOL_SIZE]; >> +struct asd_sas_event phy_events[PHY_POOL_SIZE]; >> >> int error; > > Hi Yijing, > > So now we are creating a static pool of events per

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-11 Thread wangyijing
>> -unsigned long port_events_pending; >> -unsigned long phy_events_pending; >> +struct asd_sas_event port_events[PORT_POOL_SIZE]; >> +struct asd_sas_event phy_events[PHY_POOL_SIZE]; >> >> int error; > > Hi Yijing, > > So now we are creating a static pool of events per

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-11 Thread John Garry
On 10/07/2017 08:06, Yijing Wang wrote: Now libsas hotplug work is static, every sas event type has its own static work, LLDD driver queue the hotplug work into shost->work_q. If LLDD driver burst post lots hotplug events to libsas, the hotplug events may pending in the workqueue like

Re: [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-11 Thread John Garry
On 10/07/2017 08:06, Yijing Wang wrote: Now libsas hotplug work is static, every sas event type has its own static work, LLDD driver queue the hotplug work into shost->work_q. If LLDD driver burst post lots hotplug events to libsas, the hotplug events may pending in the workqueue like

[PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-10 Thread Yijing Wang
Now libsas hotplug work is static, every sas event type has its own static work, LLDD driver queue the hotplug work into shost->work_q. If LLDD driver burst post lots hotplug events to libsas, the hotplug events may pending in the workqueue like shost->work_q new work[PORTE_BYTES_DMAED] -->

[PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost

2017-07-10 Thread Yijing Wang
Now libsas hotplug work is static, every sas event type has its own static work, LLDD driver queue the hotplug work into shost->work_q. If LLDD driver burst post lots hotplug events to libsas, the hotplug events may pending in the workqueue like shost->work_q new work[PORTE_BYTES_DMAED] -->