Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-30 Thread Dan Murphy
Pavel On 5/30/19 2:40 PM, Pavel Machek wrote: On Tue 2019-05-28 06:34:47, Dan Murphy wrote: Pavel On 5/27/19 7:45 PM, Dan Murphy wrote: Pavel On 5/27/19 5:33 AM, Pavel Machek wrote: On Thu 2019-05-23 14:08:12, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-30 Thread Pavel Machek
On Tue 2019-05-28 06:34:47, Dan Murphy wrote: > Pavel > > On 5/27/19 7:45 PM, Dan Murphy wrote: > >Pavel > > > >On 5/27/19 5:33 AM, Pavel Machek wrote: > >>On Thu 2019-05-23 14:08:12, Dan Murphy wrote: > >>>Add a documentation of LED Multicolor LED class specific > >>>sysfs attributes. > >>> >

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-30 Thread Dan Murphy
Jacek On 5/28/19 1:29 PM, Jacek Anaszewski wrote: On 5/28/19 8:19 PM, Dan Murphy wrote: Jacek On 5/28/19 12:44 PM, Jacek Anaszewski wrote: Dan, On 5/28/19 7:32 PM, Dan Murphy wrote: Jacek On 5/27/19 3:00 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the update. One thing is missing

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-28 Thread Jacek Anaszewski
On 5/28/19 8:19 PM, Dan Murphy wrote: Jacek On 5/28/19 12:44 PM, Jacek Anaszewski wrote: Dan, On 5/28/19 7:32 PM, Dan Murphy wrote: Jacek On 5/27/19 3:00 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the update. One thing is missing here - we need to document how legacy brightness

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-28 Thread Dan Murphy
Jacek On 5/28/19 12:44 PM, Jacek Anaszewski wrote: Dan, On 5/28/19 7:32 PM, Dan Murphy wrote: Jacek On 5/27/19 3:00 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the update. One thing is missing here - we need to document how legacy brightness levels map to the sub-LED color levels,

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-28 Thread Jacek Anaszewski
Dan, On 5/28/19 7:32 PM, Dan Murphy wrote: Jacek On 5/27/19 3:00 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the update. One thing is missing here - we need to document how legacy brightness levels map to the sub-LED color levels, i.e. what you do in multicolor_set_brightness(). Ok

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-28 Thread Dan Murphy
Jacek On 5/27/19 3:00 PM, Jacek Anaszewski wrote: Hi Dan, Thank you for the update. One thing is missing here - we need to document how legacy brightness levels map to the sub-LED color levels, i.e. what you do in multicolor_set_brightness(). Ok so i will need to document the algorithm

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-28 Thread Dan Murphy
Pavel On 5/27/19 7:45 PM, Dan Murphy wrote: Pavel On 5/27/19 5:33 AM, Pavel Machek wrote: On Thu 2019-05-23 14:08:12, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs attributes. Signed-off-by: Dan Murphy ---   .../ABI/testing/sysfs-class-led-multicolor    |

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-27 Thread Dan Murphy
Pavel On 5/27/19 5:33 AM, Pavel Machek wrote: On Thu 2019-05-23 14:08:12, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs attributes. Signed-off-by: Dan Murphy --- .../ABI/testing/sysfs-class-led-multicolor| 57 +++ 1 file changed, 57

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-27 Thread Jacek Anaszewski
Hi Dan, Thank you for the update. One thing is missing here - we need to document how legacy brightness levels map to the sub-LED color levels, i.e. what you do in multicolor_set_brightness(). Best regards, Jacek Anaszewski On 5/23/19 9:08 PM, Dan Murphy wrote: Add a documentation of LED

Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-27 Thread Pavel Machek
On Thu 2019-05-23 14:08:12, Dan Murphy wrote: > Add a documentation of LED Multicolor LED class specific > sysfs attributes. > > Signed-off-by: Dan Murphy > --- > .../ABI/testing/sysfs-class-led-multicolor| 57 +++ > 1 file changed, 57 insertions(+) > create mode 100644

[PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

2019-05-23 Thread Dan Murphy
Add a documentation of LED Multicolor LED class specific sysfs attributes. Signed-off-by: Dan Murphy --- .../ABI/testing/sysfs-class-led-multicolor| 57 +++ 1 file changed, 57 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor diff --git