Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Vladimir, Am Freitag, den 29.05.2015, 14:31 +0300 schrieb Vladimir Zapolskiy: [...] > > res->start is of type phys_addr_t (well, resource_size_t) already. > > block->start/size and cur_start/size are just offsets added to it. > > I agree. > > > I wonder if it wouldn't be more appropriate to

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Philipp, On 26.05.2015 11:54, Philipp Zabel wrote: > Hi Vladimir, > > Am Sonntag, den 24.05.2015, 23:12 +0300 schrieb Vladimir Zapolskiy: >> Hi Philipp, >> >> On 20.05.2015 14:30, Philipp Zabel wrote: >>> Hi Vladimir, >>> >>> Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Philipp, On 26.05.2015 11:54, Philipp Zabel wrote: Hi Vladimir, Am Sonntag, den 24.05.2015, 23:12 +0300 schrieb Vladimir Zapolskiy: Hi Philipp, On 20.05.2015 14:30, Philipp Zabel wrote: Hi Vladimir, Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: Hi Philipp,

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Vladimir, Am Freitag, den 29.05.2015, 14:31 +0300 schrieb Vladimir Zapolskiy: [...] res-start is of type phys_addr_t (well, resource_size_t) already. block-start/size and cur_start/size are just offsets added to it. I agree. I wonder if it wouldn't be more appropriate to use

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Vladimir, Am Sonntag, den 24.05.2015, 23:12 +0300 schrieb Vladimir Zapolskiy: > Hi Philipp, > > On 20.05.2015 14:30, Philipp Zabel wrote: > > Hi Vladimir, > > > > Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: > >> Hi Philipp, > >> > >> On 19.05.2015 13:41, Philipp

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Vladimir, Am Sonntag, den 24.05.2015, 23:12 +0300 schrieb Vladimir Zapolskiy: Hi Philipp, On 20.05.2015 14:30, Philipp Zabel wrote: Hi Vladimir, Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: Hi Philipp, On 19.05.2015 13:41, Philipp Zabel wrote: Am

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Philipp, On 20.05.2015 14:30, Philipp Zabel wrote: > Hi Vladimir, > > Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: >> Hi Philipp, >> >> On 19.05.2015 13:41, Philipp Zabel wrote: >>> Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: If

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Philipp, On 20.05.2015 14:30, Philipp Zabel wrote: Hi Vladimir, Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: Hi Philipp, On 19.05.2015 13:41, Philipp Zabel wrote: Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: If devm_gen_pool_create()

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Vladimir, Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: > Hi Philipp, > > On 19.05.2015 13:41, Philipp Zabel wrote: > > Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: > >> If devm_gen_pool_create() fails, the previously enabled sram->clk is > >> not

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Vladimir, Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: Hi Philipp, On 19.05.2015 13:41, Philipp Zabel wrote: Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: If devm_gen_pool_create() fails, the previously enabled sram-clk is not disabled on

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Philipp, On 19.05.2015 13:41, Philipp Zabel wrote: > Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: >> If devm_gen_pool_create() fails, the previously enabled sram->clk is >> not disabled on probe() exit. >> >> Signed-off-by: Vladimir Zapolskiy >> --- >>

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: > If devm_gen_pool_create() fails, the previously enabled sram->clk is > not disabled on probe() exit. > > Signed-off-by: Vladimir Zapolskiy > --- > drivers/misc/sram.c | 9 + > 1 file changed, 5 insertions(+), 4

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: If devm_gen_pool_create() fails, the previously enabled sram-clk is not disabled on probe() exit. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com --- drivers/misc/sram.c | 9 + 1 file changed, 5

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

Hi Philipp, On 19.05.2015 13:41, Philipp Zabel wrote: Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: If devm_gen_pool_create() fails, the previously enabled sram-clk is not disabled on probe() exit. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com ---

[PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

If devm_gen_pool_create() fails, the previously enabled sram->clk is not disabled on probe() exit. Signed-off-by: Vladimir Zapolskiy --- drivers/misc/sram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c index

[PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

If devm_gen_pool_create() fails, the previously enabled sram-clk is not disabled on probe() exit. Signed-off-by: Vladimir Zapolskiy vladimir_zapols...@mentor.com --- drivers/misc/sram.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/sram.c