Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-20 Thread Cornelia Huck
On Tue, 19 Feb 2019 17:27:05 -0500 Tony Krowiak wrote: > On 2/18/19 11:57 AM, Cornelia Huck wrote: > > On Mon, 18 Feb 2019 11:35:45 -0500 > > Tony Krowiak wrote: > > > >> On 2/18/19 7:01 AM, Cornelia Huck wrote: > >>> On Fri, 15 Feb 2019 16:59:33 -0500 > >>> Tony Krowiak wrote: > >>>

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-19 Thread Tony Krowiak
On 2/18/19 11:57 AM, Cornelia Huck wrote: On Mon, 18 Feb 2019 11:35:45 -0500 Tony Krowiak wrote: On 2/18/19 7:01 AM, Cornelia Huck wrote: On Fri, 15 Feb 2019 16:59:33 -0500 Tony Krowiak wrote: On 2/15/19 4:11 AM, Cornelia Huck wrote: On Thu, 14 Feb 2019 13:30:59 -0500 Tony Krowiak

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-18 Thread Cornelia Huck
On Mon, 18 Feb 2019 11:35:45 -0500 Tony Krowiak wrote: > On 2/18/19 7:01 AM, Cornelia Huck wrote: > > On Fri, 15 Feb 2019 16:59:33 -0500 > > Tony Krowiak wrote: > > > >> On 2/15/19 4:11 AM, Cornelia Huck wrote: > >>> On Thu, 14 Feb 2019 13:30:59 -0500 > >>> Tony Krowiak wrote: > >>>

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-18 Thread Tony Krowiak
On 2/18/19 7:01 AM, Cornelia Huck wrote: On Fri, 15 Feb 2019 16:59:33 -0500 Tony Krowiak wrote: On 2/15/19 4:11 AM, Cornelia Huck wrote: On Thu, 14 Feb 2019 13:30:59 -0500 Tony Krowiak wrote: On 2/14/19 12:36 PM, Pierre Morel wrote: On 14/02/2019 17:57, Cornelia Huck wrote: (And

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-18 Thread Cornelia Huck
On Fri, 15 Feb 2019 16:59:33 -0500 Tony Krowiak wrote: > On 2/15/19 4:11 AM, Cornelia Huck wrote: > > On Thu, 14 Feb 2019 13:30:59 -0500 > > Tony Krowiak wrote: > > > >> On 2/14/19 12:36 PM, Pierre Morel wrote: > >>> On 14/02/2019 17:57, Cornelia Huck wrote: > (And reading further

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-15 Thread Tony Krowiak
On 2/15/19 4:11 AM, Cornelia Huck wrote: On Thu, 14 Feb 2019 13:30:59 -0500 Tony Krowiak wrote: On 2/14/19 12:36 PM, Pierre Morel wrote: On 14/02/2019 17:57, Cornelia Huck wrote: On Thu, 14 Feb 2019 16:47:30 +0100 Pierre Morel wrote: On 14/02/2019 15:54, Cornelia Huck wrote: On Thu,

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-15 Thread Cornelia Huck
On Thu, 14 Feb 2019 13:30:59 -0500 Tony Krowiak wrote: > On 2/14/19 12:36 PM, Pierre Morel wrote: > > On 14/02/2019 17:57, Cornelia Huck wrote: > >> On Thu, 14 Feb 2019 16:47:30 +0100 Pierre Morel > >> wrote: > >> > >>> On 14/02/2019 15:54, Cornelia Huck wrote: > On Thu, 14 Feb 2019

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Tony Krowiak
On 2/14/19 12:36 PM, Pierre Morel wrote: On 14/02/2019 17:57, Cornelia Huck wrote: On Thu, 14 Feb 2019 16:47:30 +0100 Pierre Morel wrote: On 14/02/2019 15:54, Cornelia Huck wrote: On Thu, 14 Feb 2019 14:51:01 +0100 Pierre Morel wrote: +++ b/drivers/s390/crypto/vfio_ap_drv.c @@ -24,8

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Pierre Morel
On 14/02/2019 17:57, Cornelia Huck wrote: On Thu, 14 Feb 2019 16:47:30 +0100 Pierre Morel wrote: On 14/02/2019 15:54, Cornelia Huck wrote: On Thu, 14 Feb 2019 14:51:01 +0100 Pierre Morel wrote: +++ b/drivers/s390/crypto/vfio_ap_drv.c @@ -24,8 +24,9 @@ MODULE_LICENSE("GPL v2"); static

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Pierre Morel
On 14/02/2019 16:05, Christian Borntraeger wrote: On 14.02.2019 15:54, Cornelia Huck wrote: On Thu, 14 Feb 2019 14:51:01 +0100 Pierre Morel wrote: Pierre, this is independent from this series and should have been sent separately. In the end (when we have the final solution) this will require

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Tony Krowiak
On 2/14/19 10:05 AM, Christian Borntraeger wrote: On 14.02.2019 15:54, Cornelia Huck wrote: On Thu, 14 Feb 2019 14:51:01 +0100 Pierre Morel wrote: Pierre, this is independent from this series and should have been sent separately. In the end (when we have the final solution) this will require

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Cornelia Huck
On Thu, 14 Feb 2019 16:47:30 +0100 Pierre Morel wrote: > On 14/02/2019 15:54, Cornelia Huck wrote: > > On Thu, 14 Feb 2019 14:51:01 +0100 > > Pierre Morel wrote: > >> +++ b/drivers/s390/crypto/vfio_ap_drv.c > >> @@ -24,8 +24,9 @@ MODULE_LICENSE("GPL v2"); > >> > >> static struct ap_driver

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Pierre Morel
On 14/02/2019 15:54, Cornelia Huck wrote: On Thu, 14 Feb 2019 14:51:01 +0100 Pierre Morel wrote: Libudev relies on having a subsystem link for non-root devices. To avoid libudev (and potentially other userspace tools) choking on the matrix device let us introduce a vfio_ap bus and with that

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Cornelia Huck
On Thu, 14 Feb 2019 16:05:35 +0100 Christian Borntraeger wrote: > On 14.02.2019 15:54, Cornelia Huck wrote: > > On Thu, 14 Feb 2019 14:51:01 +0100 > > Pierre Morel wrote: > > Pierre, > this is independent from this series and should have been sent separately. > In the end (when we have the

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Pierre Morel
On 14/02/2019 16:01, Christian Borntraeger wrote: On 14.02.2019 14:51, Pierre Morel wrote: Libudev relies on having a subsystem link for non-root devices. To avoid libudev (and potentially other userspace tools) choking on the matrix device let us introduce a vfio_ap bus and with that the

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Christian Borntraeger
On 14.02.2019 15:54, Cornelia Huck wrote: > On Thu, 14 Feb 2019 14:51:01 +0100 > Pierre Morel wrote: Pierre, this is independent from this series and should have been sent separately. In the end (when we have the final solution) this will require cc stable. > >> Libudev relies on having a

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Christian Borntraeger
On 14.02.2019 14:51, Pierre Morel wrote: > Libudev relies on having a subsystem link for non-root devices. To > avoid libudev (and potentially other userspace tools) choking on the > matrix device let us introduce a vfio_ap bus and with that the vfio_ap > bus subsytem, and make the matrix

Re: [PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Cornelia Huck
On Thu, 14 Feb 2019 14:51:01 +0100 Pierre Morel wrote: > Libudev relies on having a subsystem link for non-root devices. To > avoid libudev (and potentially other userspace tools) choking on the > matrix device let us introduce a vfio_ap bus and with that the vfio_ap > bus subsytem, and make the

[PATCH v3 1/9] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-14 Thread Pierre Morel
Libudev relies on having a subsystem link for non-root devices. To avoid libudev (and potentially other userspace tools) choking on the matrix device let us introduce a vfio_ap bus and with that the vfio_ap bus subsytem, and make the matrix device reside within it. We restrict the number of