2015-03-27 12:32 GMT+01:00 Peter Hurley :
> On 03/26/2015 06:03 PM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+ struct ktermios *old)
+{
+ unsigned int baud;
+ u32 usardiv,
On 03/26/2015 06:03 PM, Maxime Coquelin wrote:
>>> +static void stm32_set_termios(struct uart_port *port, struct ktermios
>>> *termios,
>>> + struct ktermios *old)
>>> +{
>>> + unsigned int baud;
>>> + u32 usardiv, mantissa, fraction;
>>> + tcflag_t cflag;
>>>
On 03/26/2015 06:03 PM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+ struct ktermios *old)
+{
+ unsigned int baud;
+ u32 usardiv, mantissa, fraction;
+ tcflag_t cflag;
+ u32 cr1, cr2, cr3;
2015-03-27 12:32 GMT+01:00 Peter Hurley pe...@hurleysoftware.com:
On 03/26/2015 06:03 PM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+ struct ktermios *old)
+{
+ unsigned int baud;
+ u32 usardiv,
2015-03-26 16:46 GMT+01:00 Russell King - ARM Linux :
> On Tue, Mar 24, 2015 at 02:23:38PM -0400, Peter Hurley wrote:
>> Hi Maxime,
>>
>> On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
>> > +static unsigned int stm32_get_mctrl(struct uart_port *port)
>> > +{
>> > + /*
>> > +* This routine is
HI Peter
2015-03-24 19:23 GMT+01:00 Peter Hurley :
> Hi Maxime,
>
> On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
>> From: Maxime Coquelin
>>
>> This drivers adds support to the STM32 USART controller, which is a
>> standard serial driver.
>
> Comments below.
Thanks for the review, please find
On Tue, Mar 24, 2015 at 02:23:38PM -0400, Peter Hurley wrote:
> Hi Maxime,
>
> On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
> > +static unsigned int stm32_get_mctrl(struct uart_port *port)
> > +{
> > + /*
> > +* This routine is used for geting signals of: DTR, DCD, DSR, RI,
> > +* and
HI Peter
2015-03-24 19:23 GMT+01:00 Peter Hurley pe...@hurleysoftware.com:
Hi Maxime,
On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
From: Maxime Coquelin mcoquelin.st...@gmail.com
This drivers adds support to the STM32 USART controller, which is a
standard serial driver.
Comments below.
2015-03-26 16:46 GMT+01:00 Russell King - ARM Linux li...@arm.linux.org.uk:
On Tue, Mar 24, 2015 at 02:23:38PM -0400, Peter Hurley wrote:
Hi Maxime,
On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
+static unsigned int stm32_get_mctrl(struct uart_port *port)
+{
+ /*
+* This routine
On Tue, Mar 24, 2015 at 02:23:38PM -0400, Peter Hurley wrote:
Hi Maxime,
On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
+static unsigned int stm32_get_mctrl(struct uart_port *port)
+{
+ /*
+* This routine is used for geting signals of: DTR, DCD, DSR, RI,
+* and CTS/RTS
Hi Maxime,
On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
> From: Maxime Coquelin
>
> This drivers adds support to the STM32 USART controller, which is a
> standard serial driver.
Comments below.
> Signed-off-by: Maxime Coquelin
> ---
> drivers/tty/serial/Kconfig | 17 +
>
Hi Maxime,
On 03/24/2015 01:21 PM, Maxime Coquelin wrote:
> Hi Peter,
>
> 2015-03-19 18:35 GMT+01:00 Maxime Coquelin :
>> 2015-03-19 15:58 GMT+01:00 Peter Hurley :
>>> On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
Hi Peter,
2015-03-19 18:35 GMT+01:00 Maxime Coquelin :
> 2015-03-19 15:58 GMT+01:00 Peter Hurley :
>> On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
>>> +static void stm32_set_termios(struct uart_port *port, struct ktermios
>>> *termios,
>>> + struct
Hi Peter,
2015-03-19 18:35 GMT+01:00 Maxime Coquelin mcoquelin.st...@gmail.com:
2015-03-19 15:58 GMT+01:00 Peter Hurley pe...@hurleysoftware.com:
On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+
Hi Maxime,
On 03/12/2015 05:55 PM, Maxime Coquelin wrote:
From: Maxime Coquelin mcoquelin.st...@gmail.com
This drivers adds support to the STM32 USART controller, which is a
standard serial driver.
Comments below.
Signed-off-by: Maxime Coquelin mcoquelin.st...@gmail.com
---
Hi Maxime,
On 03/24/2015 01:21 PM, Maxime Coquelin wrote:
Hi Peter,
2015-03-19 18:35 GMT+01:00 Maxime Coquelin mcoquelin.st...@gmail.com:
2015-03-19 15:58 GMT+01:00 Peter Hurley pe...@hurleysoftware.com:
On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct
2015-03-19 15:58 GMT+01:00 Peter Hurley :
> On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
>> +static void stm32_set_termios(struct uart_port *port, struct ktermios
>> *termios,
>> + struct ktermios *old)
> [...]
>> + usardiv = (port->uartclk * 25)
On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
> +static void stm32_set_termios(struct uart_port *port, struct ktermios
> *termios,
> + struct ktermios *old)
[...]
> + usardiv = (port->uartclk * 25) / (baud * 4);
> + mantissa = (usardiv /
2015-03-17 18:56 GMT+01:00 Andy Shevchenko :
> On Tue, Mar 17, 2015 at 7:32 PM, Maxime Coquelin
> wrote:
>> 2015-03-13 15:19 GMT+01:00 Andy Shevchenko :
>
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+ struct ktermios
2015-03-17 18:56 GMT+01:00 Andy Shevchenko andy.shevche...@gmail.com:
On Tue, Mar 17, 2015 at 7:32 PM, Maxime Coquelin
mcoquelin.st...@gmail.com wrote:
2015-03-13 15:19 GMT+01:00 Andy Shevchenko andy.shevche...@gmail.com:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
2015-03-19 15:58 GMT+01:00 Peter Hurley pe...@hurleysoftware.com:
On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+ struct ktermios *old)
[...]
+ usardiv = (port-uartclk * 25) /
On 03/19/2015 09:55 AM, Maxime Coquelin wrote:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+ struct ktermios *old)
[...]
+ usardiv = (port-uartclk * 25) / (baud * 4);
+ mantissa = (usardiv / 100)
On Tue, Mar 17, 2015 at 7:32 PM, Maxime Coquelin
wrote:
> 2015-03-13 15:19 GMT+01:00 Andy Shevchenko :
>>> +static void stm32_set_termios(struct uart_port *port, struct ktermios
>>> *termios,
>>> + struct ktermios *old)
>>> +{
>>> + unsigned int baud;
>>> +
2015-03-13 10:41 GMT+01:00 Paul Bolle :
> Just a license nit, I'm afraid.
Not a problem, it is not the last round anyway.
>
> On Thu, 2015-03-12 at 22:55 +0100, Maxime Coquelin wrote:
>> --- /dev/null
>> +++ b/drivers/tty/serial/stm32-usart.c
>> @@ -0,0 +1,695 @@
>> +/*
>> + * Copyright (C)
2015-03-13 15:19 GMT+01:00 Andy Shevchenko :
> On Thu, Mar 12, 2015 at 11:55 PM, Maxime Coquelin
> wrote:
>> From: Maxime Coquelin
>>
>> This drivers adds support to the STM32 USART controller, which is a
>> standard serial driver.
>
> My comment below.
>
>>
>> Signed-off-by: Maxime Coquelin
>>
2015-03-13 10:41 GMT+01:00 Paul Bolle pebo...@tiscali.nl:
Just a license nit, I'm afraid.
Not a problem, it is not the last round anyway.
On Thu, 2015-03-12 at 22:55 +0100, Maxime Coquelin wrote:
--- /dev/null
+++ b/drivers/tty/serial/stm32-usart.c
@@ -0,0 +1,695 @@
+/*
+ * Copyright (C)
2015-03-13 15:19 GMT+01:00 Andy Shevchenko andy.shevche...@gmail.com:
On Thu, Mar 12, 2015 at 11:55 PM, Maxime Coquelin
mcoquelin.st...@gmail.com wrote:
From: Maxime Coquelin mcoquelin.st...@gmail.com
This drivers adds support to the STM32 USART controller, which is a
standard serial driver.
On Tue, Mar 17, 2015 at 7:32 PM, Maxime Coquelin
mcoquelin.st...@gmail.com wrote:
2015-03-13 15:19 GMT+01:00 Andy Shevchenko andy.shevche...@gmail.com:
+static void stm32_set_termios(struct uart_port *port, struct ktermios
*termios,
+ struct ktermios *old)
+{
+
On Thu, Mar 12, 2015 at 11:55 PM, Maxime Coquelin
wrote:
> From: Maxime Coquelin
>
> This drivers adds support to the STM32 USART controller, which is a
> standard serial driver.
My comment below.
>
> Signed-off-by: Maxime Coquelin
> ---
> drivers/tty/serial/Kconfig | 17 +
>
Just a license nit, I'm afraid.
On Thu, 2015-03-12 at 22:55 +0100, Maxime Coquelin wrote:
> --- /dev/null
> +++ b/drivers/tty/serial/stm32-usart.c
> @@ -0,0 +1,695 @@
> +/*
> + * Copyright (C) Maxime Coquelin 2015
> + * Author: Maxime Coquelin
> + * License terms: GNU General Public License
Just a license nit, I'm afraid.
On Thu, 2015-03-12 at 22:55 +0100, Maxime Coquelin wrote:
--- /dev/null
+++ b/drivers/tty/serial/stm32-usart.c
@@ -0,0 +1,695 @@
+/*
+ * Copyright (C) Maxime Coquelin 2015
+ * Author: Maxime Coquelin mcoquelin.st...@gmail.com
+ * License terms: GNU General
On Thu, Mar 12, 2015 at 11:55 PM, Maxime Coquelin
mcoquelin.st...@gmail.com wrote:
From: Maxime Coquelin mcoquelin.st...@gmail.com
This drivers adds support to the STM32 USART controller, which is a
standard serial driver.
My comment below.
Signed-off-by: Maxime Coquelin
From: Maxime Coquelin
This drivers adds support to the STM32 USART controller, which is a
standard serial driver.
Signed-off-by: Maxime Coquelin
---
drivers/tty/serial/Kconfig | 17 +
drivers/tty/serial/Makefile | 1 +
drivers/tty/serial/stm32-usart.c | 695
From: Maxime Coquelin mcoquelin.st...@gmail.com
This drivers adds support to the STM32 USART controller, which is a
standard serial driver.
Signed-off-by: Maxime Coquelin mcoquelin.st...@gmail.com
---
drivers/tty/serial/Kconfig | 17 +
drivers/tty/serial/Makefile | 1 +
34 matches
Mail list logo
