Re: [PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success

2016-07-18 Thread Vlastimil Babka
On 07/06/2016 07:47 AM, Joonsoo Kim wrote: On Fri, Jun 24, 2016 at 11:54:33AM +0200, Vlastimil Babka wrote: The __compact_finished() function uses low watermark in a check that has to pass if the direct compaction is to finish and allocation should succeed. This is too pessimistic, as the

Re: [PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success

2016-07-18 Thread Vlastimil Babka
On 07/06/2016 07:47 AM, Joonsoo Kim wrote: On Fri, Jun 24, 2016 at 11:54:33AM +0200, Vlastimil Babka wrote: The __compact_finished() function uses low watermark in a check that has to pass if the direct compaction is to finish and allocation should succeed. This is too pessimistic, as the

Re: [PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success

2016-07-05 Thread Joonsoo Kim
On Fri, Jun 24, 2016 at 11:54:33AM +0200, Vlastimil Babka wrote: > The __compact_finished() function uses low watermark in a check that has to > pass if the direct compaction is to finish and allocation should succeed. This > is too pessimistic, as the allocation will typically use min watermark.

Re: [PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success

2016-07-05 Thread Joonsoo Kim
On Fri, Jun 24, 2016 at 11:54:33AM +0200, Vlastimil Babka wrote: > The __compact_finished() function uses low watermark in a check that has to > pass if the direct compaction is to finish and allocation should succeed. This > is too pessimistic, as the allocation will typically use min watermark.

[PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success

2016-06-24 Thread Vlastimil Babka
The __compact_finished() function uses low watermark in a check that has to pass if the direct compaction is to finish and allocation should succeed. This is too pessimistic, as the allocation will typically use min watermark. It may happen that during compaction, we drop below the low watermark

[PATCH v3 13/17] mm, compaction: use correct watermark when checking allocation success

2016-06-24 Thread Vlastimil Babka
The __compact_finished() function uses low watermark in a check that has to pass if the direct compaction is to finish and allocation should succeed. This is too pessimistic, as the allocation will typically use min watermark. It may happen that during compaction, we drop below the low watermark