Re: [PATCH v3 16/33] tracing: Generalize per-element hist trigger data

2017-10-04 Thread Tom Zanussi
On Wed, 2017-10-04 at 13:34 -0400, Steven Rostedt wrote: > On Fri, 22 Sep 2017 14:59:56 -0500 > Tom Zanussi wrote: > > > @@ -1742,7 +1746,8 @@ static void hist_trigger_stacktrace_print(struct > > seq_file *m, > > seq_printf(m, "%s: [%llx] %-55s", field_name, > >

Re: [PATCH v3 16/33] tracing: Generalize per-element hist trigger data

2017-10-04 Thread Steven Rostedt
On Fri, 22 Sep 2017 14:59:56 -0500 Tom Zanussi wrote: > @@ -1742,7 +1746,8 @@ static void hist_trigger_stacktrace_print(struct > seq_file *m, > seq_printf(m, "%s: [%llx] %-55s", field_name, > uval, str); > } else if (key_field-

[PATCH v3 16/33] tracing: Generalize per-element hist trigger data

2017-09-22 Thread Tom Zanussi
Up until now, hist triggers only needed per-element support for saving 'comm' data, which was saved directly as a private data pointer. In anticipation of the need to save other data besides 'comm', add a new hist_elt_data struct for the purpose, and switch the current 'comm'-related code over to