Re: [PATCH v3 17/28] scsi: pm_8001: Drop PCI Wakeup calls from .resume

2020-10-01 Thread Jinpu Wang
On Thu, Oct 1, 2020 at 2:30 PM Vaibhav Gupta wrote: > > The driver calls pci_enable_wake(, false) in pm8001_pci_resume(), and > there is no corresponding pci_enable_wake(, true) in > pm8001_pci_suspend(). Either it should do enable-wake the device in > .suspend() or should not invoke

[PATCH v3 17/28] scsi: pm_8001: Drop PCI Wakeup calls from .resume

2020-10-01 Thread Vaibhav Gupta
The driver calls pci_enable_wake(, false) in pm8001_pci_resume(), and there is no corresponding pci_enable_wake(, true) in pm8001_pci_suspend(). Either it should do enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all. Concluding that this driver doesn't