Re: [PATCH v3 18/20] tpm: use u32 instead of int for pcr index

2018-09-19 Thread Jarkko Sakkinen
On Tue, Sep 18, 2018 at 12:34:57PM +0300, Tomas Winkler wrote: > TPM pcr indices cannot be negative, also the tpm > commands accept u32 number as a pcr index. > > 1. Adjust the API to use u32 instead of int in all pcr related > functions. NAK. > 2. Rename tpm1_pcr_read_dev to tpm1_pcr_read() to

Re: [PATCH v3 18/20] tpm: use u32 instead of int for pcr index

2018-09-19 Thread Jarkko Sakkinen
On Tue, Sep 18, 2018 at 12:34:57PM +0300, Tomas Winkler wrote: > TPM pcr indices cannot be negative, also the tpm > commands accept u32 number as a pcr index. > > 1. Adjust the API to use u32 instead of int in all pcr related > functions. NAK. > 2. Rename tpm1_pcr_read_dev to tpm1_pcr_read() to

[PATCH v3 18/20] tpm: use u32 instead of int for pcr index

2018-09-18 Thread Tomas Winkler
TPM pcr indices cannot be negative, also the tpm commands accept u32 number as a pcr index. 1. Adjust the API to use u32 instead of int in all pcr related functions. 2. Rename tpm1_pcr_read_dev to tpm1_pcr_read() to match the counterpart tpm2_pcr_read() 3. Remove redundant constants in

[PATCH v3 18/20] tpm: use u32 instead of int for pcr index

2018-09-18 Thread Tomas Winkler
TPM pcr indices cannot be negative, also the tpm commands accept u32 number as a pcr index. 1. Adjust the API to use u32 instead of int in all pcr related functions. 2. Rename tpm1_pcr_read_dev to tpm1_pcr_read() to match the counterpart tpm2_pcr_read() 3. Remove redundant constants in