Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver

2016-06-16 Thread Srinivas Kandagatla
On 15/06/16 21:07, Kenneth Westfield wrote: On Wed, Jun 15, 2016 at 10:31:36AM +0100, Mark Brown wrote: On Wed, Jun 15, 2016 at 10:16:27AM +0100, Srinivas Kandagatla wrote: On 14/06/16 16:59, Mark Brown wrote: On Fri, Jun 10, 2016 at 07:18:45PM +0100, Srinivas Kandagatla wrote: In theory

Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver

2016-06-15 Thread Kenneth Westfield
On Wed, Jun 15, 2016 at 10:31:36AM +0100, Mark Brown wrote: > On Wed, Jun 15, 2016 at 10:16:27AM +0100, Srinivas Kandagatla wrote: > > On 14/06/16 16:59, Mark Brown wrote: > > > On Fri, Jun 10, 2016 at 07:18:45PM +0100, Srinivas Kandagatla wrote: > > In theory there are 3 devices, > > one is the p

Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver

2016-06-15 Thread Mark Brown
On Wed, Jun 15, 2016 at 10:16:27AM +0100, Srinivas Kandagatla wrote: > On 14/06/16 16:59, Mark Brown wrote: > > On Fri, Jun 10, 2016 at 07:18:45PM +0100, Srinivas Kandagatla wrote: > > > +config SND_SOC_MSM8916_WCD > > > + tristate "Qualcomm MSM8916 WCD" > > > + depends on SPMI && MFD_SYSCON > >

Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver

2016-06-15 Thread Srinivas Kandagatla
Thanks for review comments, On 14/06/16 16:59, Mark Brown wrote: On Fri, Jun 10, 2016 at 07:18:45PM +0100, Srinivas Kandagatla wrote: +config SND_SOC_MSM8916_WCD + tristate "Qualcomm MSM8916 WCD" + depends on SPMI && MFD_SYSCON + Normally users select MFD_SYSCON. This driver is

Re: [PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver

2016-06-14 Thread Mark Brown
On Fri, Jun 10, 2016 at 07:18:45PM +0100, Srinivas Kandagatla wrote: > +config SND_SOC_MSM8916_WCD > + tristate "Qualcomm MSM8916 WCD" > + depends on SPMI && MFD_SYSCON > + Normally users select MFD_SYSCON. > @@ -208,7 +209,6 @@ snd-soc-wm9705-objs := wm9705.o > snd-soc-wm9712-objs := w

[PATCH v3 2/2] ASoC: msm8916: Add msm8916-wcd codec driver

2016-06-10 Thread Srinivas Kandagatla
This patch adds support to msm8916-wcd codec. msm8916-wcd codec is found in Qualcomm msm8916 and apq8016 processors. This codec IP is split in to two parts(Digital & Analog), Analog part is integrated in to PMIC PM8916 and the digital part is integrated into Application processor. Register access