Re: [PATCH v3 2/2] ahci: add support for Hisilicon sata

2014-04-21 Thread Hans de Goede
Hi Kefeng, On 04/21/2014 06:13 AM, kefeng.wang wrote: > Hi Hans, > > A hflags argument is useless in ahci_platform_init_host for another driver's > caller, > use the pointer of ata_port_info in ahci_probe, is this OK? Hmm, this can theoretically break when multiple platform ahci-s are present

Re: [PATCH v3 2/2] ahci: add support for Hisilicon sata

2014-04-21 Thread Hans de Goede
Hi Kefeng, On 04/21/2014 06:13 AM, kefeng.wang wrote: Hi Hans, A hflags argument is useless in ahci_platform_init_host for another driver's caller, use the pointer of ata_port_info in ahci_probe, is this OK? Hmm, this can theoretically break when multiple platform ahci-s are present in a

Re: [PATCH v3 2/2] ahci: add support for Hisilicon sata

2014-04-20 Thread kefeng.wang
Hi Hans, A hflags argument is useless in ahci_platform_init_host for another driver's caller, use the pointer of ata_port_info in ahci_probe, is this OK? Regards, Kefeng On 2014-4-21 12:01, Kefeng Wang wrote: > The hip04 SoC of hisilicon has an AHCI compliant SATA controller, > and it is

[PATCH v3 2/2] ahci: add support for Hisilicon sata

2014-04-20 Thread Kefeng Wang
The hip04 SoC of hisilicon has an AHCI compliant SATA controller, and it is compliant with the ahci 1.3 and sata 3.0 specification. There is a wrong bit in HOST_CAP of hip04 sata controller, which enable unsupported feature of FBS, use AHCI_HFLAG_NO_FBS hflag to disable it. Cc: Hans de Geode

[PATCH v3 2/2] ahci: add support for Hisilicon sata

2014-04-20 Thread Kefeng Wang
The hip04 SoC of hisilicon has an AHCI compliant SATA controller, and it is compliant with the ahci 1.3 and sata 3.0 specification. There is a wrong bit in HOST_CAP of hip04 sata controller, which enable unsupported feature of FBS, use AHCI_HFLAG_NO_FBS hflag to disable it. Cc: Hans de Geode

Re: [PATCH v3 2/2] ahci: add support for Hisilicon sata

2014-04-20 Thread kefeng.wang
Hi Hans, A hflags argument is useless in ahci_platform_init_host for another driver's caller, use the pointer of ata_port_info in ahci_probe, is this OK? Regards, Kefeng On 2014-4-21 12:01, Kefeng Wang wrote: The hip04 SoC of hisilicon has an AHCI compliant SATA controller, and it is