Re: [PATCH v3 2/2] clocksource: arm_arch_timer: Correct fault programming of CNTKCTL_EL1.EVNTI

2020-12-05 Thread Daniel Lezcano
Hi Marc, On 05/12/2020 19:22, Marc Zyngier wrote: > Hi Daniel, > > On 2020-12-05 11:15, Daniel Lezcano wrote: >> Hi Marc, >> >> are you fine with this patch ? > > I am, although there still isn't any justification for the pos/lsb > rework in the commit message (and calling that variable lsb is

Re: [PATCH v3 2/2] clocksource: arm_arch_timer: Correct fault programming of CNTKCTL_EL1.EVNTI

2020-12-05 Thread Marc Zyngier
Hi Daniel, On 2020-12-05 11:15, Daniel Lezcano wrote: Hi Marc, are you fine with this patch ? I am, although there still isn't any justification for the pos/lsb rework in the commit message (and calling that variable lsb is somewhat confusing). If you are going to apply it, please consider ad

Re: [PATCH v3 2/2] clocksource: arm_arch_timer: Correct fault programming of CNTKCTL_EL1.EVNTI

2020-12-05 Thread Daniel Lezcano
Hi Marc, are you fine with this patch ? On 04/12/2020 08:31, Keqian Zhu wrote: > ARM virtual counter supports event stream, it can only trigger an event > when the trigger bit (the value of CNTKCTL_EL1.EVNTI) of CNTVCT_EL0 changes, > so the actual period of event stream is 2^(cntkctl_evnti +

[PATCH v3 2/2] clocksource: arm_arch_timer: Correct fault programming of CNTKCTL_EL1.EVNTI

2020-12-03 Thread Keqian Zhu
ARM virtual counter supports event stream, it can only trigger an event when the trigger bit (the value of CNTKCTL_EL1.EVNTI) of CNTVCT_EL0 changes, so the actual period of event stream is 2^(cntkctl_evnti + 1). For example, when the trigger bit is 0, then virtual counter trigger an event for every