Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Tianling Shen
Hi Pavel, On 2021-03-17 03:38, Pavel Machek wrote: > > On Tue 2021-03-16 16:34:50, Geert Uytterhoeven wrote: > > Hi Tianling, > > > > CC Jacek, Pavel > > > > On Tue, Mar 16, 2021 at 4:00 PM Tianling Shen wrote: > > > On 2021-03-16 02:23 Geert Uytterhoeven wrote: > > > > Personally, I'm not so

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Pavel Machek
On Tue 2021-03-16 16:34:50, Geert Uytterhoeven wrote: > Hi Tianling, > > CC Jacek, Pavel > > On Tue, Mar 16, 2021 at 4:00 PM Tianling Shen wrote: > > On 2021-03-16 02:23 Geert Uytterhoeven wrote: > > > Personally, I'm not so fond of the -%u node names, and prefer > > > -. With the former,

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Tianling Shen
On 2021-03-16 11:35, Geert Uytterhoeven wrote: > > Hi Tianling, > > CC Jacek, Pavel > > On Tue, Mar 16, 2021 at 4:00 PM Tianling Shen wrote: > > On 2021-03-16 02:23 Geert Uytterhoeven wrote: > > > Personally, I'm not so fond of the -%u node names, and prefer > > > -. With the former, it's way

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Geert Uytterhoeven
Hi Tianling, CC Jacek, Pavel On Tue, Mar 16, 2021 at 4:00 PM Tianling Shen wrote: > On 2021-03-16 02:23 Geert Uytterhoeven wrote: > > Personally, I'm not so fond of the -%u node names, and prefer > > -. With the former, it's way too easy to have a silent > > override in your .dts(i) stack. >

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Tianling Shen
Hi Geert, On 2021-03-16 02:23 Geert Uytterhoeven wrote: > Personally, I'm not so fond of the -%u node names, and prefer > -.  With the former, it's way too easy to have a silent > override in your .dts(i) stack. > Cfr. commit 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: > Fix

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Tianling Shen
Robin Murphy wrote: > > On 2021-03-13 13:22, CN_SZTL wrote: > > Robin Murphy 于2021年3月13日周六 下午7:55写道: > >> > >> On 2021-03-13 03:25, Tianling Shen wrote: > >>> This adds support for the NanoPi R4S from FriendlyArm. > >>> > >>> Rockchip RK3399 SoC > >>> 1GB DDR3 or 4GB LPDDR4 RAM > >>> Gigabit

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-16 Thread Tianling Shen
On 2021-03-16 12:32, Robin Murphy wrote: > > On 2021-03-13 13:22, CN_SZTL wrote: > > Robin Murphy 于2021年3月13日周六 下午7:55写道: > >> > >> On 2021-03-13 03:25, Tianling Shen wrote: > >>> This adds support for the NanoPi R4S from FriendlyArm. > >>> > >>> Rockchip RK3399 SoC > >>> 1GB DDR3 or 4GB LPDDR4

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-15 Thread Geert Uytterhoeven
Hi Heiko, On Mon, Mar 15, 2021 at 5:52 PM Heiko Stübner wrote: > Am Montag, 15. März 2021, 17:38:37 CET schrieb Geert Uytterhoeven: > > On Mon, Mar 15, 2021 at 5:32 PM Robin Murphy wrote: > > > On 2021-03-13 13:22, CN_SZTL wrote: > > > > Robin Murphy 于2021年3月13日周六 下午7:55写道: > > > >> > > > >>

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-15 Thread Heiko Stübner
Am Montag, 15. März 2021, 17:38:37 CET schrieb Geert Uytterhoeven: > Hi Robin, > > On Mon, Mar 15, 2021 at 5:32 PM Robin Murphy wrote: > > On 2021-03-13 13:22, CN_SZTL wrote: > > > Robin Murphy 于2021年3月13日周六 下午7:55写道: > > >> > > >> On 2021-03-13 03:25, Tianling Shen wrote: > > >>> +

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-15 Thread Geert Uytterhoeven
Hi Robin, On Mon, Mar 15, 2021 at 5:32 PM Robin Murphy wrote: > On 2021-03-13 13:22, CN_SZTL wrote: > > Robin Murphy 于2021年3月13日周六 下午7:55写道: > >> > >> On 2021-03-13 03:25, Tianling Shen wrote: > >>> + gpio-leds { > >>> + compatible = "gpio-leds"; > >>> + pinctrl-0 =

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-15 Thread Robin Murphy
On 2021-03-13 13:22, CN_SZTL wrote: Robin Murphy 于2021年3月13日周六 下午7:55写道: On 2021-03-13 03:25, Tianling Shen wrote: This adds support for the NanoPi R4S from FriendlyArm. Rockchip RK3399 SoC 1GB DDR3 or 4GB LPDDR4 RAM Gigabit Ethernet (WAN) Gigabit Ethernet (PCIe) (LAN) USB 3.0 Port x 2

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-13 Thread CN_SZTL
Robin Murphy 于2021年3月13日周六 下午7:55写道: > > On 2021-03-13 03:25, Tianling Shen wrote: > > This adds support for the NanoPi R4S from FriendlyArm. > > > > Rockchip RK3399 SoC > > 1GB DDR3 or 4GB LPDDR4 RAM > > Gigabit Ethernet (WAN) > > Gigabit Ethernet (PCIe) (LAN) > > USB 3.0 Port x 2 > > MicroSD

Re: [PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-13 Thread Robin Murphy
On 2021-03-13 03:25, Tianling Shen wrote: This adds support for the NanoPi R4S from FriendlyArm. Rockchip RK3399 SoC 1GB DDR3 or 4GB LPDDR4 RAM Gigabit Ethernet (WAN) Gigabit Ethernet (PCIe) (LAN) USB 3.0 Port x 2 MicroSD slot Reset button WAN - LAN - SYS LED [initial DTS file]

[PATCH v3 2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S

2021-03-12 Thread Tianling Shen
This adds support for the NanoPi R4S from FriendlyArm. Rockchip RK3399 SoC 1GB DDR3 or 4GB LPDDR4 RAM Gigabit Ethernet (WAN) Gigabit Ethernet (PCIe) (LAN) USB 3.0 Port x 2 MicroSD slot Reset button WAN - LAN - SYS LED [initial DTS file] Co-developed-by: Jensen Huang Signed-off-by: Jensen Huang